Skip to contentSkip to conversation

: cleanup debug message in init_kstat_irqs()

PATCH New Prarit Bhargava 1 participant 1 message Mar 10, 2010 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : cleanup debug message in init_kstat_irqs()

Cleanup a debug message in init_kstat_irqs().

This debug message can result in valid output like

alloc kstat_irqs on node -1

which looks alot like an error message.

This debug statement has been in the kernel for over a year, so I think it is safe to remove it and report the node in only the error case instead.

kernel/irq/handle.c +3 -3
index 76d5a67..e7fb871 100644
@@ -94,10 +94,10 @@ void __ref init_kstat_irqs(struct irq_desc *desc, int node, int nr)
 	 * don't overwite if can not get new one
 	 * init_copy_kstat_irqs() could still use old one
 	 */
-	if (ptr) {
-		printk(KERN_DEBUG "  alloc kstat_irqs on node %d\n", node);
+	if (ptr)
 		desc->kstat_irqs = ptr;
-	}
+	else
+		printk(KERN_ERR "  alloc kstat_irqs on node %d failed\n", node);
 }