Skip to contentSkip to conversation

mke2fs: skip alignment questioning if -F specified

PATCH Applied Eric Sandeen 3 participants 5 messages Mar 1, 2010 – Mar 12, 2010

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 mke2fs: skip alignment questioning if -F specified

RH bug 569021 - mke2fs insists on user interaction even if stdin is not a tty and -F is passed

This is just a warning, -F should easily override it.

Signed-off-by Eric Sandeen <[email protected]>

---

misc/mke2fs.c +2 -1
index 4b13367..2a23bf7 100644
@@ -1643,7 +1643,8 @@ got_size:
 		       device_name, retval);
 		printf(_("This may result in very poor performance, "
 			  "(re)-partitioning suggested.\n"));
-		proceed_question();
+		if (!force)
+			proceed_question();
 	}
 #endif
Applied
#1 lore raw
Quoted 5 lines · Eric Sandeen

RH bug 569021 - mke2fs insists on user interaction even if stdin is not a tty and -F is passed

This is just a warning, -F should easily override it.

Signed-off-by Eric Sandeen <[email protected]>

Applied to the maint branch.

- Ted

#2 lore raw
Quoted 4 lines · On 2010-03-11, at 19:48, [email protected] wrote:
Quoted 3 lines · Eric Sandeen

RH bug 569021 - mke2fs insists on user interaction even if stdin is not a tty and -F is passed

This is just a warning, -F should easily override it.

Since this is just a warning, do we really need to have "-F" at all? I dislike requiring "-F" on common actions, because it means that it will commonly be used, but may accidentally override some unintended problem.

We've lived without block device alignment until now, and it seems somewhat unpleasant that mke2fs may start failing (if -F is not given) for situations where it previously worked just fine.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

author
#3 lore raw
Quoted 7 lines · Andreas Dilger
Quoted 5 lines · On 2010-03-11, at 19:48, [email protected] wrote:
Quoted 4 lines · Eric Sandeen

RH bug 569021 - mke2fs insists on user interaction even if stdin is not a tty and -F is passed

This is just a warning, -F should easily override it.

Quoted 7 lines

Since this is just a warning, do we really need to have "-F" at all? I dislike requiring "-F" on common actions, because it means that it will commonly be used, but may accidentally override some unintended problem.

We've lived without block device alignment until now, and it seems somewhat unpleasant that mke2fs may start failing (if -F is not given) for situations where it previously worked just fine.

Well, that's a good point, dropping the -F requirement is fine with me too, I guess.

Ted do you want to just toss in:

- if (!force)
- proceed_question();

? I can send a patch but it may take longer for you to extract it from email ;)

-Eric

#4 lore raw
Quoted 21 lines · Eric Sandeen
Quoted 7 lines · Andreas Dilger
Quoted 5 lines · On 2010-03-11, at 19:48, [email protected] wrote:
Quoted 4 lines · Eric Sandeen

RH bug 569021 - mke2fs insists on user interaction even if stdin is not a tty and -F is passed

This is just a warning, -F should easily override it.

Quoted 7 lines

Since this is just a warning, do we really need to have "-F" at all? I dislike requiring "-F" on common actions, because it means that it will commonly be used, but may accidentally override some unintended problem.

We've lived without block device alignment until now, and it seems somewhat unpleasant that mke2fs may start failing (if -F is not given) for situations where it previously worked just fine.

Well, that's a good point, dropping the -F requirement is fine with me too, I guess.

Ted do you want to just toss in:

Review

Quoted 2 lines
(quoted diff) +0 -2
-		if (!force)
-			proceed_question();

Yeah, I'll just make the change on my end.

-- Ted