Skip to contentSkip to conversation

fix PHY polling system blocking

PATCH In review Stefani Seibold 2 participants 2 messages Mar 13, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix PHY polling system blocking

This patch fix the PHY poller, which can block the whole system. PHY access are normaly not very fast, since there are serial attached.

For PHY chips without interrupts, the status of the ethernet will be polled every 2 sec. The poll function will read some register of the MII PHY. The time between the sending the MII_READ_COMMAND and receiving the result could be very long (>100us).

For example:

On a Freescale PPC 834x this result in a delay of 450 us due the slow communication with the PHY chip. The time between the sending the MII_READ_COMMAND and receiving the result is more the 100 us on this controller.

The patch modifies the poller a lit bit. Only a link status state change will result in a successive detection of the connection type. The poll cycle on the other hand will be increased to one every seconds.

All in all this patch will prevent a blocking of f.e nearly 400 us every two seconds of the whole system on a PPC 834x.

There is not real drawback, only the detection of a connection type change without unplugging the cable will not work. But this is more an esoteric use case.

The patch is against kernel 2.6.33. Please merge it.

---
 phy.c        |    5 ++---
 phy_device.c |   11 ++++++++---
 2 files changed, 10 insertions(+), 6 deletions(-)
drivers/net/phy/phy.c +2 -3
diff -u -N -r -p linux-2.6.33.orig/drivers/net/phy/phy.c linux-2.6.33/drivers/net/phy/phy.c
@@ -871,9 +871,8 @@ void phy_state_machine(struct work_struc
 		case PHY_RUNNING:
 			/* Only register a CHANGE if we are
 			 * polling */
-			if (PHY_POLL == phydev->irq)
-				phydev->state = PHY_CHANGELINK;
-			break;
+			if (PHY_POLL != phydev->irq)
+				break;
 		case PHY_CHANGELINK:
 			err = phy_read_status(phydev);
 
drivers/net/phy/phy_device.c +8 -3
diff -u -N -r -p linux-2.6.33.orig/drivers/net/phy/phy_device.c linux-2.6.33/drivers/net/phy/phy_device.c
@@ -161,7 +161,7 @@ struct phy_device* phy_device_create(str
 	dev->speed = 0;
 	dev->duplex = -1;
 	dev->pause = dev->asym_pause = 0;
-	dev->link = 1;
+	dev->link = 0;
 	dev->interface = PHY_INTERFACE_MODE_GMII;
 
 	dev->autoneg = AUTONEG_ENABLE;
@@ -694,10 +694,15 @@ int genphy_update_link(struct phy_device
 	if (status < 0)
 		return status;
 
-	if ((status & BMSR_LSTATUS) == 0)
+	if ((status & BMSR_LSTATUS) == 0) {
+		if (phydev->link == 0)
+			return 1;
 		phydev->link = 0;
-	else
+	} else {
+		if (phydev->link == 1)
+			return 1;
 		phydev->link = 1;
+	}
 
 	return 0;
 }
maintainer
#1 lore raw

From: Stefani Seibold <[email protected]>
Date: Sat, 13 Mar 2010 13:53:10 +0100

Quoted 4 lines

For PHY chips without interrupts, the status of the ethernet will be polled every 2 sec. The poll function will read some register of the MII PHY. The time between the sending the MII_READ_COMMAND and receiving the result could be very long (>100us).

I'm not apply this, as I described in my previous email.

If it's expensive to detect link configuration changes that doesn't mean you just turn it off.