Skip to contentSkip to conversation

Staging: dream: smd: smd_private: fix code style issues

PATCH In review Chihau Chau 3 participants 4 messages Mar 15, 2010 – Apr 28, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: dream: smd: smd_private: fix code style issues

From: Chihau Chau <[email protected]>

This put open braces '{' following structs on the same line.

---
 drivers/staging/dream/smd/smd_private.h |   21 +++++++--------------
 1 files changed, 7 insertions(+), 14 deletions(-)
drivers/staging/dream/smd/smd_private.h +7 -14
index c0eb3de..1b2e1c8 100644
@@ -16,24 +16,21 @@
 #ifndef _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
 #define _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
 
-struct smem_heap_info
-{
+struct smem_heap_info {
 	unsigned initialized;
 	unsigned free_offset;
 	unsigned heap_remaining;
 	unsigned reserved;
 };
 
-struct smem_heap_entry
-{
+struct smem_heap_entry {
 	unsigned allocated;
 	unsigned offset;
 	unsigned size;
 	unsigned reserved;
 };
 
-struct smem_proc_comm
-{
+struct smem_proc_comm {
 	unsigned command;
 	unsigned status;
 	unsigned data1;
@@ -49,22 +46,19 @@ struct smem_proc_comm
 #define VERSION_APPS      8
 #define VERSION_MODEM     9
 
-struct smem_shared
-{
+struct smem_shared {
 	struct smem_proc_comm proc_comm[4];
 	unsigned version[32];
 	struct smem_heap_info heap_info;
 	struct smem_heap_entry heap_toc[128];
 };
 
-struct smsm_shared
-{
+struct smsm_shared {
 	unsigned host;
 	unsigned state;
 };
 
-struct smsm_interrupt_info
-{
+struct smsm_interrupt_info {
 	uint32_t aArm_en_mask;
 	uint32_t aArm_interrupts_pending;
 	uint32_t aArm_wakeup_reason;
@@ -108,8 +102,7 @@ void smsm_print_sleep_info(void);
 
 #define SMEM_NUM_SMD_CHANNELS        64
 
-typedef enum
-{
+typedef enum {
 	/* fixed items */
 	SMEM_PROC_COMM = 0,
 	SMEM_HEAP_INFO,
Signature · 1 line
1.5.6.3
#1 lore raw
Quoted 5 lines · Chihau Chau

From: Chihau Chau <[email protected]>

This put open braces '{' following structs on the same line.

ACK.

Quoted 72 lines
---
 drivers/staging/dream/smd/smd_private.h |   21 +++++++--------------
 1 files changed, 7 insertions(+), 14 deletions(-)
drivers/staging/dream/smd/smd_private.h +7 -14
index c0eb3de..1b2e1c8 100644
@@ -16,24 +16,21 @@
 #ifndef _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
 #define _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
 
-struct smem_heap_info
-{
+struct smem_heap_info {
 	unsigned initialized;
 	unsigned free_offset;
 	unsigned heap_remaining;
 	unsigned reserved;
 };
 
-struct smem_heap_entry
-{
+struct smem_heap_entry {
 	unsigned allocated;
 	unsigned offset;
 	unsigned size;
 	unsigned reserved;
 };
 
-struct smem_proc_comm
-{
+struct smem_proc_comm {
 	unsigned command;
 	unsigned status;
 	unsigned data1;
@@ -49,22 +46,19 @@ struct smem_proc_comm
 #define VERSION_APPS      8
 #define VERSION_MODEM     9
 
-struct smem_shared
-{
+struct smem_shared {
 	struct smem_proc_comm proc_comm[4];
 	unsigned version[32];
 	struct smem_heap_info heap_info;
 	struct smem_heap_entry heap_toc[128];
 };
 
-struct smsm_shared
-{
+struct smsm_shared {
 	unsigned host;
 	unsigned state;
 };
 
-struct smsm_interrupt_info
-{
+struct smsm_interrupt_info {
 	uint32_t aArm_en_mask;
 	uint32_t aArm_interrupts_pending;
 	uint32_t aArm_wakeup_reason;
@@ -108,8 +102,7 @@ void smsm_print_sleep_info(void);
 
 #define SMEM_NUM_SMD_CHANNELS        64
 
-typedef enum
-{
+typedef enum {
 	/* fixed items */
 	SMEM_PROC_COMM = 0,
 	SMEM_HEAP_INFO,
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw

So, What about this patch? Greg?

2010/3/15 Pavel Machek <[email protected]>:

Quoted 86 lines · Chihau Chau
Quoted 5 lines

From: Chihau Chau <[email protected]>

This put open braces '{' following structs on the same line.

ACK.

Quoted 63 lines

---
 drivers/staging/dream/smd/smd_private.h |   21 +++++++--------------

 1 files changed, 7 insertions(+), 14 deletions(-)
drivers/staging/dream/smd/smd_private.h +6 -12
index c0eb3de..1b2e1c8 100644
@@ -16,24 +16,21 @@
  #ifndef _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
  #define _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
 
-struct smem_heap_info
-{
+struct smem_heap_info {
       unsigned initialized;
       unsigned free_offset;
       unsigned heap_remaining;
       unsigned reserved;
  };
 
-struct smem_heap_entry
-{
+struct smem_heap_entry {
       unsigned allocated;
       unsigned offset;
       unsigned size;
       unsigned reserved;
  };
 
-struct smem_proc_comm
-{
+struct smem_proc_comm {
       unsigned command;
       unsigned status;
       unsigned data1;
@@ -49,22 +46,19 @@ struct smem_proc_comm
  #define VERSION_APPS      8
  #define VERSION_MODEM     9
 
-struct smem_shared
-{
+struct smem_shared {
       struct smem_proc_comm proc_comm[4];
       unsigned version[32];
       struct smem_heap_info heap_info;
       struct smem_heap_entry heap_toc[128];
  };
 
-struct smsm_shared
-{
+struct smsm_shared {
       unsigned host;
       unsigned state;
  };
 
-struct smsm_interrupt_info
-{
+struct smsm_interrupt_info {
       uint32_t aArm_en_mask;
       uint32_t aArm_interrupts_pending;
       uint32_t aArm_wakeup_reason;

drivers/staging/dream/smd/smd_private.h void smsm_print_sleep_info(void); · line 108

Quoted 9 lines
drivers/staging/dream/smd/smd_private.h +1 -2
@@ -108,8 +102,7 @@ void smsm_print_sleep_info(void);
 
  #define SMEM_NUM_SMD_CHANNELS        64
 
-typedef enum
-{
+typedef enum {
       /* fixed items */
       SMEM_PROC_COMM = 0,
       SMEM_HEAP_INFO,

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Signature · 1 line
Chihau Chau
#3 lore raw
Quoted 1 line · Chihau Chau

So, What about this patch? Greg?

Now queued up, sorry for the delay.

greg k-h