myri: remove dead code

PATCH Applied Dan Carpenter 3 participants 3 messages Mar 15, 2010

Subsystems (3)

Networking Network drivers Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-03-15 08:24 UTC #0 lore raw

PATCH 1/1 myri: remove dead code

We can never reach the return statement.

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/myri10ge/myri10ge.c +0 -1

index 676c513..e84dd3e 100644
@@ -3687,7 +3687,6 @@ static void myri10ge_probe_slices(struct myri10ge_priv *mgp)
 	if (status != 0) {
 		dev_err(&mgp->pdev->dev, "failed reset\n");
 		goto abort_with_fw;
-		return;
 	}
 
 	mgp->max_intr_slots = cmd.data0 / sizeof(struct mcp_slot);

Andrew Gallatin

2010-03-15 11:19 UTC #1 lore raw

Quoted 1 line · Dan Carpenter

We can never reach the return statement.

Agreed, thanks for pointing that out.

Drew

David Miller

maintainer Applied

2010-03-15 23:06 UTC #2 lore raw

From: Andrew Gallatin <[email protected]>
Date: Mon, 15 Mar 2010 07:19:26 -0400

Quoted 4 lines

Quoted 1 line · Dan Carpenter
We can never reach the return statement.
Agreed, thanks for pointing that out.

Applied, thanks everyone.