pcmcia: add important if statement

PATCH In review Dan Carpenter 2 participants 2 messages Mar 15, 2010

Subsystems (3)

SCSI Kernel janitors Ninja SCSI-3 / ninja SCSI-32Bi (16bit/CardBus) pcmcia SCSI host adapter driver

lore

Share & tools

lore

Dan Carpenter

author

2010-03-15 08:25 UTC #0 lore raw

PATCH 1/1 pcmcia: add important if statement

There was a problem introduced in Jul 2008 by:
0e6f9d270840 pcmcia: use pcmcia_loop_config in scsi pcmcia drivers

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/pcmcia/nsp_cs.c +1 -0

index c2341af..0212464 100644
@@ -1717,6 +1717,7 @@ static int nsp_cs_config(struct pcmcia_device *link)
 	cfg_mem->data = data;
 
 	ret = pcmcia_loop_config(link, nsp_cs_config_check, cfg_mem);
+	if (ret)
 		goto cs_failed;
 
 	if (link->conf.Attributes & CONF_ENABLE_IRQ) {

Dominik Brodowski

2010-03-15 13:53 UTC #1 lore raw

Dan,

thanks -- have merged your patch into my "urgent" branch which I'll push upstream soon.

Best,
Dominik