Skip to contentSkip to conversation

Remove GENHD_FL_DRIVERFS

PATCH In review NeilBrown 2 participants 2 messages Mar 16, 2010 SCSI

lore
Share & tools
lore

NeilBrown

author
#0 lore raw

PATCH 1/1 Remove GENHD_FL_DRIVERFS

This flag is not used, so best discarded.

--
Hi Jens,
I came across this recently - these are the only two occurances of "GENHD_FL_DRIVERFS" in the kernel, so it cannot be needed.
NeilBrown

drivers/scsi/sd.c +1 -1
index 83881df..a82ab3e 100644
@@ -2185,7 +2185,7 @@ static void sd_probe_async(void *data, async_cookie_t cookie)
 	blk_queue_prep_rq(sdp->request_queue, sd_prep_fn);
 
 	gd->driverfs_dev = &sdp->sdev_gendev;
-	gd->flags = GENHD_FL_EXT_DEVT | GENHD_FL_DRIVERFS;
+	gd->flags = GENHD_FL_EXT_DEVT;
 	if (sdp->removable)
 		gd->flags |= GENHD_FL_REMOVABLE;
 
include/linux/genhd.h +1 -1
index 56b5051..5f2f4c4 100644
@@ -109,7 +109,7 @@ struct hd_struct {
 };
 
 #define GENHD_FL_REMOVABLE			1
-#define GENHD_FL_DRIVERFS			2
+/* 2 is unused */
 #define GENHD_FL_MEDIA_CHANGE_NOTIFY		4
 #define GENHD_FL_CD				8
 #define GENHD_FL_UP				16
#1 lore raw
Quoted 3 lines · NeilBrown

This flag is not used, so best discarded.

Yep that looks pretty dead, thanks Neil, queued up.

Signature · 1 line
Jens Axboe