Skip to contentSkip to conversation

testsuite: get stacktrace if test drops core

PATCH In review Mike Snitzer 2 participants 4 messages Mar 16, 2010 – Mar 17, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 testsuite: get stacktrace if test drops core

Requires lvm be built with debugging (-g).
Also requires ulimit -c be non-zero (to drop core file).

test/test-utils.sh +15 -0
index 6606c56..06b9636 100644
@@ -24,6 +24,21 @@ STACKTRACE() {
 		echo "$i ${FUNC}() called from ${BASH_SOURCE[$i]}:${BASH_LINENO[$i]}"
 		i=$(($i + 1));
 	done
+
+	# Attempt to get a stacktrace if a core file exists
+	# and the lvm binary was built with debugging
+	TEST_LVM_BINARY=$(dirname $(which lvm))/../../tools/lvm
+	TEST_LVM_CORE=`ls core* | head -1`
+	GDB_BINARY=`which gdb`
+	READELF_BINARY=`which readelf`
+	if [ -n "$TEST_LVM_CORE" -a -n "$GDB_BINARY" -a -n "$READELF_BINARY" ]; then
+		if $READELF_BINARY -S $TEST_LVM_BINARY 2>&1 | grep -q .debug_info; then
+			echo bt > gdb_commands.txt
+			echo l >> gdb_commands.txt
+			echo quit >> gdb_commands.txt
+			$GDB_BINARY -batch -c $TEST_LVM_CORE -x gdb_commands.txt $TEST_LVM_BINARY
+		fi
+	fi
 }
 
 init_udev_transaction() {
#1 lore raw
Quoted 19 lines · Mike Snitzer

Requires lvm be built with debugging (-g).
Also requires ulimit -c be non-zero (to drop core file).

test/test-utils.sh +8 -0
index 6606c56..06b9636 100644
@@ -24,6 +24,21 @@ STACKTRACE() {
 		echo "$i ${FUNC}() called from ${BASH_SOURCE[$i]}:${BASH_LINENO[$i]}"
 		i=$(($i + 1));
 	done
+
+	# Attempt to get a stacktrace if a core file exists
+	# and the lvm binary was built with debugging
+	TEST_LVM_BINARY=$(dirname $(which lvm))/../../tools/lvm
+	TEST_LVM_CORE=`ls core* | head -1`
+	GDB_BINARY=`which gdb`
+	READELF_BINARY=`which readelf`
+	if [ -n "$TEST_LVM_CORE" -a -n "$GDB_BINARY" -a -n "$READELF_BINARY" ]; then

test/test-utils.sh STACKTRACE() { · line 44

Quoted 10 lines
test/test-utils.sh +7 -0
+		if $READELF_BINARY -S $TEST_LVM_BINARY 2>&1 | grep -q .debug_info; then
+			echo bt > gdb_commands.txt
+			echo l >> gdb_commands.txt
+			echo quit >> gdb_commands.txt
+			$GDB_BINARY -batch -c $TEST_LVM_CORE -x gdb_commands.txt $TEST_LVM_BINARY
+		fi
+	fi
 }
 
 init_udev_transaction() {

FYI, I verified that this change is compatible as far back as RHEL4.3.

Both gdb and readelf are commandline and runtime compatible (relative to how they are used above).

Mike

#2 lore raw

PATCH 1/1 testsuite: get stacktrace if test drops core

In reply to Mike Snitzer

Hi,

Quoted 19 lines · Mike Snitzer

Requires lvm be built with debugging (-g).
Also requires ulimit -c be non-zero (to drop core file).

test/test-utils.sh +8 -0
index 6606c56..06b9636 100644
@@ -24,6 +24,21 @@ STACKTRACE() {
 		echo "$i ${FUNC}() called from ${BASH_SOURCE[$i]}:${BASH_LINENO[$i]}"
 		i=$(($i + 1));
 	done
+
+	# Attempt to get a stacktrace if a core file exists
+	# and the lvm binary was built with debugging
+	TEST_LVM_BINARY=$(dirname $(which lvm))/../../tools/lvm
+	TEST_LVM_CORE=`ls core* | head -1`
+	GDB_BINARY=`which gdb`
+	READELF_BINARY=`which readelf`
+	if [ -n "$TEST_LVM_CORE" -a -n "$GDB_BINARY" -a -n "$READELF_BINARY" ]; then

test/test-utils.sh STACKTRACE() { · line 44

Quoted 10 lines
test/test-utils.sh +7 -0
+		if $READELF_BINARY -S $TEST_LVM_BINARY 2>&1 | grep -q .debug_info; then
+			echo bt > gdb_commands.txt
+			echo l >> gdb_commands.txt
+			echo quit >> gdb_commands.txt
+			$GDB_BINARY -batch -c $TEST_LVM_CORE -x gdb_commands.txt $TEST_LVM_BINARY
+		fi
+	fi
 }
 
 init_udev_transaction() {

Looks good to me. Maybe change "bt" to "bt full"? That would also list local variables on the stack, so more useful data. (Maybe even make it "thread apply all bt full", although we don't currently use threads here and we don't handle dmeventd coredumps either... maybe later.)

Otherwise, ACK.

Yours,
Petr.

#3 lore raw
Quoted 31 lines · Petr Rockai

Hi,

Quoted 28 lines · Mike Snitzer

Requires lvm be built with debugging (-g).
Also requires ulimit -c be non-zero (to drop core file).

test/test-utils.sh +15 -0
index 6606c56..06b9636 100644
@@ -24,6 +24,21 @@ STACKTRACE() {
 		echo "$i ${FUNC}() called from ${BASH_SOURCE[$i]}:${BASH_LINENO[$i]}"
 		i=$(($i + 1));
 	done
+
+	# Attempt to get a stacktrace if a core file exists
+	# and the lvm binary was built with debugging
+	TEST_LVM_BINARY=$(dirname $(which lvm))/../../tools/lvm
+	TEST_LVM_CORE=`ls core* | head -1`
+	GDB_BINARY=`which gdb`
+	READELF_BINARY=`which readelf`
+	if [ -n "$TEST_LVM_CORE" -a -n "$GDB_BINARY" -a -n "$READELF_BINARY" ]; then
+		if $READELF_BINARY -S $TEST_LVM_BINARY 2>&1 | grep -q .debug_info; then
+			echo bt > gdb_commands.txt
+			echo l >> gdb_commands.txt
+			echo quit >> gdb_commands.txt
+			$GDB_BINARY -batch -c $TEST_LVM_CORE -x gdb_commands.txt $TEST_LVM_BINARY
+		fi
+	fi
 }
 
Quoted 3 lines

test/test-utils.sh STACKTRACE() { · line 44

Quoted 1 line
test/test-utils.sh +0 -0
 init_udev_transaction() {

Looks good to me. Maybe change "bt" to "bt full"? That would also list local variables on the stack, so more useful data.

OK, I'll use "bt full".

Quoted 3 lines

(Maybe even make it "thread apply all bt full", although we don't currently use threads here and we don't handle dmeventd coredumps either... maybe later.)

Right, we can always change it as needed.

Quoted 1 line

Otherwise, ACK.

Thanks,
Mike