ocfs2: Update i_blocks in reflink operations.
PATCH 1/1 ocfs2: Update i_blocks in reflink operations.
Hi Joel,
Quoted 2 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ t_inode->i_blocks = ocfs2_inode_sector_count(t_inode);Curiously, why wouldn't it just be s_inode->i_blocks?
yeah, using i_blocks looks more natural. Here is the updated one.
Regards,
Tao
From 08c37fec54533cf3a04285caceda908eccab9d57 Mon Sep 17 00:00:00 2001
From: Tao Ma <[email protected]>
Date: Wed, 10 Mar 2010 09:45:00 +0800
Subject: [PATCH] ocfs2: Update i_blocks in reflink operations.
In reflink, we need to upate i_blocks for the target inode.
Reported-by Jie Liu <[email protected]>
Signed-off-by Tao Ma <[email protected]>
--- fs/ocfs2/refcounttree.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ocfs2/refcounttree.c +1 -0
@@ -4075,6 +4075,7 @@ static int ocfs2_complete_reflink(struct inode *s_inode,OCFS2_I (t_inode)->ip_dyn_features =OCFS2_I (s_inode)->ip_dyn_features;spin_unlock (&OCFS2_I (t_inode)->ip_lock);i_size_write (t_inode, size); + t_inode->i_blocks = s_inode->i_blocks; di->i_xattr_inline_size = s_di->i_xattr_inline_size; di->i_clusters = s_di->i_clusters;
Signature · 1 line
1.5.5
PATCH 1/1 ocfs2: Update i_blocks in reflink operations.
Quoted 4 lines · Tao Ma
In reflink, we need to upate
i_blocksfor the target inode.Reported-by Jie Liu <[email protected]>Signed-off-by Tao Ma <[email protected]>
This patch is now in the fixes branch of ocfs2.git.
Joel
Signature · 8 lines
"To fall in love is to create a religion that has a fallible god."
-Jorge Luis Borges
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127