Skip to contentSkip to conversation

ixgbe: Fix 82599 KX4 Wake on LAN issue after an improper system shutdown

PATCH Applied Jeff Kirsher 2 participants 2 messages Mar 19, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: Fix 82599 KX4 Wake on LAN issue after an improper system shutdown

From: Mallikarjuna R Chilakala <[email protected]>

Advanced Power Management is disabled for 82599 KX4 connections by clearing GRC.APME bit, causing it to not wake the system from an improper system shutdown. By default GRC.APME is enabled and software is not supposed to clear these settings during adapter probe.

---

 drivers/net/ixgbe/ixgbe_main.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +0 -3
index b858a1a..18b5b21 100644
@@ -6246,9 +6246,6 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
 	case IXGBE_DEV_ID_82599_KX4:
 		adapter->wol = (IXGBE_WUFC_MAG | IXGBE_WUFC_EX |
 		                IXGBE_WUFC_MC | IXGBE_WUFC_BC);
-		/* Enable ACPI wakeup in GRC */
-		IXGBE_WRITE_REG(hw, IXGBE_GRC,
-		             (IXGBE_READ_REG(hw, IXGBE_GRC) & ~IXGBE_GRC_APME));
 		break;
 	default:
 		adapter->wol = 0;
maintainer Applied
#1 lore raw

From: Jeff Kirsher <[email protected]>
Date: Thu, 18 Mar 2010 18:16:56 -0700

Quoted 9 lines

From: Mallikarjuna R Chilakala <[email protected]>

Advanced Power Management is disabled for 82599 KX4 connections by clearing GRC.APME bit, causing it to not wake the system from an improper system shutdown. By default GRC.APME is enabled and software is not supposed to clear these settings during adapter probe.

Applied.