Skip to contentSkip to conversation

LVM: testsuite fixes 2

PATCH New Jonathan Brassow 2 participants 2 messages Mar 18, 2010 – Mar 23, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 LVM: testsuite fixes 2

Patch name: lvm-testsuite-fixes-2.patch

Flip the 'not' on a test that should be working.

test/t-lvconvert-repair.sh +1 -1
Index: LVM2/test/t-lvconvert-repair.sh
===================================================================
@@ -69,5 +69,5 @@ vgextend $vg $dev3
 lvcreate -m 2 -l 1 -n mirror2 $vg $dev1 $dev2 $dev3 $dev4
 vgchange -a n $vg
 pvremove -ff -y $dev4
-echo 'y' | not lvconvert -y -i 1 --repair $vg/mirror2
+echo 'y' | lvconvert -y -i 1 --repair $vg/mirror2
 vgs
#1 lore raw

PATCH 1/1 LVM: testsuite fixes 2

Hi,

test/t-lvconvert-repair.sh vgextend $vg $dev3 · line 73

Quoted 13 lines · Jonathan Brassow

Flip the 'not' on a test that should be working.

Index: LVM2/test/t-lvconvert-repair.sh
===================================================================

test/t-lvconvert-repair.sh +1 -1
@@ -69,5 +69,5 @@ vgextend $vg $dev3
 lvcreate -m 2 -l 1 -n mirror2 $vg $dev1 $dev2 $dev3 $dev4
 vgchange -a n $vg
 pvremove -ff -y $dev4
-echo 'y' | not lvconvert -y -i 1 --repair $vg/mirror2
+echo 'y' | lvconvert -y -i 1 --repair $vg/mirror2
 vgs

now, this is interesting. Any idea why the lvconvert used to fail and now passes? It seems there's $dev5 around, so this should be used for the repair... I'll look at the later patches, maybe that'll explain...

Yours,
Petr.