Skip to contentSkip to conversation

Fix ecryptfs related OOPs after umount

PATCH New Christian Ehrhardt 1 participant 1 message Mar 19, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix ecryptfs related OOPs after umount

Hi,

the following patch removes a d_drop in ecryptfs that is bogus IMHO. This d_drop unhashes a perfectly valid and reachable dentry in the lower FS. The patch fixes this perfectly reproducible kernel oops:

    https://bugzilla.kernel.org/show_bug.cgi?id=10907

It and may or may not be related to this ecryptfs bug:

https://bugs.launchpad.net/ecryptfs/+bug/363734

At least the BUG_ON is on a dentry that should not be unhashed but is.

regards Christian

fs/ecryptfs/super.c +0 -1
index b15a43a..1a037f7 100644
@@ -85,7 +85,6 @@ static void ecryptfs_destroy_inode(struct inode *inode)
 		if (lower_dentry->d_inode) {
 			fput(inode_info->lower_file);
 			inode_info->lower_file = NULL;
-			d_drop(lower_dentry);
 		}
 	}
 	ecryptfs_destroy_crypt_stat(&inode_info->crypt_stat);