Skip to contentSkip to conversation

blacklist lid status: Sony VGN-BX196VP and Elite Co.

PATCH In review Surbhi Palande 4 participants 7 messages Mar 15, 2010 – Mar 19, 2010 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

cover blacklist lid status: Sony VGN-BX196VP and Elite Co.

The following two patches are quirks that blacklist bios which report incorrect lid status. These are bioses for machines with a 900 GM. The first one is tested by Ubuntu users and the second one isn't. Further testing will be appreciated.

Surbhi Palande (2):
drm/i915: blacklist lid status: Sony VGN-BX196VP drm/i915: blacklist lid status: Elite Co. G335

 drivers/gpu/drm/i915/intel_lvds.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
#2 lore raw

PATCH 1/2 drm/i915: blacklist lid status: Sony VGN-BX196VP

Sony VGN-BX196VP reports the lid status as closed when it is open. This leads to a "no connectors reported" error at startup. Blacklisting it to always return a connected status for the default lvds connector.

---
 drivers/gpu/drm/i915/intel_lvds.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_lvds.c +7 -0
index c2e8a45..afd0ee7 100644
@@ -643,6 +643,13 @@ static const struct dmi_system_id bad_lid_status[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "M5x0N"),
 		},
 	},
+	{
+		.ident = "Sony VGN-BX196VP",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+			DMI_MATCH(DMI_BOARD_NAME, "VGN-BX196VP"),
+		},
+	},
 	{ }
 };
 
Signature · 1 line
1.6.3.3
#3 lore raw

PATCH 2/2 drm/i915: blacklist lid status: Elite Co. G335

In reply to Surbhi Palande

Elite Computers G335 reports the lid status as closed when it is open. This leads to a "no connectors reported" error at startup. Blacklisting it to always return a connected status for the default lvds connector.

---
 drivers/gpu/drm/i915/intel_lvds.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_lvds.c +7 -0
index afd0ee7..b75a941 100644
@@ -650,6 +650,13 @@ static const struct dmi_system_id bad_lid_status[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "VGN-BX196VP"),
 		},
 	},
+	{
+		.ident = "Elitegroup ECS G335",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Elitegroup Co."),
+			DMI_MATCH(DMI_BOARD_NAME, "ECS G335"),
+		},
+	},
 	{ }
 };
 
Signature · 1 line
1.6.3.3
#4 lore raw

Re: ACPI _LID failures

In reply to Surbhi Palande
Quoted 6 lines · On Mon, 15 Mar 2010 21:32:41 +0200 Surbhi Palande…

The following two patches are quirks that blacklist bios which report incorrect lid status. These are bioses for machines with a 900 GM. The first one is tested by Ubuntu users and the second one isn't. Further testing will be appreciated.

Quoted 6 lines

Surbhi Palande (2):
drm/i915: blacklist lid status: Sony VGN-BX196VP drm/i915: blacklist lid status: Elite Co. G335

 drivers/gpu/drm/i915/intel_lvds.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

Patches look ok to me. Len was curious about whether some recent ACPI EC fixes will fix some of our lid detection bugs though.

Len, is there any particular patch or version people should try?

Thanks,

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#5 lore raw

Re: ACPI _LID failures

Quoted 13 lines · Jesse Barnes
Quoted 10 lines · On Mon, 15 Mar 2010 21:32:41 +0200 Surbhi Palande…

The following two patches are quirks that blacklist bios which report incorrect lid status. These are bioses for machines with a 900 GM. The first one is tested by Ubuntu users and the second one isn't. Further testing will be appreciated.

Surbhi Palande (2):
drm/i915: blacklist lid status: Sony VGN-BX196VP drm/i915: blacklist lid status: Elite Co. G335

Quoted 7 lines
Quoted 2 lines
 drivers/gpu/drm/i915/intel_lvds.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

Patches look ok to me. Len was curious about whether some recent ACPI EC fixes will fix some of our lid detection bugs though.

Len, is there any particular patch or version people should try?

Unless ACPI is going to magically become more reliable at the lid method, I think we should abandon using it on generations where it fails. See other patch I submitted -- anyone care to ack it?

#6 lore raw

Re: ACPI _LID failures

Quoted 17 lines · On Fri, 19 Mar 2010 13:53:10 -0700 Eric Anholt <[email protected]> wrote:
Quoted 16 lines · Jesse Barnes
Quoted 12 lines · On Mon, 15 Mar 2010 21:32:41 +0200 Surbhi Palande…

The following two patches are quirks that blacklist bios which report incorrect lid status. These are bioses for machines with a 900 GM. The first one is tested by Ubuntu users and the second one isn't. Further testing will be appreciated.

Surbhi Palande (2):
drm/i915: blacklist lid status: Sony VGN-BX196VP drm/i915: blacklist lid status: Elite Co. G335

 drivers/gpu/drm/i915/intel_lvds.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
Quoted 8 lines
Quoted 4 lines

Patches look ok to me. Len was curious about whether some recent ACPI EC fixes will fix some of our lid detection bugs though.

Len, is there any particular patch or version people should try?

Unless ACPI is going to magically become more reliable at the lid method, I think we should abandon using it on generations where it fails. See other patch I submitted -- anyone care to ack it?

Well, that was the hope. Len said they've fixed EC bugs in the past only to find that several ACPI methods they assumed were broken suddenly started working....

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#7 lore raw

Re: ACPI _LID failures

Quoted 3 lines · Jesse Barnes

Well, that was the hope. Len said they've fixed EC bugs in the past only to find that several ACPI methods they assumed were broken suddenly started working....

The broken Acer was reading from the wrong registers. I think that's pretty strong evidence that Windows doesn't depend on lid state, unfortunately.

Signature · 1 line
Matthew Garrett | [email protected]