Skip to contentSkip to conversation

nios2: Add missing Ethernet initialization to board_init().

PATCH New Scott McNutt 2 participants 3 messages Mar 21, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nios2: Add missing Ethernet initialization to board_init().

---
 lib_nios2/board.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
lib_nios2/board.c +8 -0
index 41d3297..311d66c 100644
@@ -139,6 +139,14 @@ void board_init (void)
 	board_late_init ();
 #endif
 
+#if defined(CONFIG_CMD_NET)
+#if defined(CONFIG_NET_MULTI)
+	WATCHDOG_RESET ();
+	puts ("Net:   ");
+#endif
+	eth_initialize (bd);
+#endif
+
 	/* main_loop */
 	for (;;) {
 		WATCHDOG_RESET ();
Signature · 1 line
1.6.0.6
#1 lore raw

PATCH 1/1 nios2: Add missing Ethernet initialization to board_init().

lib_nios2/board.c void board_init (void) · line 145

Quoted 2 lines · On Sunday 21 March 2010 13:37:53 Scott McNutt wrote:
lib_nios2/board.c +2 -0
+	WATCHDOG_RESET ();
+	puts ("Net:   ");

considering serial drivers' putc() should be calling watchdog reset, does this really make sense here ? looks like a wart in a few arches you shouldnt be copying over ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100321/00e8fa8c/attachment.pgp

#2 lore raw

PATCH 1/1 nios2: Add missing Ethernet initialization to board_init().

Quoted 6 lines · Mike Frysinger

lib_nios2/board.c void board_init (void) · line 145

Quoted 2 lines · On Sunday 21 March 2010 13:37:53 Scott McNutt wrote:
lib_nios2/board.c +2 -0
+	WATCHDOG_RESET ();
+	puts ("Net:   ");

considering serial drivers' putc() should be calling watchdog reset, does this really make sense here ?

No.

Quoted 2 lines

looks like a wart in a few arches you shouldnt be
copying over ...

Agreed. Warts can become difficult to remove. ;-)

Regards,
--Scott