POST progress API
PATCH 1/1 POST progress API
Added POST progress API implemented as weak calls before and after each call to the POST test callback in the post_run_single routine of the post.c file.
--- include/post.h | 5 +++++ post/post.c | 17 +++++++++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-)
include/post.h +5 -0
@@ -53,6 +53,11 @@#define POST_FAIL_SAVE 0x80 +#define POST_BEFORE 1 +#define POST_AFTER 0 +#define POST_PASSED 1 +#define POST_FAILED 0 +#ifndef __ASSEMBLY__ struct post_test {
post/post.c +15 -2
@@ -231,6 +231,12 @@ static void post_get_flags (int *test_flags) } } +void __show_post_progress (unsigned int test_num,int before,int result) +{ +} +void show_post_progress (unsigned int ,int ,int ) + __attribute__((weak,alias ("__show_post_progress" ))); +static int post_run_single (struct post_test *test,int test_flags,int flags,unsigned int i) {
@@ -248,13 +254,18 @@ static int post_run_single (struct post_test *test,if (test_flags &POST_PREREL )post_log_mark_start ( test->testid );else -post_log ("POST %s " , test->cmd); +post_log ("POST %s " , test->cmd); } +show_post_progress (i,POST_BEFORE ,POST_FAILED ); +if (test_flags &POST_PREREL ) { -if ((*test->test) (flags) ==0 ) +if ((*test->test) (flags) ==0 ) {post_log_mark_succ ( test->testid ); +show_post_progress (i,POST_AFTER ,POST_PASSED ); + }else { +show_post_progress (i,POST_AFTER ,POST_FAILED );if (test_flags &POST_CRITICAL ) gd->flags |=GD_FLG_POSTFAIL ;if (test_flags &POST_STOP )
@@ -264,6 +275,7 @@ static int post_run_single (struct post_test *test,if ((*test->test) (flags) !=0 ) {post_log ("FAILED\n" );show_boot_progress (-32 ); +show_post_progress (i,POST_AFTER ,POST_FAILED );if (test_flags &POST_CRITICAL ) gd->flags |=GD_FLG_POSTFAIL ;if (test_flags &POST_STOP )
@@ -271,6 +283,7 @@ static int post_run_single (struct post_test *test, }else post_log ("PASSED\n" ); +show_post_progress (i,POST_AFTER ,POST_PASSED ); }if ((test_flags &POST_REBOOT ) && !(flags &POST_MANUAL )) {
Signature · 1 line
1.6.3.3
PATCH 1/1 POST progress API
Hi Michael,
Quoted 5 lines
Added POST progress API implemented as weak calls before and after each call to the POST test callback in the
post_run_singleroutine of thepost.cfile.Signed-off-by Michael Zaidman <[email protected]>
Cheers
Detlev
Signature · 9 lines
It's bad civic hygiene to build technologies that could someday be used to facilitate a police state. No matter what the eavesdroppers and censors say, these systems put us all at greater risk. Communications systems that have no inherent eavesdropping capabilities are more secure than systems with those capabilities built in. -- Bruce Schneier -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
PATCH 1/1 POST progress API
Hi Wolfgang,
Is there a chance this patch will be included already in this release?
Quoted 6 lines · Detlev Zundel
Hi Michael,
Quoted 4 lines
Added POST progress API implemented as weak calls before and after each call to the POST test callback in the
post_run_singleroutine of thepost.cfile.
Quoted 6 lines
Quoted 1 line
Signed-off-by Michael Zaidman <[email protected]>Acked-by Detlev Zundel <[email protected]>Cheers
?Detlev
Thanks,
Michael
PATCH 1/1 POST progress API
Dear Michael Zaidman,
Quoted 2 lines · In message <[email protected]> you…
Is there a chance this patch will be included already in this release?
Sorry, but no. This is new code (i. e. not a bug fix) and thus has to wait for the next merge window. We pull it into the "next" branch now so that it is in fact already on the fast-lane there.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A verbal contract isn't worth the paper it's written on.
-- Samuel GoldwynPATCH 1/1 POST progress API
Quoted 6 lines · Wolfgang Denk
Dear Michael Zaidman,
Quoted 2 lines · In message <[email protected]> you…
Is there a chance this patch will be included already in this release?
Quoted 7 lines
Sorry, but no. This is new code (i. e. not a bug fix) and thus has to wait for the next merge window. ?We pull it into the "next" branch now so that it is in fact already on the fast-lane there.
Best regards,
Wolfgang Denk
Thanks,
Michael
Wolfgang Denk
AppliedPATCH 1/1 POST progress API
In reply to Michael ZaidmanDear Michael Zaidman,
Quoted 9 lines · In message <[email protected]> you…
Added POST progress API implemented as weak calls before and after each call to the POST test callback in the
post_run_singleroutine of thepost.cfile.Signed-off-by Michael Zaidman <[email protected]>--- include/post.h | 5 +++++ post/post.c | 17 +++++++++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-)
Applied to "next" branch. Thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Thought for the day: What if there were no hypothetical situations?