Add support for PDM360NG board

Fix warnings while compiling with CONFIG_VIDEO enabled:

diu.c: In function 'video_hw_init':
diu.c:158: warning: 'return' with no value, in function returning non-void diu.c:162: warning: format '%ld' expects type 'long int', but argument 6 has type 'int' diu.c:162: warning: format '%ld' expects type 'long int', but argument 7 has type 'int'

Signed-off-by Anatolij Gustschin <[email protected]>

---
New patch in this series, needed after cfb_console driver activation.

 cpu/mpc512x/diu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--===============0837153488==

PDM360NG is a MPC5121E based board by ifm ecomatic gmbh.

Signed-off-by Michael Weiss <[email protected]>

Signed-off-by Anatolij Gustschin <[email protected]>

---
Changes since first version:
- don't include RLE8 bitmap support in DIU code, now it is in common code submitted to U-Boot ML as separate patch. It is also extended to support more video formats.
- fixed e-mail format
- keep the list of targets sorted in the Makefile
- move POST code into separate file
- move post_word_load/store code to common file for

all mpc512x boards
- create a file with common board config options for mpc512x boards which can be included in the board config file.
- use cfb_console driver for frame buffer support
- allow configuration of coprocessor communication parameters (baudrate, wait delay) in the board config file

 MAKEALL                             |    1 +
 Makefile                            |    3 +
 board/freescale/common/fsl_diu_fb.c |   29 ++-
 board/pdm360ng/Makefile             |   52 ++++
 board/pdm360ng/config.mk            |   24 ++
 board/pdm360ng/pdm360ng.c           |  525 +++++++++++++++++++++++++++++++++++
 board/pdm360ng/post.c               |   75 +++++
 cpu/mpc512x/diu.c                   |   14 +-
 include/configs/mpc5121-common.h    |   52 ++++
 include/configs/pdm360ng.h          |  520 ++++++++++++++++++++++++++++++++++
 include/post.h                      |    1 +

 post/tests.c                        |    4 +
 12 files changed, 1294 insertions(+), 6 deletions(-)
 create mode 100644 board/pdm360ng/Makefile
 create mode 100644 board/pdm360ng/config.mk
 create mode 100644 board/pdm360ng/pdm360ng.c
 create mode 100644 board/pdm360ng/post.c
 create mode 100644 include/configs/mpc5121-common.h
 create mode 100644 include/configs/pdm360ng.h

board/pdm360ng/pdm360ng.c new file +19 -0

+#if defined(CONFIG_HARD_I2C)
+	if (!getenv("ethaddr")) {
+		uchar buf[6];
+		char mac[18];
+		int ret;
+
+		/* I2C-0 for on-board eeprom */
+		i2c_set_bus_num(CONFIG_SYS_I2C_EEPROM_BUS_NUM);
+
+		/* Read ethaddr from EEPROM */
+		ret = i2c_read(CONFIG_SYS_I2C_EEPROM_ADDR,
+			       CONFIG_SYS_I2C_EEPROM_MAC_OFFSET, 1, buf, 6);
+		if (!ret) {
+			sprintf(mac, "%02X:%02X:%02X:%02X:%02X:%02X",
+				buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]);
+			/* Owned by IFM ? */
+			if (strstr(mac, "00:02:01") != mac) {
+				printf("Illegal MAC address in EEPROM: %s\n",
+				       mac);

cpu/mpc512x/diu.c +0 -0

index a24f395..fc43a9d 100644
@@ -68,8 +68,13 @@ char *valid_bmp(char *addr)
 	unsigned long h_addr;
 

+/* DDR Controller Configuration for Micron DDR2 SDRAM MT47H128M8-3
+ *

Quoted 7 lines

 12 files changed, 1294 insertions(+), 6 deletions(-)
 create mode 100644 board/pdm360ng/Makefile
 create mode 100644 board/pdm360ng/config.mk
 create mode 100644 board/pdm360ng/pdm360ng.c
 create mode 100644 board/pdm360ng/post.c
 create mode 100644 include/configs/mpc5121-common.h
 create mode 100644 include/configs/pdm360ng.h

Entry to MAINTAINERS file is missing.

Quoted 24 lines

board/pdm360ng/pdm360ng.c new file +24 -0

+#if defined(CONFIG_HARD_I2C)
+	if (!getenv("ethaddr")) {
+		uchar buf[6];
+		char mac[18];
+		int ret;
+
+		/* I2C-0 for on-board eeprom */
+		i2c_set_bus_num(CONFIG_SYS_I2C_EEPROM_BUS_NUM);
+
+		/* Read ethaddr from EEPROM */
+		ret = i2c_read(CONFIG_SYS_I2C_EEPROM_ADDR,
+			       CONFIG_SYS_I2C_EEPROM_MAC_OFFSET, 1, buf, 6);
+		if (!ret) {
+			sprintf(mac, "%02X:%02X:%02X:%02X:%02X:%02X",
+				buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]);
+			/* Owned by IFM ? */
+			if (strstr(mac, "00:02:01") != mac) {
+				printf("Illegal MAC address in EEPROM: %s\n",
+				       mac);
+			} else {
+				debug("Using MAC from I2C EEPROM: %s\n", mac);
+				setenv("ethaddr", mac);
+			}
+		} else {

board/pdm360ng/pdm360ng.c line 191

Quoted 5 lines

board/pdm360ng/pdm360ng.c new file +5 -0

+			printf("Error: Unable to read MAC from I2C"
+				" EEPROM at address %02X:%02X\n",
+				CONFIG_SYS_I2C_EEPROM_ADDR,
+				CONFIG_SYS_I2C_EEPROM_MAC_OFFSET);
+		}

Please see comments in previous message. IMHO this needs to be rewritten.

board/pdm360ng/pdm360ng.c line 454

Quoted 10 lines

board/pdm360ng/pdm360ng.c new file +9 -0

+#if defined(CONFIG_SERIAL_MULTI)
+/*
+ * If argument is NULL, set the LCD brightness to the
+ * value from "brightness" environment variable. Set
+ * the LCD brightness to the value specified by the
+ * argument otherwise. Default brightness is zero.
+ */
+#define MAX_BRIGHTNESS	99
+static int set_lcd_brightness(char *brightness)

This seems wrong to me. Why does LCD related code depend on CONFIG_SERIAL_MULTI ???

Quoted 7 lines

cpu/mpc512x/diu.c +0 -0

index a24f395..fc43a9d 100644
@@ -68,8 +68,13 @@ char *valid_bmp(char *addr)
 	unsigned long h_addr;
 

cpu/mpc512x/diu.c char *valid_bmp(char *addr) · line 77

Quoted 10 lines

cpu/mpc512x/diu.c +7 -2

 	h_addr = simple_strtoul(addr, NULL, 16);
-	if (h_addr < CONFIG_SYS_FLASH_BASE ||
-			h_addr >= (CONFIG_SYS_FLASH_BASE + CONFIG_SYS_FLASH_SIZE - 1)) {
+	if ((h_addr < CONFIG_SYS_FLASH_BASE ||
+		h_addr >= (CONFIG_SYS_FLASH_BASE + CONFIG_SYS_FLASH_SIZE - 1))
+#if defined(CONFIG_SYS_FLASH1_BASE) && defined(CONFIG_SYS_FLASH1_SIZE)
+	   && (h_addr < CONFIG_SYS_FLASH1_BASE ||
+	       h_addr >= (CONFIG_SYS_FLASH1_BASE + CONFIG_SYS_FLASH1_SIZE - 1))
+#endif
+	) {

I don't like this. Why do we see hardcoded values here and not the data from the CFI driver's auto-sizing? I assume both flash banks are maped into one big contiguous array of NOR flash, right? Then there should be just a single test for "< base || >(base+size)" here, using the total size of the combined flash banks.

cpu/mpc512x/diu.c char *valid_bmp(char *addr) · line 79

Quoted 2 lines

cpu/mpc512x/diu.c +0 -0

 		printf("bmp addr %lx is not a valid flash address\n", h_addr);
 		return 0;

And why would it be necessary that the BMP resides in NOR flash in the first place?

Why cannot - for example - a "preboot" command be used to read it from SDCard into RAM?

[I am aware that you did not create this code, but anyways - it seems wrong to me.]

cpu/mpc512x/diu.c int mpc5121_diu_init(void) · line 99

Quoted 7 lines

cpu/mpc512x/diu.c +5 -0

+#ifdef CONFIG_PDM360NG
+	xres = 800;
+	yres = 480;
+#else
 	xres = 1024;
 	yres = 768;
+#endif

Please avoid the board specific #define here. Please check for a feature instead (resolution = 800x400).

Quoted 1 line

+#undef DEBUG

Please remove dead code.

cpu/mpc512x/diu.c

Quoted 3 lines

cpu/mpc512x/diu.c +3 -0

+#define CONFIG_PDM360NG 1
+#define CONFIG_PDM360NG_BIG	/* PDM360NG with big memory */
+#undef CONFIG_PDM360NG_SMALL	/* PDM360NG with small memory */

This makes no sense. If you want to toggle between "small" and "big" configurations, then please use a single #define which is either set or not set.

I don't see why this is needed at all. Does not U-Boot auto-detect the RAM size, so you can auto-adjust all code where needed? If not, then this should be fixed.

cpu/mpc512x/diu.c

Quoted 10 lines

cpu/mpc512x/diu.c +10 -0

+/*
+ * DDR Setup - manually set all parameters as there's no SPD etc.
+ */
+#ifdef CONFIG_PDM360NG_BIG
+#define CONFIG_SYS_DDR_SIZE		512		/* MB */
+#elif defined CONFIG_PDM360NG_SMALL
+#define CONFIG_SYS_DDR_SIZE		128		/* MB */
+#else
+#error No memory configuration level defined!
+#endif

Please use auto-sizing with get_ram_size() instead, so a single U-Boot image can be used with both configurations.

Quoted 2 lines

+/* DDR Controller Configuration for Micron DDR2 SDRAM MT47H128M8-3
+ *

Incorrect multiline comment format.

And: comment and code seem to differ - the comment explains one configuration, but the code has 2 ("small" and "big") ?

Quoted 4 lines

cpu/mpc512x/diu.c +4 -0

+#define CONFIG_SYS_DDRCMD_NOP		0x01380000
+#define CONFIG_SYS_DDRCMD_PCHG_ALL	0x01100400
+#define CONFIG_SYS_DDRCMD_EM2		0x01020000  /* EMR2 */
+#define CONFIG_SYS_DDRCMD_EM3		0x01030000  /* EMR3 */

cpu/mpc512x/diu.c

Quoted 6 lines

cpu/mpc512x/diu.c +6 -0

+#define CONFIG_SYS_DDRCMD_EN_DLL	0x01010040  /* EMR  with 150 ohm ODT todo: verify*/
+#define CONFIG_SYS_DDRCMD_RES_DLL	0x01000100
+#define CONFIG_SYS_DDRCMD_RFSH		0x01080000
+#define CONFIG_SYS_MICRON_INIT_DEV_OP	0x01000432
+#define CONFIG_SYS_DDRCMD_OCD_DEFAULT	0x010107C0  /* EMR  with 150 ohm ODT todo: verify*/
+#define CONFIG_SYS_DDRCMD_OCD_EXIT	0x01010440  /* EMR new command with 150 ohm ODT todo: verify*/

Lines way too long. Please fix globally.

cpu/mpc512x/diu.c

Quoted 4 lines

+ * Serial Port
+ */

cpu/mpc512x/diu.c +2 -0

+#define CONFIG_CONS_INDEX     1
+#undef CONFIG_SERIAL_SOFTWARE_FIFO

Please do not #undef what is not defined anyway. Please remove dead code globally.

Quoted 4 lines

cpu/mpc512x/diu.c +4 -0

+#define CONFIG_CMD_ASKENV
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_I2C
+#define CONFIG_CMD_MII

cpu/mpc512x/diu.c

Quoted 6 lines

cpu/mpc512x/diu.c +6 -0

+#define CONFIG_CMD_NFS
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_REGINFO
+#define CONFIG_CMD_EEPROM
+#define CONFIG_CMD_DATE
+#undef CONFIG_CMD_FUSE

You may want to sort that list.

Quoted 5 lines

cpu/mpc512x/diu.c +5 -0

+#define CONFIG_POST_COPROC    {\
+	"Coprocessors communication test",		\
+	"coproc_com",					\
+	"This test checks communication with coprocessors.",	\
+	POST_RAM | POST_ALWAYS | POST_CRITICAL,		\

cpu/mpc512x/diu.c

Quoted 6 lines

cpu/mpc512x/diu.c +6 -0

+	&pdm360ng_coprocessor_post_test,		\
+	NULL,						\
+	NULL,						\
+	CONFIG_SYS_POST_COPROC				\
+	}
+#endif

This does not belong into the board config file.

include/post.h extern int post_hotkeys_pressed(void); · line 122

Quoted 9 lines

include/post.h +1 -0

index 9fcd3ce..d147103 100644
@@ -119,6 +119,7 @@ extern int post_hotkeys_pressed(void);
 #define CONFIG_SYS_POST_BSPEC4		0x00080000
 #define CONFIG_SYS_POST_BSPEC5		0x00100000
 #define CONFIG_SYS_POST_CODEC		0x00200000
+#define CONFIG_SYS_POST_COPROC		0x00400000

Please split the POST specific code out into a separate commit.

Adds coprocessor communication POST code.

Signed-off-by Anatolij Gustschin <[email protected]>

---
 board/pdm360ng/Makefile    |    1 +
 board/pdm360ng/post.c      |   75 ++++++++++++++++++++++++++++++++++++++++++++
 include/configs/pdm360ng.h |    5 +++
 include/post.h             |    1 +
 post/tests.c               |   13 +++++++
 5 files changed, 95 insertions(+), 0 deletions(-)
 create mode 100644 board/pdm360ng/post.c

post/tests.c +4 -0

@@ -53,6 +53,7 @@ extern int gdc_post_test (int flags);
 extern int fpga_post_test (int flags);
 extern int lwmon5_watchdog_post_test(int flags);
 extern int sysmon1_post_test(int flags);
+extern int pdm360ng_coprocessor_post_test(int flags);
 
 extern int sysmon_init_f (void);
 

@@ -286,6 +287,18 @@ struct post_test post_list[] =
 #if CONFIG_POST & CONFIG_SYS_POST_BSPEC5
 	CONFIG_POST_BSPEC5,
 #endif
+#if CONFIG_POST & CONFIG_SYS_POST_COPROC
+    {
+	"Coprocessors communication test",

Dear Anatolij Gustschin,

Quoted 11 lines · In message <[email protected]> you wrote:

Adds coprocessor communication POST code.

Signed-off-by Anatolij Gustschin <[email protected]>

---
 board/pdm360ng/Makefile    |    1 +
 board/pdm360ng/post.c      |   75 ++++++++++++++++++++++++++++++++++++++++++++
 include/configs/pdm360ng.h |    5 +++
 include/post.h             |    1 +
 post/tests.c               |   13 +++++++
 5 files changed, 95 insertions(+), 0 deletions(-)
 create mode 100644 board/pdm360ng/post.c

...

Quoted 22 lines

post/tests.c +9 -0

@@ -53,6 +53,7 @@ extern int gdc_post_test (int flags);
 extern int fpga_post_test (int flags);
 extern int lwmon5_watchdog_post_test(int flags);
 extern int sysmon1_post_test(int flags);
+extern int pdm360ng_coprocessor_post_test(int flags);
 
 extern int sysmon_init_f (void);
 

@@ -286,6 +287,18 @@ struct post_test post_list[] =
 #if CONFIG_POST & CONFIG_SYS_POST_BSPEC5
 	CONFIG_POST_BSPEC5,
 #endif
+#if CONFIG_POST & CONFIG_SYS_POST_COPROC
+    {
+	"Coprocessors communication test",
+	"coproc_com",
+	"This test checks communication with coprocessors.",
+	POST_RAM | POST_ALWAYS | POST_CRITICAL,
+	&pdm360ng_coprocessor_post_test,
+	NULL,

post/tests.c struct post_test post_list[] = · line 302

Quoted 5 lines

post/tests.c +4 -0

+	NULL,
+	CONFIG_SYS_POST_COPROC
+    }
+#endif
 };

I don't want to see board specific code (pdm360ng_*) in such a global file. Please use a more generic approach.

Quoted 12 lines

Quoted 12 lines

post/tests.c +8 -0

@@ -286,6 +287,18 @@ struct post_test post_list[] =
 #if CONFIG_POST & CONFIG_SYS_POST_BSPEC5
 	CONFIG_POST_BSPEC5,
 #endif
+#if CONFIG_POST & CONFIG_SYS_POST_COPROC
+    {
+	"Coprocessors communication test",
+	"coproc_com",
+	"This test checks communication with coprocessors.",
+	POST_RAM | POST_ALWAYS | POST_CRITICAL,
+	&pdm360ng_coprocessor_post_test,
+	NULL,

Quoted 8 lines

post/tests.c struct post_test post_list[] = · line 302

Quoted 5 lines

post/tests.c +4 -0

+	NULL,
+	CONFIG_SYS_POST_COPROC
+    }
+#endif
 };

I don't want to see board specific code (pdm360ng_*) in such a global file. Please use a more generic approach.

Do you mean like for example CONFIG_POST_BSPEC1 used for lwmon5?

Anatolij, this should be straight forward.

Similar was in the first patch version. But according to Wolfgang this doesn't belong in the board config file.

Quoted 13 lines

Quoted 13 lines

post/tests.c +8 -0

@@ -286,6 +287,18 @@ struct post_test post_list[] =
 #if CONFIG_POST & CONFIG_SYS_POST_BSPEC5
 	CONFIG_POST_BSPEC5,
 #endif
+#if CONFIG_POST & CONFIG_SYS_POST_COPROC
+    {
+	"Coprocessors communication test",
+	"coproc_com",
+	"This test checks communication with coprocessors.",
+	POST_RAM | POST_ALWAYS | POST_CRITICAL,
+	&pdm360ng_coprocessor_post_test,
+	NULL,

Quoted 8 lines

post/tests.c struct post_test post_list[] = · line 302

Quoted 5 lines

post/tests.c +4 -0

+	NULL,
+	CONFIG_SYS_POST_COPROC
+    }
+#endif
 };

I don't want to see board specific code (pdm360ng_*) in such a global file. Please use a more generic approach.

Do you mean like for example CONFIG_POST_BSPEC1 used for lwmon5?

Anatolij, this should be straight forward.

...

Quoted 22 lines

post/tests.c +9 -0

@@ -53,6 +53,7 @@ extern int gdc_post_test (int flags);
 extern int fpga_post_test (int flags);
 extern int lwmon5_watchdog_post_test(int flags);
 extern int sysmon1_post_test(int flags);
+extern int pdm360ng_coprocessor_post_test(int flags);
 
 extern int sysmon_init_f (void);
 

@@ -286,6 +287,18 @@ struct post_test post_list[] =
 #if CONFIG_POST & CONFIG_SYS_POST_BSPEC5
 	CONFIG_POST_BSPEC5,
 #endif
+#if CONFIG_POST & CONFIG_SYS_POST_COPROC
+    {
+	"Coprocessors communication test",
+	"coproc_com",
+	"This test checks communication with coprocessors.",
+	POST_RAM | POST_ALWAYS | POST_CRITICAL,
+	&pdm360ng_coprocessor_post_test,
+	NULL,

post/tests.c struct post_test post_list[] = · line 302

Quoted 5 lines

post/tests.c +4 -0

+	NULL,
+	CONFIG_SYS_POST_COPROC
+    }
+#endif
 };

I don't want to see board specific code (pdm360ng_*) in such a global file. Please use a more generic approach.

What would be a preferred way to realize this? Defining a weak function in post/post.c or post/tests.c which could be over-ridden by board specific one? Like:

Then I have to put board specific post code in board/pdm360ng/post.c to the pdm360ng.c file back. Otherwise the board's coprocessor_post_test() function is not linked if there is no other code in this post.c file which is strongly-linked.

PDM360NG is a MPC5121E based board by ifm ecomatic gmbh.

- don't use DDR RAM size config macro, get_ram_size() is used now in fixed_sdram() to determine RAM size (see previous patch 1/3)

Quoted 1 line · In message <[email protected]> you wrote:

PDM360NG is a MPC5121E based board by ifm ecomatic gmbh.

...

Quoted 3 lines

- don't use DDR RAM size config macro, get_ram_size() is used now in fixed_sdram() to determine RAM size (see previous patch 1/3)

With this change, can we then not also get rid of manually defining CONFIG_PDM360NG_BIG ? We should be able to auto-detect the configuration from the actual RAM size now, right?

Quoted 3 lines

With this change, can we then not also get rid of manually defining CONFIG_PDM360NG_BIG ? We should be able to auto-detect the configuration from the actual RAM size now, right?

But another configuration for 128 MB uses different values for DDR System Configuration Register and DDR Time Config[0-2] Registers. We still need this config option.

Quoted 4 lines

With this change, can we then not also get rid of manually defining CONFIG_PDM360NG_BIG ? We should be able to auto-detect the configuration from the actual RAM size now, right?

But another configuration for 128 MB uses different values for DDR System Configuration Register and DDR Time Config[0-2] Registers. We still need this config option.

Configure 1GiB address range in DDR LAW and
determine the RAM size. Fix DDR LAW afterwards.

Quoted 2 lines · In message <[email protected]> you wrote:

Configure 1GiB address range in DDR LAW and
determine the RAM size. Fix DDR LAW afterwards.

Why 1 GiB? Where is this linit coming from? It seems pretty artificial to me?

arch/ppc/cpu/mpc512x/fixed_sdram.c long int fixed_sdram(ddr512x_config_t *mddrc_config, · line 81

Quoted 2 lines

arch/ppc/cpu/mpc512x/fixed_sdram.c +1 -1

-	u32 msize = CONFIG_SYS_DDR_SIZE * 1024 * 1024;
+	u32 msize = 1024 * 1024 * 1024;

I'd rather see a (#define'd) constant used here, espeaically as the vlue is used again furhter doewn in the code...

Quoted 6 lines

arch/ppc/cpu/mpc512x/fixed_sdram.c +0 -0

 	u32 i;

@@ -148,5 +148,10 @@ long int fixed_sdram(ddr512x_config_t *mddrc_config,
 	out_be32(&im->mddrc.ddr_time_config0, mddrc_config->ddr_time_config0);
 	out_be32(&im->mddrc.ddr_sys_config, mddrc_config->ddr_sys_config);
 

arch/ppc/cpu/mpc512x/fixed_sdram.c long int fixed_sdram(ddr512x_config_t *mddrc_config, · line 151

Quoted 1 line

arch/ppc/cpu/mpc512x/fixed_sdram.c +1 -0

+	msize = get_ram_size(CONFIG_SYS_DDR_BASE, 0x40000000);

... i. e. here. Using two different notations for the same number makes the code even hearder to read and understand.

I suggest we use CONFIG_SYS_MAX_RAM_SIZE like we do in so many other boards, and leave it to the board maintainer to set a usefule default value.

Add common post_word_load/post_word_store routines for all mpc5121 boards. pdm360ng board support added by subsequent patches needs these, as it adds a board specific POST test.

Signed-off-by Anatolij Gustschin <[email protected]>

---
This patch is new in this series. This code was in board support file in v1 patch series. Now it is common for mpc512x boards.

 cpu/mpc512x/Makefile   |    1 +
 cpu/mpc512x/commproc.c |   25 +++++++++++++++++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 cpu/mpc512x/commproc.c

Allow overriding defined partitions in the device tree blob using partition info defined in the 'mtdparts' environment variable.

Signed-off-by Anatolij Gustschin <[email protected]>

Cc Gerald Van Baren <[email protected]>

---
Changes since first version:
- in fdt_fixup_mtdparts() check the presence of "mtdparts" environment variable and don't proceed with initialisation if the variable is not defined (suppresses warning while booting).

 common/cmd_mtdparts.c       |    2 +-
 common/fdt_support.c        |  219 +++++++++++++++++++++++++++++++++++++++++++
 include/fdt_support.h       |    2 +
 include/jffs2/load_kernel.h |    1 +
 include/mtd_node.h          |   11 ++
 5 files changed, 234 insertions(+), 1 deletions(-)
 create mode 100644 include/mtd_node.h

Signed-off-by Anatolij Gustschin <[email protected]>

---
No changes since v1.

 cpu/mpc512x/serial.c |   87 ++++++++++++++++++++++++++++++++++++++++++++++++++
 include/serial.h     |    7 ++++
 2 files changed, 94 insertions(+), 0 deletions(-)

Extend mpc512x serial driver to support multiple PSC ports.

Supsequent patches for PDM360NG board support make use of this functionality by defining CONFIG_SERIAL_MULTI in the board config file. Additionally the used PSC devices are specified by defining e.g. CONFIG_SYS_PSC1, CONFIG_SYS_PSC4 and CONFIG_SYS_PSC6.

Support for PSC devices other than 1, 3, 4 and 6 is not added by this patch because these aren't used currently. In the future it can be easily added using DECLARE_PSC_SERIAL_FUNCTIONS(N) and INIT_PSC_SERIAL_STRUCTURE(N) macros in cpu/mpc512x/serial.c. Additionally you have to add code for registering added devices in serial_initialise() in common/serial.c.

Signed-off-by Anatolij Gustschin <[email protected]>

---
No changes since v1.

 common/serial.c              |   23 ++++
 cpu/mpc512x/serial.c         |  266 +++++++++++++++++++++++++++++++++++++-----
 include/asm-ppc/immap_512x.h |  108 +++++++++---------
 include/serial.h             |    8 ++
 4 files changed, 324 insertions(+), 81 deletions(-)

Signed-off-by Anatolij Gustschin <[email protected]>

---
No changes since v1.

 cpu/mpc512x/fixed_sdram.c    |    2 +-
 include/asm-ppc/immap_512x.h |    4 ----
 include/configs/aria.h       |    2 ++
 include/configs/mecp5123.h   |    2 ++
 include/configs/mpc5121ads.h |    2 ++
 5 files changed, 7 insertions(+), 5 deletions(-)

This patch series intend to support MPC5121e based PDM360NG board. Patches preceding the actual board support patch 6 prepare needed infrastructure for the PDM360NG board.