Skip to contentSkip to conversation

netpoll: warn when there are spaces in parameters

PATCH Applied Amerigo Wang 4 participants 9 messages Mar 22, 2010 – Mar 23, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 netpoll: warn when there are spaces in parameters

v2: update according to Frans' comments.

Currently, if we leave spaces before dst port, netconsole will silently accept it as 0. Warn about this.

Also, when spaces appear in other places, make them visible in error messages.

Cc David Miller <[email protected]>

---

net/core/netpoll.c +5 -2
index 7aa6972..6df1863 100644
@@ -614,7 +614,7 @@ void netpoll_print_options(struct netpoll *np)
 			 np->name, np->local_port);
 	printk(KERN_INFO "%s: local IP %pI4\n",
 			 np->name, &np->local_ip);
-	printk(KERN_INFO "%s: interface %s\n",
+	printk(KERN_INFO "%s: interface '%s'\n",
 			 np->name, np->dev_name);
 	printk(KERN_INFO "%s: remote port %d\n",
 			 np->name, np->remote_port);
@@ -661,6 +661,9 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
 		if ((delim = strchr(cur, '@')) == NULL)
 			goto parse_failed;
 		*delim = 0;
+		if (*cur == ' ' || *cur == '\t')
+			printk(KERN_INFO "%s: warning: whitespace"
+					"is not allowed\n", np->name);
 		np->remote_port = simple_strtol(cur, NULL, 10);
 		cur = delim;
 	}
@@ -708,7 +711,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
 	return 0;
 
  parse_failed:
-	printk(KERN_INFO "%s: couldn't parse config at %s!\n",
+	printk(KERN_INFO "%s: couldn't parse config at '%s'!\n",
 	       np->name, cur);
 	return -1;
 }
Acked-by on v2 1/1
#1 lore raw
Quoted 37 lines · Amerigo Wang

v2: update according to Frans' comments.

Currently, if we leave spaces before dst port, netconsole will silently accept it as 0. Warn about this.

Also, when spaces appear in other places, make them visible in error messages.

Cc David Miller <[email protected]>

---

net/core/netpoll.c +4 -1
index 7aa6972..6df1863 100644
@@ -614,7 +614,7 @@ void netpoll_print_options(struct netpoll *np)
 			 np->name, np->local_port);
 	printk(KERN_INFO "%s: local IP %pI4\n",
 			 np->name, &np->local_ip);
-	printk(KERN_INFO "%s: interface %s\n",
+	printk(KERN_INFO "%s: interface '%s'\n",
 			 np->name, np->dev_name);
 	printk(KERN_INFO "%s: remote port %d\n",
 			 np->name, np->remote_port);
@@ -661,6 +661,9 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
 		if ((delim = strchr(cur, '@')) == NULL)
 			goto parse_failed;
 		*delim = 0;
+		if (*cur == ' ' || *cur == '\t')
+			printk(KERN_INFO "%s: warning: whitespace"
+					"is not allowed\n", np->name);
 		np->remote_port = simple_strtol(cur, NULL, 10);
 		cur = delim;
 	}

net/core/netpoll.c int netpoll_parse_options(struct netpoll *np, char *opt) · line 717

Quoted 8 lines
net/core/netpoll.c +1 -1
@@ -708,7 +711,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
 	return 0;
 
  parse_failed:
-	printk(KERN_INFO "%s: couldn't parse config at %s!\n",
+	printk(KERN_INFO "%s: couldn't parse config at '%s'!\n",
 	       np->name, cur);
 	return -1;
 }
Quoted 6 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

maintainer Applied
#2 lore raw

From: Neil Horman <[email protected]>
Date: Mon, 22 Mar 2010 08:30:46 -0400

Quoted 10 lines · Amerigo Wang
Quoted 9 lines

v2: update according to Frans' comments.

Currently, if we leave spaces before dst port, netconsole will silently accept it as 0. Warn about this.

Also, when spaces appear in other places, make them visible in error messages.

...

Quoted 1 line

Applied, thanks!

#3 lore raw
In reply to Amerigo Wang

net/core/netpoll.c int netpoll_parse_options(struct netpoll *np, char *opt) · line 666

Quoted 2 lines · Amerigo Wang
net/core/netpoll.c +2 -0
+			printk(KERN_INFO "%s: warning: whitespace"
+					"is not allowed\n", np->name);

Is it a warning or is it info? If it's a warning, then we probably need to add "netpoll" or whatever to the message so that people who've got a warning-level threshold will know what it's about.

Signature · 1 line
http://selenic.com : development and support for Mercurial and Linux
author
#4 lore raw
Quoted 8 lines · Matt Mackall

net/core/netpoll.c int netpoll_parse_options(struct netpoll *np, char *opt) · line 666

Quoted 2 lines · Amerigo Wang
net/core/netpoll.c +2 -0
+			printk(KERN_INFO "%s: warning: whitespace"
+					"is not allowed\n", np->name);

Is it a warning or is it info? If it's a warning, then we probably need to add "netpoll" or whatever to the message so that people who've got a warning-level threshold will know what it's about.

If you mean KERN_INFO, yeah, I want to keep it in the same level as other messages around.

Also, I already put "np->name" which will be "netconsole" when we use netconsole.

Thanks.

#5 lore raw
Quoted 10 lines · Cong Wang
Quoted 8 lines · Matt Mackall

net/core/netpoll.c int netpoll_parse_options(struct netpoll *np, char *opt) · line 666

Quoted 2 lines · Amerigo Wang
net/core/netpoll.c +2 -0
+			printk(KERN_INFO "%s: warning: whitespace"
+					"is not allowed\n", np->name);

Is it a warning or is it info? If it's a warning, then we probably need to add "netpoll" or whatever to the message so that people who've got a warning-level threshold will know what it's about.

Quoted 2 lines

If you mean KERN_INFO, yeah, I want to keep it in the same level as other messages around.

I should probably be more direct: I think that's the wrong thing to do. It IS a warning (it even says so!) telling users that something probably won't work and why and they might miss it if the severity is INFO and then come and ask us why things aren't working. So use KERN_WARN, please.

The other messages are INFO because when things are working, they're not interesting.

Quoted 2 lines

Also, I already put "np->name" which will be "netconsole" when we use netconsole.

Ahh, right, I have a brain cell somewhere that knew that.

Signature · 1 line
http://selenic.com : development and support for Mercurial and Linux
author
#6 lore raw
Quoted 9 lines · Matt Mackall
Quoted 8 lines · Cong Wang
Quoted 7 lines · Matt Mackall

net/core/netpoll.c int netpoll_parse_options(struct netpoll *np, char *opt) · line 666

Quoted 2 lines · Amerigo Wang
net/core/netpoll.c +2 -0
+			printk(KERN_INFO "%s: warning: whitespace"
+					"is not allowed\n", np->name);

Is it a warning or is it info? If it's a warning, then we probably need to add "netpoll" or whatever to the message so that people who've got a warning-level threshold will know what it's about.

Quoted 8 lines
Quoted 2 lines

If you mean KERN_INFO, yeah, I want to keep it in the same level as other messages around.

I should probably be more direct: I think that's the wrong thing to do. It IS a warning (it even says so!) telling users that something probably won't work and why and they might miss it if the severity is INFO and then come and ask us why things aren't working. So use KERN_WARN, please.

They _are_ working, 0 will be assigned by default.

Quoted 4 lines

The other messages are INFO because when things are working, they're not interesting.

They are not all working, take this as an example:

printk(KERN_INFO "%s: couldn't parse config at %s!\n",
np->name, cur);

#7 lore raw
Quoted 13 lines · Cong Wang
Quoted 12 lines · Matt Mackall
Quoted 10 lines · Cong Wang
Quoted 7 lines · Matt Mackall

net/core/netpoll.c int netpoll_parse_options(struct netpoll *np, char *opt) · line 666

Quoted 2 lines · Amerigo Wang
net/core/netpoll.c +2 -0
+			printk(KERN_INFO "%s: warning: whitespace"
+					"is not allowed\n", np->name);

Is it a warning or is it info? If it's a warning, then we probably need to add "netpoll" or whatever to the message so that people who've got a warning-level threshold will know what it's about.

If you mean KERN_INFO, yeah, I want to keep it in the same level as other messages around.

Quoted 8 lines
Quoted 5 lines

I should probably be more direct: I think that's the wrong thing to do. It IS a warning (it even says so!) telling users that something probably won't work and why and they might miss it if the severity is INFO and then come and ask us why things aren't working. So use KERN_WARN, please.

They _are_ working, 0 will be assigned by default.

If this patch has any point at all other than filling the logs, it should be WARN.

Quoted 9 lines
Quoted 4 lines

The other messages are INFO because when things are working, they're not interesting.

They are not all working, take this as an example:

printk(KERN_INFO "%s: couldn't parse config at %s!\n",
np->name, cur);

Yeah, that's obviously wrong too. Let's not add more wrongness just for consistency's sake.

Signature · 1 line
http://selenic.com : development and support for Mercurial and Linux
author
#8 lore raw
Quoted 19 lines · Matt Mackall
Quoted 18 lines · Cong Wang
Quoted 16 lines · Matt Mackall
Quoted 10 lines · Cong Wang
Quoted 7 lines · Matt Mackall

net/core/netpoll.c int netpoll_parse_options(struct netpoll *np, char *opt) · line 666

Quoted 2 lines · Amerigo Wang
net/core/netpoll.c +2 -0
+			printk(KERN_INFO "%s: warning: whitespace"
+					"is not allowed\n", np->name);

Is it a warning or is it info? If it's a warning, then we probably need to add "netpoll" or whatever to the message so that people who've got a warning-level threshold will know what it's about.

If you mean KERN_INFO, yeah, I want to keep it in the same level as other messages around.

I should probably be more direct: I think that's the wrong thing to do. It IS a warning (it even says so!) telling users that something probably won't work and why and they might miss it if the severity is INFO and then come and ask us why things aren't working. So use KERN_WARN, please.

Quoted 4 lines
Quoted 1 line

They _are_ working, 0 will be assigned by default.

If this patch has any point at all other than filling the logs, it should be WARN.

Others too.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

The other messages are INFO because when things are working, they're not interesting.

Quoted 8 lines
Quoted 4 lines

They are not all working, take this as an example:

printk(KERN_INFO "%s: couldn't parse config at %s!\n",
np->name, cur);

Yeah, that's obviously wrong too. Let's not add more wrongness just for consistency's sake.

Since you insist, please send a patch for all of these messages in netpoll. This patch, from $subject, is aimed to warn spaces.

Thanks.