memcg_function tests failing on s390

LTP Srinivasa R Chamarthy 2 participants 2 messages Mar 22, 2010

Share & tools

Srinivasa R Chamarthy

author

2010-03-22 09:13 UTC #0 lore raw

Hi LTP,

The memcg_function tests were failing in s390 as the condition for checking support for memory controller is not getting satisfied. Eventhough the cgroup memory is enabled, the script comes out saying that the memory support is not available in the kernel.

This patch changes the condition checking for memory cgroup support in kernel in the script memcg_function_test.sh.

Signature · 5 lines

Srinivasa R Chamarthy ([email protected])
Linux on System z (RedHat & Novell SuSE) CSVT,
IBM India Systems & Technology Group/LTC - ISL,
Bangalore - 560071, KA, INDIA. Off: +91-80-41776451 
[ http://www.ibm.com/in/isl | http://www.ibm.com/linux/ltc ]

memcg_function_test.sh 2010-03-22 09:52:52.000000000 +0100 renamed from memcg_function_test_old.sh 2010-03-22 09:50:56.000000000 +0100 +1 -1

diff -Naurp memcg_function_test_old.sh memcg_function_test.sh
@@ -30,7 +30,7 @@ export TCID="memcg_function_test"
 export TST_TOTAL=38
 export TST_COUNT=0
 
-if [ ! "grep -w memory /proc/cgroups | cut -f4" == "1" ]
+if [ "$(grep -w memory /proc/cgroups | cut -f4)" != "1" ]
 then
         echo "WARNING:";
         echo "Either Kernel does not support for memory resource controller or feature not enabled";

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

2010-03-22 09:57 UTC #1 lore raw

Quoted 9 lines · Srinivasa R Chamarthy

Hi LTP,
The memcg_function tests were failing in s390 as the condition for checking support for memory controller is not getting satisfied. Eventhough the cgroup memory is enabled, the script comes out saying that the memory support is not available in the kernel.
This patch changes the condition checking for memory cgroup support in kernel in the script memcg_function_test.sh.

Already fixed on HEAD.
Thanks,
-Garrett