cx23885: strcpy() => strlcpy()

PATCH New Dan Carpenter 1 participant 1 message Mar 22, 2010 Media (V4L/DVB)

Share & tools

Dan Carpenter

author

2010-03-22 12:08 UTC #0 lore raw

PATCH 1/1 cx23885: strcpy() => strlcpy()

cap->driver is a 16 char buffer and dev->name is a 32 char buffer. I don't see an actual problem, but we may as well make the static checkers happy.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/video/cx23885/cx23885-417.c +1 -1

index 2ab97ad..6fff89d 100644
@@ -1355,7 +1355,7 @@ static int vidioc_querycap(struct file *file, void  *priv,
 	struct cx23885_dev *dev = fh->dev;
 	struct cx23885_tsport  *tsport = &dev->ts1;
 
-	strcpy(cap->driver, dev->name);
+	strlcpy(cap->driver, dev->name, sizeof(cap->driver));
 	strlcpy(cap->card, cx23885_boards[tsport->dev->board].name,
 		sizeof(cap->card));
 	sprintf(cap->bus_info, "PCI:%s", pci_name(dev->pci));