Skip to contentSkip to conversation

ksz884x: fix return value of netdev_set_eeprom

PATCH Applied Jens Rottmann 2 participants 2 messages Mar 23, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ksz884x: fix return value of netdev_set_eeprom

ksz884x: fix return value of netdev_set_eeprom

netdev_set_eeprom() confused ethtool by just returning 1 on error instead of a proper -EINVAL.

---

drivers/net/ksz884x.c +1 -1
@@ -6322,7 +6322,7 @@ static int netdev_set_eeprom(struct net_
 	int len;
 
 	if (eeprom->magic != EEPROM_MAGIC)
-		return 1;
+		return -EINVAL;
 
 	len = (eeprom->offset + eeprom->len + 1) / 2;
 	for (i = eeprom->offset / 2; i < len; i++)

_

maintainer Applied
#1 lore raw

From: Jens Rottmann <[email protected]>
Date: Tue, 23 Mar 2010 15:23:50 +0100

Quoted 6 lines

ksz884x: fix return value of netdev_set_eeprom

netdev_set_eeprom() confused ethtool by just returning 1 on error instead of a proper -EINVAL.

Applied, thank you.