Skip to contentSkip to conversation

FDPIC: For-loop in elf_core_vma_data_size() is incorrect

PATCH New David Howells 1 participant 1 message Mar 24, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 FDPIC: For-loop in elf_core_vma_data_size() is incorrect

Fix an incorrect for-loop in elf_core_vma_data_size(). The advance-pointer statement lacks an assignment:

CC fs/binfmt_elf_fdpic.o
fs/binfmt_elf_fdpic.c: In function 'elf_core_vma_data_size':
fs/binfmt_elf_fdpic.c:1593: warning: statement with no effect

---

 fs/binfmt_elf_fdpic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/binfmt_elf_fdpic.c +1 -1
index 2c32d00..7ab23e0 100644
@@ -1590,7 +1590,7 @@ static size_t elf_core_vma_data_size(unsigned long mm_flags)
 	struct vm_area_struct *vma;
 	size_t size = 0;
 
-	for (vma = current->mm->mmap; vma; vma->vm_next)
+	for (vma = current->mm->mmap; vma; vma = vma->vm_next)
 		if (maydump(vma, mm_flags))
 			size += vma->vm_end - vma->vm_start;
 	return size;