Skip to contentSkip to conversation

nuc900fb: release correct mem region

PATCH In review Dan Carpenter 3 participants 4 messages Mar 25, 2010 – May 21, 2010

Subsystems (2)
Kernel janitors Framebuffer layer
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 nuc900fb: release correct mem region

We should be releasing "res->start" here.

Signed-off-by Dan Carpenter <[email protected]>

---
BTW. Congratulations on being an official driver maintainer now. :) Can you add yourself to the MAINTAINERS file?

drivers/video/nuc900fb.c +1 -1
index 6bf0d46..d4cde79 100644
@@ -667,7 +667,7 @@ release_irq:
 release_regs:
 	iounmap(fbi->io);
 release_mem_region:
-	release_mem_region((unsigned long)fbi->mem, size);
+	release_mem_region(res->start, size);
 free_fb:
 	framebuffer_release(fbinfo);
 	return ret;
author
#1 lore raw

Ping. Any feedback on this patch?

regards,
dan carpenter

Quoted 20 lines · Dan Carpenter

We should be releasing "res->start" here.

Signed-off-by Dan Carpenter <[email protected]>

---
BTW. Congratulations on being an official driver maintainer now. :) Can you add yourself to the MAINTAINERS file?

drivers/video/nuc900fb.c +1 -1
index 6bf0d46..d4cde79 100644
@@ -667,7 +667,7 @@ release_irq:
 release_regs:
 	iounmap(fbi->io);
 release_mem_region:
-	release_mem_region((unsigned long)fbi->mem, size);
+	release_mem_region(res->start, size);
 free_fb:
 	framebuffer_release(fbinfo);
 	return ret;
Acked-by
#2 lore raw

Hi Dan,

Qiang brother have a busy doing business, so I can maintain the nuc900fb driver instead.
It looks good to me.

Andrew , Could you help merge this patch? thanks a lot!

Acked-by Wan ZongShun<[email protected]>

2010/5/20 Dan Carpenter <[email protected]>:

Quoted 27 lines

Ping.  Any feedback on this patch?

regards,
dan carpenter

Quoted 20 lines · Dan Carpenter

We should be releasing "res->start" here.

Signed-off-by Dan Carpenter <[email protected]>

---
BTW.  Congratulations on being an official driver maintainer now.  :)  Can you add yourself to the MAINTAINERS file?

drivers/video/nuc900fb.c +0 -0
index 6bf0d46..d4cde79 100644
@@ -667,7 +667,7 @@ release_irq:

 release_regs:
      iounmap(fbi->io);
 release_mem_region:
-     release_mem_region((unsigned long)fbi->mem, size);
+     release_mem_region(res->start, size); free_fb:
      framebuffer_release(fbinfo);
      return ret;

Signature · 10 lines
*linux-arm-kernel mailing list
mail addr:[email protected]
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:[email protected]
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
[email protected]
#3 lore raw
Quoted 4 lines · On Thu, 20 May 2010 10:36:59 +0800 Wan ZongShun <[email protected]> wrote:

Hi Dan,

Qiang brother have a busy doing business, so I can maintain the nuc900fb driver instead.

Feel free to send an update to the MAINTAINERS file.

Quoted 35 lines

It looks good to me.

Andrew , Could you help merge this patch? thanks a lot!

Acked-by Wan ZongShun<[email protected]>

2010/5/20 Dan Carpenter <[email protected]>:

Quoted 27 lines

Ping. __Any feedback on this patch?

regards,
dan carpenter

Quoted 20 lines · Dan Carpenter

We should be releasing "res->start" here.

Signed-off-by Dan Carpenter <[email protected]>

---
BTW. __Congratulations on being an official driver maintainer now. __:) __Can you add yourself to the MAINTAINERS file?

drivers/video/nuc900fb.c +0 -0
index 6bf0d46..d4cde79 100644
@@ -667,7 +667,7 @@ release_irq:

__release_regs:
__ __ __ iounmap(fbi->io);
__release_mem_region:
- __ __ release_mem_region((unsigned long)fbi->mem, size);
+ __ __ release_mem_region(res->start, size); __free_fb:
__ __ __ framebuffer_release(fbinfo);
__ __ __ return ret;

I don't think I ever received a copy of this patch. I reconstructed it.