Skip to contentSkip to conversation

benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c

PATCH In review [email protected] 3 participants 3 messages Mar 26, 2010 – Mar 27, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c

Fix the following warnings:

be_ethtool.c:493: warning: integer constant is too large for 'long' type be_ethtool.c:493: warning: integer constant is too large for 'long' type

---
 drivers/net/benet/be_ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/benet/be_ethtool.c +1 -1
index 9560d48..51e1065 100644
@@ -490,7 +490,7 @@ be_test_ddr_dma(struct be_adapter *adapter)
 {
 	int ret, i;
 	struct be_dma_mem ddrdma_cmd;
-	u64 pattern[2] = {0x5a5a5a5a5a5a5a5a, 0xa5a5a5a5a5a5a5a5};
+	u64 pattern[2] = {0x5a5a5a5a5a5a5a5aULL, 0xa5a5a5a5a5a5a5a5ULL};
 
 	ddrdma_cmd.size = sizeof(struct be_cmd_req_ddrdma_test);
 	ddrdma_cmd.va = pci_alloc_consistent(adapter->pdev, ddrdma_cmd.size,
Signature · 1 line
1.6.5.3
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · On 26/03/10 14:12 +0800, [email protected] wrote:

Fix the following warnings:

be_ethtool.c:493: warning: integer constant is too large for 'long' type be_ethtool.c:493: warning: integer constant is too large for 'long' type

I would suggest using be2net instead of benet during the commit.
be2net: Fix compile warnnings in drivers/net/benet/be_ethtool.c

maintainer
#2 lore raw

From: Ajit Khaparde <[email protected]>
Date: Fri, 26 Mar 2010 22:46:18 +0530

Quoted 6 lines · On 26/03/10 14:12 +0800, [email protected] wrote:
Quoted 5 lines

Fix the following warnings:

be_ethtool.c:493: warning: integer constant is too large for 'long' type be_ethtool.c:493: warning: integer constant is too large for 'long' type

Quoted 6 lines
Quoted 1 line

I would suggest using be2net instead of benet during the commit.
be2net: Fix compile warnnings in drivers/net/benet/be_ethtool.c

Well, you cannot be surprised that people will use "benet" since that is the name of the directory the driver lives under. It is not even referred to as "be2net" in the MAINTAINERS entry.

I'm applying this fix as-is.