Skip to contentSkip to conversation

multipath: don't let init script stop multipathd for root devices

PATCH In review Benjamin Marzinski 2 participants 6 messages Mar 25, 2010 – Apr 2, 2010 Device mapper

lore
Share & tools
lore

Benjamin Marzinski

author maintainer
#0 lore raw

PATCH 1/1 multipath: don't let init script stop multipathd for root devices

This patch modifies the redhat init script, so that it doesn't allow multipathd to be stopped when the root device is on it.

---
:100644 100644 ee776f0... e46b1b8... M multipathd/multipathd.init.redhat

 multipathd/multipathd.init.redhat |   38 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)
multipathd/multipathd.init.redhat +37 -1
Index: multipath-tools-100322/multipathd/multipathd.init.redhat
===================================================================
@@ -2,7 +2,7 @@
 #
 # multipathd	Starts the multipath daemon
 #
-# chkconfig: - 13 87
+# chkconfig: - 06 87
 # description: Manages device-mapper multipath devices
 
 ### BEGIN INIT INFO
@@ -17,6 +17,7 @@ prog=`basename $DAEMON`
 initdir=/etc/rc.d/init.d
 lockdir=/var/lock/subsys
 sysconfig=/etc/sysconfig
+syspath=/sys/block
 
  
 . $initdir/functions
@@ -25,6 +26,36 @@ test -r $sysconfig/$prog && . $sysconfig
 
 RETVAL=0
 
+teardown_slaves()
+{
+pushd $1 > /dev/null
+if [ -d "slaves" ]; then
+for slave in slaves/*;
+do
+	if [ "$slave" = "slaves/*" ]; then
+		read dev <  $1/dev
+		tablename=`dmsetup table --target multipath | sed -n "s/\(.*\): .* $dev .*/\1/p"`
+		if ! [ -z $tablename ]; then
+			echo "Root is on a multipathed device, multipathd can not be stopped"
+			exit 1
+		fi
+	else
+		local_slave=`readlink -f $slave`;
+		teardown_slaves $local_slave;
+	fi
+	done
+
+else
+		read dev <  $1/dev
+		tablename=`dmsetup table --target multipath | sed -n "s/\(.*\): .* $dev .*/\1/p"`
+		if ! [ -z $tablename ]; then
+			echo "Root is on a multipathed device, multipathd can not be stopped"
+			exit 1
+		fi
+fi
+popd > /dev/null
+}
+
 #
 # See how we were called.
 #
@@ -39,6 +70,11 @@ start() {
 }
 
 stop() {
+        root_dev=$(awk '{ if ($1 !~ /^[ \t]*#/ && $2 == "/") { print $1; }}' /etc/mtab)
+	dm_num=`dmsetup info -c --noheadings -o minor $root_dev`
+	root_dm_device="dm-$dm_num"
+	[ -d $syspath/$root_dm_device ] && teardown_slaves $syspath/$root_dm_device
+
 	echo -n $"Stopping $prog daemon: "
 	killproc $DAEMON
 	RETVAL=$?
#1 lore raw

Hi Ben,

Quoted 2 lines · Benjamin Marzinski

This patch modifies the redhat init script, so that it doesn't allow multipathd to be stopped when the root device is on it.

Why do you need to prevent stopping daemon by script-level forcibly? I think that users/developers may want to restart the daemon at their own risk when it starts to behave something wrong or they change a configuration (since "reconfigure" may not be stable feature).

# Maybe others have different opinion but I often use "restart".

If you need this patch anyway, please add other options to stop/restart the daemon forcibly. (e.g. adding force-stop/force-restart)

Thanks,
Kiyoshi Ueda

author maintainer
#2 lore raw
Quoted 11 lines · Kiyoshi Ueda

Hi Ben,

Quoted 2 lines · Benjamin Marzinski

This patch modifies the redhat init script, so that it doesn't allow multipathd to be stopped when the root device is on it.

Why do you need to prevent stopping daemon by script-level forcibly? I think that users/developers may want to restart the daemon at their own risk when it starts to behave something wrong or they change a configuration (since "reconfigure" may not be stable feature).

Quoted 4 lines

# Maybe others have different opinion but I often use "restart".

If you need this patch anyway, please add other options to stop/restart the daemon forcibly. (e.g. adding force-stop/force-restart)

I can certainly add a force-stop/force-restart. This can currently be accomplished by simply killing the daemon, but admittedly doing it through the init script is cleaner and more obvious to users, and it's necessary to allow package upgrades to immediately start using multipathd on systems with multipathed root disks.

However, what is there that you need to restart the daemon for that

# service multipathd reload

won't fix, besides upgrading the package. If there is something, then we should fix it. I only stop the daemon when I'm testing shutting down, and upgrading source. Otherwise, I've been using reconfigure without problems.

-Ben

Quoted 3 lines

Thanks,
Kiyoshi Ueda

#3 lore raw

Hi Ben,

Quoted 22 lines · Benjamin Marzinski
Quoted 10 lines · Kiyoshi Ueda

Hi Ben,

Quoted 2 lines · Benjamin Marzinski

This patch modifies the redhat init script, so that it doesn't allow multipathd to be stopped when the root device is on it.

Why do you need to prevent stopping daemon by script-level forcibly? I think that users/developers may want to restart the daemon at their own risk when it starts to behave something wrong or they change a configuration (since "reconfigure" may not be stable feature).

Quoted 4 lines

# Maybe others have different opinion but I often use "restart".

If you need this patch anyway, please add other options to stop/restart the daemon forcibly. (e.g. adding force-stop/force-restart)

I can certainly add a force-stop/force-restart. This can currently be accomplished by simply killing the daemon, but admittedly doing it through the init script is cleaner and more obvious to users, and it's necessary to allow package upgrades to immediately start using multipathd on systems with multipathed root disks.

Quoted 8 lines

However, what is there that you need to restart the daemon for that

# service multipathd reload

won't fix, besides upgrading the package. If there is something, then we should fix it. I only stop the daemon when I'm testing shutting down, and upgrading source. Otherwise, I've been using reconfigure without problems.

I may be confusing you.
I know/understand that current reconfigure works well and if it doesn't work we should fix it.

My point is that "why do you need to prevent stopping daemon by script-level forcibly?".
As you mentioned above, killing the daemon through the init script is cleaner and more obvious. So I think leaving something to stop the daemon in the init script is more friendly for admins.

Thanks,
Kiyoshi Ueda

author maintainer
#4 lore raw
Quoted 38 lines · Kiyoshi Ueda

Hi Ben,

Quoted 22 lines · Benjamin Marzinski
Quoted 10 lines · Kiyoshi Ueda

Hi Ben,

Quoted 2 lines · Benjamin Marzinski

This patch modifies the redhat init script, so that it doesn't allow multipathd to be stopped when the root device is on it.

Why do you need to prevent stopping daemon by script-level forcibly? I think that users/developers may want to restart the daemon at their own risk when it starts to behave something wrong or they change a configuration (since "reconfigure" may not be stable feature).

Quoted 4 lines

# Maybe others have different opinion but I often use "restart".

If you need this patch anyway, please add other options to stop/restart the daemon forcibly. (e.g. adding force-stop/force-restart)

I can certainly add a force-stop/force-restart. This can currently be accomplished by simply killing the daemon, but admittedly doing it through the init script is cleaner and more obvious to users, and it's necessary to allow package upgrades to immediately start using multipathd on systems with multipathed root disks.

Quoted 8 lines

However, what is there that you need to restart the daemon for that

# service multipathd reload

won't fix, besides upgrading the package. If there is something, then we should fix it. I only stop the daemon when I'm testing shutting down, and upgrading source. Otherwise, I've been using reconfigure without problems.

I may be confusing you.
I know/understand that current reconfigure works well and if it doesn't work we should fix it.

Quoted 5 lines

My point is that "why do you need to prevent stopping daemon by script-level forcibly?".
As you mentioned above, killing the daemon through the init script is cleaner and more obvious. So I think leaving something to stop the daemon in the init script is more friendly for admins.

The script only blocks stopping multipathd if the root device is multipathed, since you won't be able to restart it if you lose all the paths to your root device, ever for a short while.

Admittedly, if you are able to run the script, you most likely currently have access to your root device, and running something like

# service multipathd restart

is likely (but not certain) to be safe.

This obviously isn't fixing a bug, so if people are against the patch, I'm O.K. with leaving it out.

-Ben

Quoted 3 lines

Thanks,
Kiyoshi Ueda

#5 lore raw

Hi Ben,

Quoted 47 lines · Benjamin Marzinski
Quoted 36 lines · Kiyoshi Ueda

Hi Ben,

Quoted 21 lines · Benjamin Marzinski
Quoted 10 lines · Kiyoshi Ueda

Hi Ben,

Quoted 2 lines · Benjamin Marzinski

This patch modifies the redhat init script, so that it doesn't allow multipathd to be stopped when the root device is on it.

Why do you need to prevent stopping daemon by script-level forcibly? I think that users/developers may want to restart the daemon at their own risk when it starts to behave something wrong or they change a configuration (since "reconfigure" may not be stable feature).

Quoted 4 lines

# Maybe others have different opinion but I often use "restart".

If you need this patch anyway, please add other options to stop/restart the daemon forcibly. (e.g. adding force-stop/force-restart)

I can certainly add a force-stop/force-restart. This can currently be accomplished by simply killing the daemon, but admittedly doing it through the init script is cleaner and more obvious to users, and it's necessary to allow package upgrades to immediately start using multipathd on systems with multipathed root disks.

Quoted 8 lines

However, what is there that you need to restart the daemon for that

# service multipathd reload

won't fix, besides upgrading the package. If there is something, then we should fix it. I only stop the daemon when I'm testing shutting down, and upgrading source. Otherwise, I've been using reconfigure without problems.

I may be confusing you.
I know/understand that current reconfigure works well and if it doesn't work we should fix it.

Quoted 5 lines

My point is that "why do you need to prevent stopping daemon by script-level forcibly?".
As you mentioned above, killing the daemon through the init script is cleaner and more obvious. So I think leaving something to stop the daemon in the init script is more friendly for admins.

The script only blocks stopping multipathd if the root device is multipathed, since you won't be able to restart it if you lose all the paths to your root device, ever for a short while.

Quoted 6 lines

Admittedly, if you are able to run the script, you most likely currently have access to your root device, and running something like

# service multipathd restart

is likely (but not certain) to be safe.

Make sense.

Quoted 2 lines

This obviously isn't fixing a bug, so if people are against the patch, I'm O.K. with leaving it out.

I don't object the patch.
I understand it's useful/friendly for admins not to allow stopping multipathd easily when it can cause critical problems (and Christophe has already commited the patch).

But for more friendness for admins who know it's their own risk, force-stop/restart are good additional options, I think.

Thanks,
Kiyoshi Ueda