Skip to contentSkip to conversation

CONFIG_PROVE_RCU breaks proprietary modules (rcu_lock_map)

DISCUSSION Tilman Schmidt 3 participants 8 messages Mar 21, 2010 – Jun 21, 2010

lore
Share & tools
lore
#0 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I know there's not much sympathy for troubles with proprietary modules here, but the following might save some trouble to kernel developers as well as users forced to resort to proprietary drivers:

Setting the kernel configuration option PROVE_RCU creates a reference to the GPL-exported global variable rcu_lock_map even in modules that do not use RCU. In the case of non-GPL modules, this leads to a build failure because of the license incompatibility.
(I did not find out where that reference comes from.)

So if building a proprietary module fails with the message:

FATAL: modpost: GPL-incompatible module <module> uses GPL-only symbol 'rcu_lock_map'

try rebuilding your kernel with the PROVE_RCU option disabled.

Hope it helps someone.

Tilman
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAkumieoACgkQQ3+did9BuFtC4gCggSE8DNVc8k9tasN7VOoQMR4G IKUAnj+SkzZjmJQPmUScvaY4zP8hR19o
=2rDg
-----END PGP SIGNATURE-----

#1 lore raw
Quoted 13 lines · Tilman Schmidt

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I know there's not much sympathy for troubles with proprietary modules here, but the following might save some trouble to kernel developers as well as users forced to resort to proprietary drivers:

Setting the kernel configuration option PROVE_RCU creates a reference to the GPL-exported global variable rcu_lock_map even in modules that do not use RCU. In the case of non-GPL modules, this leads to a build failure because of the license incompatibility.
(I did not find out where that reference comes from.)

Quoted 8 lines

So if building a proprietary module fails with the message:

FATAL: modpost: GPL-incompatible module <module> uses GPL-only symbol 'rcu_lock_map'

try rebuilding your kernel with the PROVE_RCU option disabled.

Hope it helps someone.

I am comfortable with PROVE_RCU being incompatible with non-GPL modules. After all, it is only a debugging option, not intended for production use.

Thanx, Paul

#2 lore raw

Am 29.03.2010 17:09 schrieb Paul E. McKenney:

Quoted 1 line · Tilman Schmidt

[...]

Quoted 11 lines
Quoted 8 lines

So if building a proprietary module fails with the message:

FATAL: modpost: GPL-incompatible module <module> uses GPL-only symbol 'rcu_lock_map'

try rebuilding your kernel with the PROVE_RCU option disabled.

Hope it helps someone.

I am comfortable with PROVE_RCU being incompatible with non-GPL modules. After all, it is only a debugging option, not intended for production use.

I agree completely. I just wanted to publish that fact because it seems to be little known and can be quite a puzzler.

Thanks,
Tilman

Signature · 4 lines
Tilman Schmidt                    E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
#3 lore raw
Quoted 10 lines · Tilman Schmidt

Am 29.03.2010 17:09 schrieb Paul E. McKenney:

Quoted 1 line · Tilman Schmidt

[...]

Quoted 7 lines
Quoted 7 lines

So if building a proprietary module fails with the message:

FATAL: modpost: GPL-incompatible module <module> uses GPL-only symbol 'rcu_lock_map'

try rebuilding your kernel with the PROVE_RCU option disabled.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Hope it helps someone.

I am comfortable with PROVE_RCU being incompatible with non-GPL modules. After all, it is only a debugging option, not intended for production use.

I agree completely. I just wanted to publish that fact because it seems to be little known and can be quite a puzzler.

And I do very much appreciate your publicizing the solution! ;-)

Thanx, Paul

#4 lore raw
Quoted 8 lines · Paul E. McKenney
Quoted 5 lines
Quoted 2 lines

I am comfortable with PROVE_RCU being incompatible with non-GPL modules. After all, it is only a debugging option, not intended for production use.

I agree completely. I just wanted to publish that fact because it seems to be little known and can be quite a puzzler.

And I do very much appreciate your publicizing the solution! ;-)

Hi Paul,

(Sorry I didn't bring this up until now.)

I don't really have any sympathy for people who use that crud, but from my POV it's going to generate some grief. Fedora builds rawhide with a lot of debugging options enabled in order to try and hit issues early before kernels release.

A few weeks ago, I noticed a report that PROVE_RCU was breaking some non-GPL junk. Digging a bit further, I noticed quite a number of more reports of this.

Is there any chances you could reconsider this? Otherwise I'll probably disable the option in Fedora's debug kernels as well if I continue to see confused users.

--Kyle

#5 lore raw
Quoted 19 lines · Kyle McMartin
Quoted 8 lines · Paul E. McKenney
Quoted 5 lines
Quoted 2 lines

I am comfortable with PROVE_RCU being incompatible with non-GPL modules. After all, it is only a debugging option, not intended for production use.

I agree completely. I just wanted to publish that fact because it seems to be little known and can be quite a puzzler.

And I do very much appreciate your publicizing the solution! ;-)

Hi Paul,

(Sorry I didn't bring this up until now.)

I don't really have any sympathy for people who use that crud, but from my POV it's going to generate some grief. Fedora builds rawhide with a lot of debugging options enabled in order to try and hit issues early before kernels release.

Quoted 7 lines

A few weeks ago, I noticed a report that PROVE_RCU was breaking some non-GPL junk. Digging a bit further, I noticed quite a number of more reports of this.

Is there any chances you could reconsider this? Otherwise I'll probably disable the option in Fedora's debug kernels as well if I continue to see confused users.

Hello, Kyle,

My kneejerk reaction is that PROVE_RCU is a developer tool, so I am OK with it not being set by default in Rawhide. Or have you seen good value from (say) PROVE_LOCKING in Rawhide?

Thanx, Paul

#6 lore raw
Quoted 4 lines · Paul E. McKenney

My kneejerk reaction is that PROVE_RCU is a developer tool, so I am OK with it not being set by default in Rawhide. Or have you seen good value from (say) PROVE_LOCKING in Rawhide?

Hi Paul,

I'm fine with this, we try to enable debug options in rawhide in order to get the most out of bug reports/dmesgs that we can. We've definitely spotted a lot of lockdep reports by having it enabled for general desktop use cases (but as debugging has become more intensive, the perf loss from having it enabled is more costly.)

I suspect we'll be OK with PROVE_RCU off though.

Thanks!

regards, Kyle

#7 lore raw
Quoted 7 lines · Kyle McMartin
Quoted 3 lines · Paul E. McKenney

My kneejerk reaction is that PROVE_RCU is a developer tool, so I am OK with it not being set by default in Rawhide. Or have you seen good value from (say) PROVE_LOCKING in Rawhide?

Hi Paul,

Quoted 7 lines

I'm fine with this, we try to enable debug options in rawhide in order to get the most out of bug reports/dmesgs that we can. We've definitely spotted a lot of lockdep reports by having it enabled for general desktop use cases (but as debugging has become more intensive, the perf loss from having it enabled is more costly.)

I suspect we'll be OK with PROVE_RCU off though.

Sounds good -- but please feel free to bug me about this again if it turns out that you are seeing too many testing escapes from Rawhide into RHEL. Until then, my thought is that PROVE_RCU testing should primarily be done by developers on development trees.

Thanx, Paul