Skip to contentSkip to conversation

hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout

PATCH In review Anisse Astier 3 participants 4 messages Mar 29, 2010 – Mar 30, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout

Add the NOGET quirk for the Quanta optical touchscreen present on MSI AE2220, Otherwise, the hid-quanta driver timeouts at load time:

drivers/hid/usbhid/hid-core.c: usb_submit_urb(ctrl) failed
quanta-touch 0003:0408:3001.0003: timeout initializing reports
input: PixArt Imaging Inc. Optical Touch Screen as /class/input/input7
quanta-touch 0003:0408:3001.0003: input: USB HID v1.10 Device [PixArt Imaging Inc. Optical Touch Screen] on usb-0000:00:06.0-2/input0

---
 drivers/hid/usbhid/hid-quirks.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/hid/usbhid/hid-quirks.c +1 -0
index 928943c..e71e005 100644
@@ -60,6 +60,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_PRODIGE, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT },
Signature · 1 line
1.6.5.7
#1 lore raw
Quoted 19 lines · Anisse Astier

Add the NOGET quirk for the Quanta optical touchscreen present on MSI AE2220, Otherwise, the hid-quanta driver timeouts at load time:

drivers/hid/usbhid/hid-core.c: usb_submit_urb(ctrl) failed
quanta-touch 0003:0408:3001.0003: timeout initializing reports
input: PixArt Imaging Inc. Optical Touch Screen as /class/input/input7
quanta-touch 0003:0408:3001.0003: input: USB HID v1.10 Device [PixArt Imaging Inc. Optical Touch Screen] on usb-0000:00:06.0-2/input0

---
 drivers/hid/usbhid/hid-quirks.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/hid/usbhid/hid-quirks.c +0 -0
index 928943c..e71e005 100644

drivers/hid/usbhid/hid-quirks.c static const struct hid_blacklist { · line 66

Quoted 7 lines
drivers/hid/usbhid/hid-quirks.c +1 -0
@@ -60,6 +60,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_PRODIGE, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT },

I have applied the patch, but I wonder why Alex (who added this device ID initially) wasn't seeing it?

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#2 lore raw
Quoted 16 lines · Jiri Kosina
Quoted 14 lines · Anisse Astier

Add the NOGET quirk for the Quanta optical touchscreen present on MSI AE2220, Otherwise, the hid-quanta driver timeouts at load time:

drivers/hid/usbhid/hid-core.c: usb_submit_urb(ctrl) failed
quanta-touch 0003:0408:3001.0003: timeout initializing reports
input: PixArt Imaging Inc. Optical Touch Screen as /class/input/input7
quanta-touch 0003:0408:3001.0003: input: USB HID v1.10 Device [PixArt Imaging Inc. Optical Touch Screen] on usb-0000:00:06.0-2/input0

---
 drivers/hid/usbhid/hid-quirks.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 15 lines

drivers/hid/usbhid/hid-quirks.c static const struct hid_blacklist { · line 66

Quoted 12 lines
drivers/hid/usbhid/hid-quirks.c +1 -0
index 928943c..e71e005 100644
@@ -60,6 +60,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_PRODIGE, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT },

I have applied the patch, but I wonder why Alex (who added this device ID initially) wasn't seeing it?

Good question indeed, that's why I included him in the Cc. I just assumed that he saw it but didn't bother, since this problem is not critical: the driver just works correctly after the timeout, and we can receive the touchscreen events.

Maybe I'm wrong, Alex?

Regards,

Anisse

#3 lore raw

Anisse,

Sorry for being out of pocket. I had some health issues that I had to address.

The answer is that I have never encountered it. I would assume that it might be related to usb devices present, bios version and/or kernel configuration.

However, I am not surprised by your findings and appreciate your addressing your findings.

My son has an msi gaming laptop. Until we updated the bios and the camera bios to the latest version, he was unable to boot kernels > 2.6.32rc2 without the dreaded read/64 error -110. Even with the updates, restart produces the same error. As a result, he now does a shutdown and then powers up to restart...

I think that it is safe to assume that some users would have fared as I have and some would have faired as you have. Thanks for the great work.

Cheers,

Alex

----- Original Message ----
From: Anisse Astier <[email protected]>
To: Jiri Kosina <[email protected]>
Cc: [email protected]; Stephane Chatty <[email protected]>; Alex Neblett <[email protected]>
Sent: Mon, March 29, 2010 10:03:53 AM
Subject: Re: [PATCH] hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout

Quoted 16 lines · Jiri Kosina
Quoted 14 lines · Anisse Astier

Add the NOGET quirk for the Quanta optical touchscreen present on MSI AE2220, Otherwise, the hid-quanta driver timeouts at load time:

drivers/hid/usbhid/hid-core.c: usb_submit_urb(ctrl) failed
quanta-touch 0003:0408:3001.0003: timeout initializing reports
input: PixArt Imaging Inc. Optical Touch Screen as /class/input/input7
quanta-touch 0003:0408:3001.0003: input: USB HID v1.10 Device [PixArt Imaging Inc. Optical Touch Screen] on usb-0000:00:06.0-2/input0

---
 drivers/hid/usbhid/hid-quirks.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 15 lines

drivers/hid/usbhid/hid-quirks.c static const struct hid_blacklist { · line 66

Quoted 12 lines
drivers/hid/usbhid/hid-quirks.c +1 -0
index 928943c..e71e005 100644
@@ -60,6 +60,7 @@ static const struct hid_blacklist {
     { USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
     { USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET },
     { USB_VENDOR_ID_PRODIGE, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET },
+    { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN, HID_QUIRK_NOGET },
     { USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET },
     { USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET },
     { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT },

I have applied the patch, but I wonder why Alex (who added this device ID initially) wasn't seeing it?

Good question indeed, that's why I included him in the Cc. I just assumed that he saw it but didn't bother, since this problem is not critical: the driver just works correctly after the timeout, and we can receive the touchscreen events.

Maybe I'm wrong, Alex?

Regards,

Anisse