Skip to contentSkip to conversation

CRED: Fix memory leak in error handling

PATCH New David Howells 1 participant 1 message Mar 29, 2010 Credentials

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CRED: Fix memory leak in error handling

From: Mathieu Desnoyers <[email protected]>

Fix a memory leak on an OOM condition in prepare_usermodehelper_creds().

---

 kernel/cred.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
kernel/cred.c +5 -1
index 1ed8ca1..1b1129d 100644
@@ -364,7 +364,7 @@ struct cred *prepare_usermodehelper_creds(void)
 
 	new = kmem_cache_alloc(cred_jar, GFP_ATOMIC);
 	if (!new)
-		return NULL;
+		goto free_tgcred;
 
 	kdebug("prepare_usermodehelper_creds() alloc %p", new);
 
@@ -397,6 +397,10 @@ struct cred *prepare_usermodehelper_creds(void)
 
 error:
 	put_cred(new);
+free_tgcred:
+#ifdef CONFIG_KEYS
+	kfree(tgcred);
+#endif
 	return NULL;
 }