x86,kgdb: Always initialize the hw breakpoint attribute
PATCH 1/1 x86,kgdb: Always initialize the hw breakpoint attribute
It is required to call hw_breakpoint_init() on an attr before using it in any other calls. This fixes the problem where kgdb will sometimes fail to initialize on x86_64.
CC Ingo Molnar <[email protected]>
Signed-off-by Jason Wessel <[email protected]>
--- arch/x86/kernel/kgdb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/kgdb.c +1 -1
@@ -618,8 +618,8 @@ int kgdb_arch_init(void)* portion of kgdb because this operation requires mutexs to * complete. */ +hw_breakpoint_init (&attr); attr.bp_addr = (unsigned long )kgdb_arch_init; - attr.type =PERF_TYPE_BREAKPOINT ; attr.bp_len =HW_BREAKPOINT_LEN_1 ; attr.bp_type =HW_BREAKPOINT_W ; attr.disabled =1 ;
Signature · 1 line
1.5.4.3
Frederic Weisbecker
AppliedQuoted 8 lines · Jason Wessel
It is required to call
hw_breakpoint_init()on an attr before using it in any other calls. This fixes the problem where kgdb will sometimes fail to initialize onx86_64.CC Ingo Molnar <[email protected]>Signed-off-by Jason Wessel <[email protected]>
Queued for perf/urgent, thanks!
Quoted 21 lines
--- arch/x86/kernel/kgdb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/x86/kernel/kgdb.c +1
-1@@ -618,8 +618,8 @@ int kgdb_arch_init(void)* portion of kgdb because this operation requires mutexs to * complete. */ +hw_breakpoint_init (&attr); attr.bp_addr = (unsigned long )kgdb_arch_init; - attr.type =PERF_TYPE_BREAKPOINT ; attr.bp_len =HW_BREAKPOINT_LEN_1 ; attr.bp_type =HW_BREAKPOINT_W ; attr.disabled =1 ;Signature · 1 line
1.5.4.3
Commit-ID: ab310b5edb8b601bcb02491ed6f7676da4fd1757 Gitweb: http://git.kernel.org/tip/ab310b5edb8b601bcb02491ed6f7676da4fd1757 Author: Jason Wessel <[email protected]> AuthorDate: Tue, 30 Mar 2010 14:05:07 -0500 Committer: Frederic Weisbecker <[email protected]> CommitDate: Thu, 1 Apr 2010 08:26:32 +0200
x86,kgdb: Always initialize the hw breakpoint attribute
It is required to call hw_breakpoint_init() on an attr before using it in any other calls. This fixes the problem where kgdb will sometimes fail to initialize on x86_64.
Signed-off-by Jason Wessel <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc 2.6.33 <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by Frederic Weisbecker <[email protected]>
--- arch/x86/kernel/kgdb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/kgdb.c +1 -1
@@ -618,8 +618,8 @@ int kgdb_arch_init(void)* portion of kgdb because this operation requires mutexs to * complete. */ +hw_breakpoint_init (&attr); attr.bp_addr = (unsigned long )kgdb_arch_init; - attr.type =PERF_TYPE_BREAKPOINT ; attr.bp_len =HW_BREAKPOINT_LEN_1 ; attr.bp_type =HW_BREAKPOINT_W ; attr.disabled =1 ;