Skip to contentSkip to conversation

patch iwlwifi-silence-tfds_in_queue-message.patch added to 2.6.32-stable tree

DISCUSSION Stefan Bader 3 participants 4 messages Mar 30, 2010 – Mar 31, 2010 3 messages not in the archive Networking drivers (wireless)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 12698953011038@site

A message that is not in the archive (sent off-list or not yet received): 1269900575.2446.3425.camel@rchatre-DESK

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 11 lines · Greg KH
Quoted 10 lines · reinette chatre

Hi,

Quoted 5 lines · On Mon, 2010-03-29 at 13:41 -0700, [email protected] wrote:

This is a note to let you know that we have just queued up the patch titled

Subject: iwlwifi: Silence tfds_in_queue message

to the 2.6.32-stable tree.

[...]

Quoted 7 lines
Quoted 4 lines

Please note that this patch is really just masking a problem introduced by a 2.6.32 backported patch. The real fix is
https://patchwork.kernel.org/patch/86722/ which should be included in 2.6.32.

What is the git commit id for that patch? patchwork links don't help me at all.

There isn't one. The main problem only exists in 2.6.32.y because the final hunk missed to remove the nfreed++ from ouside the if.

Introduced by backport of in 2.6.32.y

commit a120e912eb51e347f36c71b60a1d13af74d30e83

Author: Stanislaw Gruszka <[email protected]>
Date:   Fri Feb 19 15:47:33 2010 -0800

iwlwifi: sanity check before counting number of tfds can be free

Quoted 7 lines

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable-commits" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 24 lines · Stefan Bader
Quoted 11 lines · Greg KH
Quoted 10 lines · reinette chatre

Hi,

Quoted 5 lines · On Mon, 2010-03-29 at 13:41 -0700, [email protected] wrote:

This is a note to let you know that we have just queued up the patch titled

Subject: iwlwifi: Silence tfds_in_queue message

to the 2.6.32-stable tree.

[...]

Quoted 7 lines
Quoted 4 lines

Please note that this patch is really just masking a problem introduced by a 2.6.32 backported patch. The real fix is
https://patchwork.kernel.org/patch/86722/ which should be included in 2.6.32.

What is the git commit id for that patch? patchwork links don't help me at all.

There isn't one. The main problem only exists in 2.6.32.y because the final hunk missed to remove the nfreed++ from ouside the if.

Quoted 7 lines

Introduced by backport of in 2.6.32.y

commit a120e912eb51e347f36c71b60a1d13af74d30e83

Author: Stanislaw Gruszka <[email protected]>
Date:   Fri Feb 19 15:47:33 2010 -0800

iwlwifi: sanity check before counting number of tfds can be free

So, what exactly should I be doing here for the .32 stable queue?

what a mess,

greg k-h

#5 lore raw

2010/3/30 Greg KH <[email protected]>:

Quoted 27 lines · Stefan Bader
Quoted 26 lines
Quoted 11 lines · Greg KH
Quoted 10 lines · reinette chatre

Hi,

Quoted 5 lines · On Mon, 2010-03-29 at 13:41 -0700, [email protected] wrote:

This is a note to let you know that we have just queued up the patch titled

    Subject: iwlwifi: Silence tfds_in_queue message

to the 2.6.32-stable tree.

[...]

Quoted 7 lines
Quoted 4 lines

Please note that this patch is really just masking a problem introduced by a 2.6.32 backported patch. The real fix is
https://patchwork.kernel.org/patch/86722/ which should be included in 2.6.32.

What is the git commit id for that patch?  patchwork links don't help me at all.

There isn't one. The main problem only exists in 2.6.32.y because the final hunk missed to remove the nfreed++ from ouside the if.

Introduced by backport of in 2.6.32.y

Quoted 7 lines
Quoted 5 lines

commit a120e912eb51e347f36c71b60a1d13af74d30e83
Author: Stanislaw Gruszka <[email protected]>
Date:   Fri Feb 19 15:47:33 2010 -0800

    iwlwifi: sanity check before counting number of tfds can be free

So, what exactly should I be doing here for the .32 stable queue?

Apply the patch that fixes the mess (i.e the one Reinette linked to) ;), whether this patch (the one you are about to push) goes in or not does not matter much (i.e having it won't hurt, but the fix for the real problem should go in).

Adel

author Tested-by Adel Gadllah
#6 lore raw
In reply to Greg KH
Quoted 25 lines · Greg KH
Quoted 24 lines · Stefan Bader
Quoted 9 lines · Greg KH
Quoted 8 lines · reinette chatre

Hi,

Quoted 5 lines · On Mon, 2010-03-29 at 13:41 -0700, [email protected] wrote:

This is a note to let you know that we have just queued up the patch titled

Subject: iwlwifi: Silence tfds_in_queue message

to the 2.6.32-stable tree.

Quoted 8 lines
Quoted 6 lines

[...]

Please note that this patch is really just masking a problem introduced by a 2.6.32 backported patch. The real fix is
https://patchwork.kernel.org/patch/86722/ which should be included in 2.6.32.

What is the git commit id for that patch? patchwork links don't help me at all.

There isn't one. The main problem only exists in 2.6.32.y because the final hunk missed to remove the nfreed++ from ouside the if.

Introduced by backport of in 2.6.32.y

Quoted 7 lines
Quoted 5 lines

commit a120e912eb51e347f36c71b60a1d13af74d30e83

Author: Stanislaw Gruszka <[email protected]>
Date:   Fri Feb 19 15:47:33 2010 -0800

iwlwifi: sanity check before counting number of tfds can be free

So, what exactly should I be doing here for the .32 stable queue?

git'ified verrsion of patchworks patch attached.

Stefan

Quoted 10 lines

what a mess,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

From 5d96faae63f4af4ff4d1effe46d18cc9ba203d00 Mon Sep 17 00:00:00 2001

From: Stanislaw Gruszka <[email protected]>
Date: Thu, 18 Mar 2010 14:29:33 +0000
Subject: [PATCH] iwlwifi: fix nfreed--

During backporting of a120e912eb51e347f36c71b60a1d13af74d30e83 ("iwlwifi: sanity check before counting number of tfds can be free") we forget one hunk, what make lot of messages "free more than tfds_in_queue" show up in dmesg.

(picked from https://patchwork.kernel.org/patch/86722/)

---
 drivers/net/wireless/iwlwifi/iwl-tx.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/wireless/iwlwifi/iwl-tx.c +0 -1
index f449f06..cf5ac00 100644
@@ -1096,7 +1096,6 @@ int iwl_tx_queue_reclaim(struct iwl_priv *priv, int txq_id, int index)
 			priv->cfg->ops->lib->txq_inval_byte_cnt_tbl(priv, txq);
 
 		priv->cfg->ops->lib->txq_free_tfd(priv, txq);
-		nfreed++;
 	}
 	return nfreed;
 }
Signature · 1 line
1.6.3.3