Monitor: Convert do_screen_dump() to QObject
PATCH 1/1 Monitor: Convert do_screen_dump() to QObject
Trivial, as it never fails, doesn't have output nor return any data.
Note that it's also available under QMP, as kvm-autotest needs this.
Signed-off-by Luiz Capitulino <[email protected]>
--- monitor.c | 3 ++- qemu-monitor.hx | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
monitor.c +2 -1
@@ -1163,9 +1163,10 @@ static int do_change(Monitor *mon, const QDict *qdict, QObject **ret_data)return ret; } -static void do_screen_dump (Monitor *mon,const QDict *qdict) +static int do_screen_dump (Monitor *mon,const QDict *qdict,QObject **ret_data) {vga_hw_screen_dump (qdict_get_str (qdict,"filename" )); +return 0 ; }static void do_logfile (Monitor *mon,const QDict *qdict)
qemu-monitor.hx +2 -1
@@ -199,7 +199,8 @@ ETEXI .args_type = "filename:F", .params = "filename", .help = "save screen into PPM image 'filename'", - .mhandler.cmd = do_screen_dump, + .user_print = monitor_user_noop, + .mhandler.cmd_new = do_screen_dump, }, STEXI
Signature · 1 line
1.7.0.3.291.g5e4f6
Quoted 7 lines · Luiz Capitulino
Trivial, as it never fails, doesn't have output nor return any data.
Note that it's also available under QMP, as kvm-autotest needs this.
Signed-off-by Luiz Capitulino <[email protected]>
Looks good.
Aside: screen dump fails silently, but that's outside the scope of QMP conversion.