Skip to contentSkip to conversation

wd7000: typo spin_unlock_irq() => spin_lock_irq()

PATCH In review Dan Carpenter 2 participants 2 messages Apr 1, 2010 – Apr 8, 2010

Subsystems (2)
SCSI Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 wd7000: typo spin_unlock_irq() => spin_lock_irq()

This was introduced back in 2005 at the very start of the git era by:

	df0ae2497ddefd72a87f3a3b34ff32455d7d4ae0
	[SCSI] allow sleeping in ->eh_host_reset_handler()
Signed-off-by Dan Carpenter <[email protected]>

---
Also this driver was written before some of our youngest kernel hackers were born. Neat. :)

drivers/scsi/wd7000.c +1 -1
index 2f6e9d8..bdfe59d 100644
@@ -1588,7 +1588,7 @@ static int wd7000_host_reset(struct scsi_cmnd *SCpnt)
 {
 	Adapter *host = (Adapter *) SCpnt->device->host->hostdata;
 
-	spin_unlock_irq(SCpnt->device->host->host_lock);
+	spin_lock_irq(SCpnt->device->host->host_lock);
 
 	if (wd7000_adapter_reset(host) < 0) {
 		spin_unlock_irq(SCpnt->device->host->host_lock);
#1 lore raw
Quoted 14 lines · Dan Carpenter

This was introduced back in 2005 at the very start of the git era by:

	df0ae2497ddefd72a87f3a3b34ff32455d7d4ae0
	[SCSI] allow sleeping in ->eh_host_reset_handler()
Signed-off-by Dan Carpenter <[email protected]>

---
Also this driver was written before some of our youngest kernel hackers were born. Neat. :)

drivers/scsi/wd7000.c +0 -0
index 2f6e9d8..bdfe59d 100644

drivers/scsi/wd7000.c static int wd7000_host_reset(struct scsi_cmnd *SCpnt) · line 1592

Quoted 6 lines
drivers/scsi/wd7000.c +1 -1
@@ -1588,7 +1588,7 @@ static int wd7000_host_reset(struct scsi_cmnd *SCpnt)
 {
 	Adapter *host = (Adapter *) SCpnt->device->host->hostdata;
 
-	spin_unlock_irq(SCpnt->device->host->host_lock);
+	spin_lock_irq(SCpnt->device->host->host_lock);

Doesn't seem to be present in today's linux-next, so I have queued it in my tree so that it doesn't get lost.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.