mfd: off by one issue
Subsystems (2)
PATCH 1/1 mfd: off by one issue
"pcf->irq_handler" has PCF50633_NUM_IRQ elements.
Signed-off-by Dan Carpenter <[email protected]>
drivers/mfd/pcf50633-core.c +2 -2
@@ -217,7 +217,7 @@ static struct attribute_group pcf_attr_group = {int pcf50633_register_irq (struct pcf50633 *pcf,int irq,void (*handler) (int ,void *),void *data) { -if (irq <0 || irq >PCF50633_NUM_IRQ || !handler) +if (irq <0 || irq >=PCF50633_NUM_IRQ || !handler)return -EINVAL ;if (WARN_ON (pcf->irq_handler[irq].handler))
@@ -234,7 +234,7 @@ EXPORT_SYMBOL_GPL(pcf50633_register_irq);int pcf50633_free_irq (struct pcf50633 *pcf,int irq) { -if (irq <0 || irq >PCF50633_NUM_IRQ ) +if (irq <0 || irq >=PCF50633_NUM_IRQ )return -EINVAL ;mutex_lock (&pcf->lock);
Hi Dan,
Quoted 3 lines · Dan Carpenter
"
pcf->irq_handler" hasPCF50633_NUM_IRQelements.Signed-off-by Dan Carpenter <[email protected]>
Patch applied, many thanks.
Cheers,
Samuel.
Quoted 22 lines
drivers/mfd/pcf50633-core.c +2
-2@@ -217,7 +217,7 @@ static struct attribute_group pcf_attr_group = {int pcf50633_register_irq (struct pcf50633 *pcf,int irq,void (*handler) (int ,void *),void *data) { -if (irq <0 || irq >PCF50633_NUM_IRQ || !handler) +if (irq <0 || irq >=PCF50633_NUM_IRQ || !handler)return -EINVAL ;if (WARN_ON (pcf->irq_handler[irq].handler))@@ -234,7 +234,7 @@ EXPORT_SYMBOL_GPL(pcf50633_register_irq);int pcf50633_free_irq (struct pcf50633 *pcf,int irq) { -if (irq <0 || irq >PCF50633_NUM_IRQ ) +if (irq <0 || irq >=PCF50633_NUM_IRQ )return -EINVAL ;mutex_lock (&pcf->lock);
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/