Skip to contentSkip to conversation

asus: don't modify bluetooth/wlan on boot

PATCH Applied Dan Carpenter 3 participants 4 messages Apr 6, 2010 – Apr 12, 2010

Subsystems (3)
Kernel janitors x86 platform drivers ASUS notebooks and eeepc ACPI/WMI extras drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 asus: don't modify bluetooth/wlan on boot

We were storing -1 as an unsigned int and as a result the effect of passing -1 was the same as using 1.

Signed-off-by Dan Carpenter <[email protected]>
drivers/platform/x86/asus-laptop.c +4 -4
index 475ab50..f532336 100644
@@ -78,15 +78,15 @@ static uint wapf = 1;
 module_param(wapf, uint, 0644);
 MODULE_PARM_DESC(wapf, "WAPF value");
 
-static uint wlan_status = 1;
-static uint bluetooth_status = 1;
+static int wlan_status = 1;
+static int bluetooth_status = 1;
 
-module_param(wlan_status, uint, 0644);
+module_param(wlan_status, int, 0644);
 MODULE_PARM_DESC(wlan_status, "Set the wireless status on boot "
 		 "(0 = disabled, 1 = enabled, -1 = don't do anything). "
 		 "default is 1");
 
-module_param(bluetooth_status, uint, 0644);
+module_param(bluetooth_status, int, 0644);
 MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
 		 "(0 = disabled, 1 = enabled, -1 = don't do anything). "
 		 "default is 1");
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 26 lines · Dan Carpenter

We were storing -1 as an unsigned int and as a result the effect of passing -1 was the same as using 1.

Signed-off-by Dan Carpenter <[email protected]>
drivers/platform/x86/asus-laptop.c +3 -3
index 475ab50..f532336 100644
@@ -78,15 +78,15 @@ static uint wapf = 1;
  module_param(wapf, uint, 0644);
  MODULE_PARM_DESC(wapf, "WAPF value");
 
-static uint wlan_status = 1;
-static uint bluetooth_status = 1;
+static int wlan_status = 1;
+static int bluetooth_status = 1;
 
-module_param(wlan_status, uint, 0644);
+module_param(wlan_status, int, 0644);

 MODULE_PARM_DESC(wlan_status, "Set the wireless status on boot " "(0 = disabled, 1 = enabled, -1 = don't do anything). " "default is 1");

drivers/platform/x86/asus-laptop.c +1 -1
-module_param(bluetooth_status, uint, 0644);
+module_param(bluetooth_status, int, 0644);
Quoted 4 lines

 MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot " "(0 = disabled, 1 = enabled, -1 = don't do anything). " "default is 1");
--

Thanks !

Acked-by Corentin Chary <[email protected]>
Signature · 6 lines
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html