Skip to contentSkip to conversation

net: fix definition of netdev_for_each_mc_addr()

PATCH Applied Pavel Roskin 2 participants 2 messages Apr 7, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Pavel Roskin

author
#0 lore raw

PATCH 1/1 net: fix definition of netdev_for_each_mc_addr()

The first argument should be called ha, not mclist. All callers use the name "ha", but if they used a different name, there would be a compile error.

Signed-off-by Pavel Roskin <[email protected]>

---

This is against the current net-next.

 include/linux/netdevice.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/netdevice.h +1 -1
index a343a21..d1a21b5 100644
@@ -260,7 +260,7 @@ struct netdev_hw_addr_list {
 
 #define netdev_mc_count(dev) netdev_hw_addr_list_count(&(dev)->mc)
 #define netdev_mc_empty(dev) netdev_hw_addr_list_empty(&(dev)->mc)
-#define netdev_for_each_mc_addr(mclist, dev) \
+#define netdev_for_each_mc_addr(ha, dev) \
 	netdev_hw_addr_list_for_each(ha, &(dev)->mc)
 
 struct hh_cache {
maintainer Applied
#1 lore raw

From: Pavel Roskin <[email protected]>
Date: Wed, 07 Apr 2010 18:01:52 -0400

Quoted 5 lines

The first argument should be called ha, not mclist. All callers use the name "ha", but if they used a different name, there would be a compile error.

Signed-off-by Pavel Roskin <[email protected]>

Applied, thank you.