Skip to contentSkip to conversation

libata fix

PATCH New Jeff Garzik 1 participant 1 message Apr 8, 2010 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libata fix

Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus

to receive the following updates:

 include/linux/ata.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Mark Lord (1):
libata: Fix accesses at LBA28 boundary (old bug, but nasty) (v2)

include/linux/ata.h +2 -2
index b4c85e2..700c5b9 100644
@@ -1025,8 +1025,8 @@ static inline int ata_ok(u8 status)
 
 static inline int lba_28_ok(u64 block, u32 n_block)
 {
-	/* check the ending block number */
-	return ((block + n_block) < ((u64)1 << 28)) && (n_block <= 256);
+	/* check the ending block number: must be LESS THAN 0x0fffffff */
+	return ((block + n_block) < ((1 << 28) - 1)) && (n_block <= 256);
 }
 
 static inline int lba_48_ok(u64 block, u32 n_block)