staging/dt3155: fix build error caused by {write|read}l change
PATCH 1/1 staging/dt3155: fix build error caused by {write|read}l change
This fixes a build error caused by replacing {Write | Read}MReg with {write | read}l.
---
drivers/staging/dt3155/dt3155_io.c +1 -0
@@ -21,6 +21,7 @@*/ #include <linux/delay.h> +#include <linux/io.h> #include "dt3155.h" #include "dt3155_io.h" #include "dt3155_drv.h"
Quoted 2 lines · H Hartley Sweeten
This fixes a build error caused by replacing {Write | Read}MReg with {write | read}l.
Ick, can you merge this with your other patch so we don't have build errors? I just hit this and I had to drop all of your patches.
Can you respin all of them please?
thanks,
greg k-h
Quoted 6 lines · Greg KH
Quoted 2 lines · H Hartley Sweeten
This fixes a build error caused by replacing {Write | Read}MReg with {write | read}l.
Ick, can you merge this with your other patch so we don't have build errors? I just hit this and I had to drop all of your patches.
I was expecting you to NAK all of them anyway after I saw all the code cleanup patches coming in on LKML.
Quoted 1 line
Can you respin all of them please?
Not a problem. Are you planning on merging any of the dt3155 cleanup patches? If so I will wait until they show up.
Also, should staging patches be based on linux-next or on Linus' git tree?
Regards,
Hartley
Quoted 8 lines · H Hartley Sweeten
Quoted 6 lines · Greg KH
Quoted 2 lines · H Hartley Sweeten
This fixes a build error caused by replacing {Write | Read}MReg with {write | read}l.
Ick, can you merge this with your other patch so we don't have build errors? I just hit this and I had to drop all of your patches.
Quoted 7 lines
I was expecting you to NAK all of them anyway after I saw all the code cleanup patches coming in on LKML.
Quoted 1 line
Can you respin all of them please?
Not a problem. Are you planning on merging any of the dt3155 cleanup patches? If so I will wait until they show up.
I took some, you should have gotten the responses now.
Quoted 1 line
Also, should staging patches be based on linux-next or on Linus' git tree?
linux-next please.
thanks,
greg k-h
Quoted 12 lines · Greg KH
Quoted 11 lines · H Hartley Sweeten
Quoted 6 lines · Greg KH
Quoted 2 lines · H Hartley Sweeten
This fixes a build error caused by replacing {Write | Read}MReg with {write | read}l.
Ick, can you merge this with your other patch so we don't have build errors? I just hit this and I had to drop all of your patches.
I was expecting you to NAK all of them anyway after I saw all the code cleanup patches coming in on LKML.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Can you respin all of them please?
Not a problem. Are you planning on merging any of the dt3155 cleanup patches? If so I will wait until they show up.
I took some, you should have gotten the responses now.
I wasn't on the CC list for the ones I noticed on LKML.
A lot of the patches I saw seemed to be duplicate works to clean up the files. Plus, some of them appeared that they would conflict in various ways. I guess such is the life of a staging driver...
Quoted 3 lines
Quoted 1 line
Also, should staging patches be based on linux-next or on Linus' git tree?
linux-next please.
Not a problem. I'll wait a bit to see what shows up before doing anything.
Regards,
Hartley
Quoted 12 lines · Greg KH
Quoted 11 lines · H Hartley Sweeten
Quoted 6 lines · Greg KH
Quoted 2 lines · H Hartley Sweeten
This fixes a build error caused by replacing {Write | Read}MReg with {write | read}l.
Ick, can you merge this with your other patch so we don't have build errors? I just hit this and I had to drop all of your patches.
I was expecting you to NAK all of them anyway after I saw all the code cleanup patches coming in on LKML.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Can you respin all of them please?
Not a problem. Are you planning on merging any of the dt3155 cleanup patches? If so I will wait until they show up.
I took some, you should have gotten the responses now.
Hello Greg,
Do you know off hand what (if any) of the dt3155 patches you took and when they might show up in linux-next? The last commits in next-20100413 are:
commit 5a0e3ad6af8660be21ca98a971cd00f331318c05
Author: Tejun Heo <[email protected]> Date: Wed Mar 24 17:04:11 2010 +0900
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from p
commit 3a8954e8f22cf31791d8c524c2839433e39f9368
Author: H Hartley Sweeten <[email protected]> Date: Fri Feb 26 17:58:07 2010 -0700
staging: dt3155: revert u_long to u64 usage
Regards,
Hartley
Quoted 29 lines · H Hartley Sweeten
Quoted 12 lines · Greg KH
Quoted 11 lines · H Hartley Sweeten
Quoted 6 lines · Greg KH
Quoted 2 lines · H Hartley Sweeten
This fixes a build error caused by replacing {Write | Read}MReg with {write | read}l.
Ick, can you merge this with your other patch so we don't have build errors? I just hit this and I had to drop all of your patches.
I was expecting you to NAK all of them anyway after I saw all the code cleanup patches coming in on LKML.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Can you respin all of them please?
Not a problem. Are you planning on merging any of the dt3155 cleanup patches? If so I will wait until they show up.
I took some, you should have gotten the responses now.
Hello Greg,
Do you know off hand what (if any) of the dt3155 patches you took and when they might show up in linux-next? The last commits in next-20100413 are:
commit
5a0e3ad6af8660be21ca98a971cd00f331318c05Author: Tejun Heo <[email protected]> Date: Wed Mar 24 17:04:11 2010 +0900
Quoted 7 lines
include cleanup: Update
gfp.handslab.hincludes to prepare for breaking implicitslab.hinclusion from pcommit
3a8954e8f22cf31791d8c524c2839433e39f9368Author: H Hartley Sweeten <[email protected]> Date: Fri Feb 26 17:58:07 2010 -0700staging: dt3155: revert
u_longto u64 usage
Hm, I need to tell Stephen to pull the proper tree for my staging-next stuff, I am playing around with just using git for it. Give me some time, I'm in a conference all this week...
thanks,
greg k-h