Skip to contentSkip to conversation

Fix some #includes in CAN drivers

PATCH In review Hans J. Koch 3 participants 3 messages Apr 8, 2010 – Apr 13, 2010 1 message not in the archive

Subsystems (5)
Networking Network drivers Arm/Microchip (AT91) SoC support CAN network drivers +1 more subsystems
lore
Share & tools
lore

Hans J. Koch

author
#0 lore raw

PATCH 1/1 Fix some #includes in CAN drivers

In the current implementation, CAN drivers need to #include <linux/can.h> _before_ they #include <linux/can/dev.h>, which is both ugly and unnecessary.

Fix this by including <linux/can.h> in <linux/can/dev.h> and remove the #include <linux/can.h> lines from drivers.

Signed-off-by Hans J. Koch <[email protected]>
---
 drivers/net/can/at91_can.c                    |    1 -
 drivers/net/can/bfin_can.c                    |    1 -
 drivers/net/can/mcp251x.c                     |    1 -
 drivers/net/can/mscan/mpc5xxx_can.c           |    1 -
 drivers/net/can/mscan/mscan.c                 |    1 -
 drivers/net/can/sja1000/ems_pci.c             |    1 -
 drivers/net/can/sja1000/kvaser_pci.c          |    1 -
 drivers/net/can/sja1000/plx_pci.c             |    1 -
 drivers/net/can/sja1000/sja1000.c             |    1 -
 drivers/net/can/sja1000/sja1000_isa.c         |    1 -
 drivers/net/can/sja1000/sja1000_of_platform.c |    1 -
 drivers/net/can/sja1000/sja1000_platform.c    |    1 -
 drivers/net/can/ti_hecc.c                     |    1 -
 include/linux/can/dev.h                       |    1 +
 14 files changed, 1 insertion(+), 13 deletions(-)
include/linux/can/dev.h +1 -0
Index: linux-2.6.34-rc/include/linux/can/dev.h
===================================================================
@@ -14,6 +14,7 @@
 #ifndef CAN_DEV_H
 #define CAN_DEV_H
 
+#include <linux/can.h>
 #include <linux/can/netlink.h>
 #include <linux/can/error.h>
drivers/net/can/at91_can.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/at91_can.c
===================================================================
@@ -35,7 +35,6 @@
 #include <linux/string.h>
 #include <linux/types.h>
 
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/can/error.h>
drivers/net/can/bfin_can.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/bfin_can.c
===================================================================
@@ -18,7 +18,6 @@
 #include <linux/skbuff.h>
 #include <linux/platform_device.h>
 
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/can/error.h>
drivers/net/can/mcp251x.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/mcp251x.c
===================================================================
@@ -58,7 +58,6 @@
  *
  */
 
-#include <linux/can.h>
 #include <linux/can/core.h>
 #include <linux/can/dev.h>
 #include <linux/can/platform/mcp251x.h>
drivers/net/can/ti_hecc.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/ti_hecc.c
===================================================================
@@ -47,7 +47,6 @@
 #include <linux/platform_device.h>
 #include <linux/clk.h>
 
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/can/error.h>
 #include <linux/can/platform/ti_hecc.h>
drivers/net/can/mscan/mpc5xxx_can.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/mscan/mpc5xxx_can.c
===================================================================
@@ -25,7 +25,6 @@
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <linux/netdevice.h>
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/of_platform.h>
 #include <sysdev/fsl_soc.h>
drivers/net/can/mscan/mscan.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/mscan/mscan.c
===================================================================
@@ -28,7 +28,6 @@
 #include <linux/if_arp.h>
 #include <linux/if_ether.h>
 #include <linux/list.h>
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/can/error.h>
 #include <linux/io.h>
drivers/net/can/sja1000/ems_pci.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/sja1000/ems_pci.c
===================================================================
@@ -23,7 +23,6 @@
 #include <linux/netdevice.h>
 #include <linux/delay.h>
 #include <linux/pci.h>
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/io.h>
drivers/net/can/sja1000/kvaser_pci.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/sja1000/kvaser_pci.c
===================================================================
@@ -36,7 +36,6 @@
 #include <linux/netdevice.h>
 #include <linux/delay.h>
 #include <linux/pci.h>
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/io.h>
drivers/net/can/sja1000/plx_pci.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/sja1000/plx_pci.c
===================================================================
@@ -26,7 +26,6 @@
 #include <linux/netdevice.h>
 #include <linux/delay.h>
 #include <linux/pci.h>
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/io.h>
drivers/net/can/sja1000/sja1000.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/sja1000/sja1000.c
===================================================================
@@ -60,7 +60,6 @@
 #include <linux/skbuff.h>
 #include <linux/delay.h>
 
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/can/error.h>
drivers/net/can/sja1000/sja1000_isa.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/sja1000/sja1000_isa.c
===================================================================
@@ -23,7 +23,6 @@
 #include <linux/delay.h>
 #include <linux/irq.h>
 #include <linux/io.h>
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/can/platform/sja1000.h>
drivers/net/can/sja1000/sja1000_of_platform.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/sja1000/sja1000_of_platform.c
===================================================================
@@ -38,7 +38,6 @@
 #include <linux/interrupt.h>
 #include <linux/netdevice.h>
 #include <linux/delay.h>
-#include <linux/can.h>
 #include <linux/can/dev.h>
 
 #include <linux/of_platform.h>
drivers/net/can/sja1000/sja1000_platform.c +0 -1
Index: linux-2.6.34-rc/drivers/net/can/sja1000/sja1000_platform.c
===================================================================
@@ -24,7 +24,6 @@
 #include <linux/pci.h>
 #include <linux/platform_device.h>
 #include <linux/irq.h>
-#include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/can/platform/sja1000.h>
 #include <linux/io.h>
maintainer
#1 lore raw

From: "Hans J. Koch" <[email protected]>
Date: Thu, 8 Apr 2010 21:25:45 +0200

Quoted 8 lines

In the current implementation, CAN drivers need to #include <linux/can.h> _before_ they #include <linux/can/dev.h>, which is both ugly and unnecessary.

Fix this by including <linux/can.h> in <linux/can/dev.h> and remove the #include <linux/can.h> lines from drivers.

Signed-off-by Hans J. Koch <[email protected]>

This doesn't apply cleanly to net-next-2.6, please respin your patch and resubmit.

Thanks.

A message that is not in the archive (sent off-list or not yet received): 20100413.013614.200995710.davem-fT/PcQaiUtIeIZ0/[email protected]

#3 lore raw
Quoted 7 lines · David Miller

From: "Hans J. Koch" <[email protected]>
Date: Thu, 8 Apr 2010 21:25:45 +0200

Quoted 4 lines

In the current implementation, CAN drivers need to #include <linux/can.h> _before_ they #include <linux/can/dev.h>, which is both ugly and unnecessary.

Quoted 7 lines
Quoted 4 lines

Fix this by including <linux/can.h> in <linux/can/dev.h> and remove the #include <linux/can.h> lines from drivers.

Signed-off-by Hans J. Koch <[email protected]>

This doesn't apply cleanly to net-next-2.6, please respin your patch and resubmit.

Ooops, sorry. Will resubmit immediately.

Thanks,
Hans