add support of arm/pxa270 board made by voipac
Subsystems (2)
PATCH 2/2 add support of arm/pxa270 board made by voipac
This patch is based on custom u-boot-1.1.2 version produced by voipac
(http://www.voipac.com) and board/trizepsiv files from current u-boot.
Up to now only PXA270 DIMM module with NOR flash is tested.
--- Makefile | 3 + board/vpac270/Makefile | 51 +++ board/vpac270/config.mk | 3 + board/vpac270/lowlevel_init.S | 740 +++++++++++++++++++++++++++++++++++++++++ board/vpac270/vpac270.c | 101 ++++++ include/configs/vpac270.h | 329 ++++++++++++++++++ 6 files changed, 1227 insertions(+), 0 deletions(-) create mode 100644 board/vpac270/Makefile create mode 100644 board/vpac270/config.mk create mode 100644 board/vpac270/lowlevel_init.S create mode 100644 board/vpac270/vpac270.c create mode 100644 include/configs/vpac270.h
Makefile +3 -0
@@ -3253,6 +3253,9 @@ trizepsiv_config : unconfig fi; @$(MKCONFIG) -a trizepsiv arm pxa trizepsiv +vpac270_config: unconfig + @$(MKCONFIG) $(@:_config=) arm pxa vpac270 + wepep250_config : unconfig @$(MKCONFIG) $(@:_config=) arm pxa wepep250
board/vpac270/Makefile new file +51 -0
51 lines not on this page · raw message
board/vpac270/config.mk new file +3 -0
@@ -0,0 +1,3 @@ +TEXT_BASE =0xa1f00000 +# 0xa1700000 +#TEXT_BASE = 0
board/vpac270/lowlevel_init.S new file +740 -0
740 lines not on this page · raw message
board/vpac270/vpac270.c new file +101 -0
101 lines not on this page · raw message
include/configs/vpac270.h new file +329 -0
329 lines not on this page · raw message
Signature · 1 line
1.7.0
PATCH 2/2 add support of arm/pxa270 board made by voipac
Dear Mikhail Kshevetskiy,
Quoted 6 lines · In message <[email protected]> you wrote:
This patch is based on custom u-boot-1.1.2 version produced by voipac
(http://www.voipac.com) and board/trizepsiv files from current u-boot.Up to now only PXA270 DIMM module with NOR flash is tested.
Signed-off-by Mikhail Kshevetskiy <[email protected]>
Quoted 13 lines
--- Makefile | 3 + board/vpac270/Makefile | 51 +++ board/vpac270/config.mk | 3 + board/vpac270/lowlevel_init.S | 740 +++++++++++++++++++++++++++++++++++++++++ board/vpac270/vpac270.c | 101 ++++++ include/configs/vpac270.h | 329 ++++++++++++++++++ 6 files changed, 1227 insertions(+), 0 deletions(-) create mode 100644 board/vpac270/Makefile create mode 100644 board/vpac270/config.mk create mode 100644 board/vpac270/lowlevel_init.S create mode 100644 board/vpac270/vpac270.c create mode 100644 include/configs/vpac270.h
Entries to MAKEALL and MAINTAINERS missing.
board/vpac270/config.mk line 3
Quoted 9 lines
board/vpac270/config.mk new file +3
-0@@ -0,0 +1,3 @@ +TEXT_BASE =0xa1f00000 +# 0xa1700000 +#TEXT_BASE = 0
Please do not add dead code. Remove it.
Quoted 3 lines
board/vpac270/lowlevel_init.S new file +0
-0
...
board/vpac270/lowlevel_init.S line 39
Quoted 6 lines
board/vpac270/lowlevel_init.S new file +6
-0+/* wait for coprocessor write complete */ + .macro CPWAIT reg + mrc p15,0,\reg,c2,c0,0 + mov \reg,\reg + sub pc,pc,#4 + .endm
Indentation and vertial alignment by TAB only. Please fix globally.
board/vpac270/lowlevel_init.S line 53
Quoted 5 lines
board/vpac270/lowlevel_init.S new file +5
-0+ /* Set up GPIO pins first ----------------------------------------- */ + + ldr r0, =GPSR0 + ldr r1, =CONFIG_SYS_GPSR0_VAL + str r1, [r0]
One TAB between instruction and arguments should be sufficient.
board/vpac270/lowlevel_init.S line 141
Quoted 7 lines
board/vpac270/lowlevel_init.S new file +7
-0+ /* ---------------------------------------------------------------- */ + /* Enable memory interface */ + /* */ + /* The sequence below is based on the recommended init steps */ + /* detailed in the Intel PXA250 Operating Systems Developers Guide, */ + /* Chapter 10. */ + /* ---------------------------------------------------------------- */
Incorrect multiline comment style. Please fix globally.
...
board/vpac270/lowlevel_init.S line 197
Quoted 4 lines
board/vpac270/lowlevel_init.S new file +4
-0+ /* MECR: Memory Expansion Card Register */ + ldr r2, =CONFIG_SYS_MECR_VAL + str r2, [r1, #MECR_OFFSET] + ldr r2, [r1, #MECR_OFFSET]
Inconsistent indentation - please fix globally.
Quoted 43 lines
board/vpac270/lowlevel_init.S new file +43
-0+ /* MCMEM0: Card Interface slot 0 timing */ + ldr r2, =CONFIG_SYS_MCMEM0_VAL + str r2, [r1, #MCMEM0_OFFSET] + ldr r2, [r1, #MCMEM0_OFFSET] + + /* MCMEM1: Card Interface slot 1 timing */ + ldr r2, =CONFIG_SYS_MCMEM1_VAL + str r2, [r1, #MCMEM1_OFFSET] + ldr r2, [r1, #MCMEM1_OFFSET] + + /* MCATT0: Card Interface Attribute Space Timing, slot 0 */ + ldr r2, =CONFIG_SYS_MCATT0_VAL + str r2, [r1, #MCATT0_OFFSET] + ldr r2, [r1, #MCATT0_OFFSET] + + /* MCATT1: Card Interface Attribute Space Timing, slot 1 */ + ldr r2, =CONFIG_SYS_MCATT1_VAL + str r2, [r1, #MCATT1_OFFSET] + ldr r2, [r1, #MCATT1_OFFSET] + + /* MCIO0: Card Interface I/O Space Timing, slot 0 */ + ldr r2, =CONFIG_SYS_MCIO0_VAL + str r2, [r1, #MCIO0_OFFSET] + ldr r2, [r1, #MCIO0_OFFSET] + + /* MCIO1: Card Interface I/O Space Timing, slot 1 */ + ldr r2, =CONFIG_SYS_MCIO1_VAL + str r2, [r1, #MCIO1_OFFSET] + ldr r2, [r1, #MCIO1_OFFSET] + + /* ---------------------------------------------------------------- */ + /* Step 2c: Write FLYCNFG FIXME: what's that??? */ + /* ---------------------------------------------------------------- */ +@ ldr r2, =CONFIG_SYS_FLYCNFG_VAL +@ str r2, [r1, #FLYCNFG_OFFSET] +@ str r2, [r1, #FLYCNFG_OFFSET] + + /* ---------------------------------------------------------------- */ + /* Step 2d: Initialize Timing for Sync Memory (SDCLK0) */ + /* ---------------------------------------------------------------- */ + + /* Before accessing MDREFR we need a valid DRI field, so we set */ + /* this to power on defaults + DRI field. */
board/vpac270/lowlevel_init.S line 251
Quoted 10 lines
board/vpac270/lowlevel_init.S new file +10
-0+ + ldr r4, [r1, #MDREFR_OFFSET] + ldr r2, =0xFFF + bic r4, r4, r2 + + ldr r3, =CONFIG_SYS_MDREFR_VAL + and r3, r3, r2 + + orr r4, r4, r3 + str r4, [r1, #MDREFR_OFFSET] /* write back MDREFR */
Hm... I think most of this does not belong into lowlevel_init.S which really should be kept minimal. Most of this should be rewritten in C.
Quoted 5 lines
board/vpac270/vpac270.c new file +0
-0
...
board/vpac270/vpac270.c line 68
Quoted 6 lines
board/vpac270/vpac270.c new file +6
-0+int board_late_init (void ) +{ +#if defined(CONFIG_SERIAL_MULTI ) +char *console=getenv ("boot_console" ); + +if (console ==NULL ) console =BOOT_CONSOLE ;
Incorrect indentation. Please check and fix globally.
Quoted 5 lines
include/configs/vpac270.h new file +0
-0
...
Quoted 1 line
+//#define DEBUG 15
No C++ comments please. And don't add dead code.
...
include/configs/vpac270.h line 107
Quoted 3 lines
include/configs/vpac270.h new file +3
-0+#define CONFIG_BOOTDELAY 3 +#define CONFIG_BOOTCOMMAND "FIXME" +#define CONFIG_BOOTARGS "root=/dev/mtdblock2 rootfstype=jffs2 console=ttyS0,115200"
Line too long. Please fix globally.
include/configs/vpac270.h line 142
Quoted 5 lines
include/configs/vpac270.h new file +5
-0+#define CONFIG_STACKSIZE (64*1024)/* regular stack */ +#ifdef CONFIG_USE_IRQ +#define CONFIG_STACKSIZE_IRQ (4*1024)/* IRQ stack */ +#define CONFIG_STACKSIZE_FIQ (4*1024)/* FIQ stack */ +#endif
Indentation by TAB only!
Quoted 4 lines
include/configs/vpac270.h new file +4
-0+/* +* GPIO settings +*/ +#if 1 /* minimal vpac270 settings, includes FFUART and Ethernet */
...
Quoted 1 line
+#else /* maximal vpac270 settings */
...
Do not add dead code. Remove the "#if 1" and the whole "else" block.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's a way out of any cage.
-- Captain Christopher Pike, "The Menagerie" ("The Cage"),
stardate unknown.PATCH 2/2 add support of arm/pxa270 board made by voipac
Dear Wolfgang Denk,
Here is my comments to your notices,
the updated patch is in the following letter.
Quoted 23 lines · On Tue, 30 Mar 2010 23:15:45 +0200 Wolfgang Denk <[email protected]> wrote:
Dear Mikhail Kshevetskiy,
Quoted 6 lines · In message <[email protected]> you wrote:
This patch is based on custom u-boot-1.1.2 version produced by voipac
(http://www.voipac.com) and board/trizepsiv files from current u-boot.Up to now only PXA270 DIMM module with NOR flash is tested.
Signed-off-by Mikhail Kshevetskiy <[email protected]>Quoted 13 lines
--- Makefile | 3 + board/vpac270/Makefile | 51 +++ board/vpac270/config.mk | 3 + board/vpac270/lowlevel_init.S | 740 +++++++++++++++++++++++++++++++++++++++++ board/vpac270/vpac270.c | 101 ++++++ include/configs/vpac270.h | 329 ++++++++++++++++++ 6 files changed, 1227 insertions(+), 0 deletions(-) create mode 100644 board/vpac270/Makefile create mode 100644 board/vpac270/config.mk create mode 100644 board/vpac270/lowlevel_init.S create mode 100644 board/vpac270/vpac270.c create mode 100644 include/configs/vpac270.h
Quoted 1 line
Entries to MAKEALL and
MAINTAINERSmissing.
fixed
Quoted 11 lines
board/vpac270/config.mk line 3
Quoted 9 lines
board/vpac270/config.mk new file +3
-0@@ -0,0 +1,3 @@ +TEXT_BASE =0xa1f00000 +# 0xa1700000 +#TEXT_BASE = 0Please do not add dead code. Remove it.
fixed
Quoted 4 lines
Quoted 3 lines
board/vpac270/lowlevel_init.S new file +0
-0...
Quoted 8 lines
board/vpac270/lowlevel_init.S line 39
Quoted 6 lines
board/vpac270/lowlevel_init.S new file +6
-0+/* wait for coprocessor write complete */ + .macro CPWAIT reg + mrc p15,0,\reg,c2,c0,0 + mov \reg,\reg + sub pc,pc,#4 + .endmIndentation and vertial alignment by TAB only. Please fix globally.
fixed,
I try to keep lowlevel_init.S as much close to the same file from board/trizeptiv as it was possible, so initially i keep formatting and comments style from the upstream version of board/trizeptiv/lowlevel_init.S.
Quoted 8 lines
board/vpac270/lowlevel_init.S line 53
Quoted 6 lines
board/vpac270/lowlevel_init.S new file +5
-0+ /* Set up GPIO pins first ----------------------------------------- */ + + ldr r0, =GPSR0 + ldr r1, =CONFIG_SYS_GPSR0_VAL + str r1, [r0]One TAB between instruction and arguments should be sufficient.
same as above
Quoted 9 lines
board/vpac270/lowlevel_init.S line 141
Quoted 7 lines
board/vpac270/lowlevel_init.S new file +7
-0+ /* ---------------------------------------------------------------- */ + /* Enable memory interface */ + /* */ + /* The sequence below is based on the recommended init steps */ + /* detailed in the Intel PXA250 Operating Systems Developers Guide, */ + /* Chapter 10. */ + /* ---------------------------------------------------------------- */Incorrect multiline comment style. Please fix globally.
same as above
Quoted 7 lines
...
board/vpac270/lowlevel_init.S line 197
Quoted 4 lines
board/vpac270/lowlevel_init.S new file +4
-0+ /* MECR: Memory Expansion Card Register */ + ldr r2, =CONFIG_SYS_MECR_VAL + str r2, [r1, #MECR_OFFSET] + ldr r2, [r1, #MECR_OFFSET]Inconsistent indentation - please fix globally.
same as above
Quoted 49 lines
Quoted 49 lines
board/vpac270/lowlevel_init.S new file +49
-0+ /* MCMEM0: Card Interface slot 0 timing */ + ldr r2, =CONFIG_SYS_MCMEM0_VAL + str r2, [r1, #MCMEM0_OFFSET] + ldr r2, [r1, #MCMEM0_OFFSET] + + /* MCMEM1: Card Interface slot 1 timing */ + ldr r2, =CONFIG_SYS_MCMEM1_VAL + str r2, [r1, #MCMEM1_OFFSET] + ldr r2, [r1, #MCMEM1_OFFSET] + + /* MCATT0: Card Interface Attribute Space Timing, slot 0 */ + ldr r2, =CONFIG_SYS_MCATT0_VAL + str r2, [r1, #MCATT0_OFFSET] + ldr r2, [r1, #MCATT0_OFFSET] + + /* MCATT1: Card Interface Attribute Space Timing, slot 1 */ + ldr r2, =CONFIG_SYS_MCATT1_VAL + str r2, [r1, #MCATT1_OFFSET] + ldr r2, [r1, #MCATT1_OFFSET] + + /* MCIO0: Card Interface I/O Space Timing, slot 0 */ + ldr r2, =CONFIG_SYS_MCIO0_VAL + str r2, [r1, #MCIO0_OFFSET] + ldr r2, [r1, #MCIO0_OFFSET] + + /* MCIO1: Card Interface I/O Space Timing, slot 1 */ + ldr r2, =CONFIG_SYS_MCIO1_VAL + str r2, [r1, #MCIO1_OFFSET] + ldr r2, [r1, #MCIO1_OFFSET] + + /* ---------------------------------------------------------------- */ + /* Step 2c: Write FLYCNFG FIXME: what's that??? */ + /* ---------------------------------------------------------------- */ +@ ldr r2, =CONFIG_SYS_FLYCNFG_VAL +@ str r2, [r1, #FLYCNFG_OFFSET] +@ str r2, [r1, #FLYCNFG_OFFSET] + + /* ---------------------------------------------------------------- */ + /* Step 2d: Initialize Timing for Sync Memory (SDCLK0) */ + /* ---------------------------------------------------------------- */ + + /* Before accessing MDREFR we need a valid DRI field, so we set */ + /* this to power on defaults + DRI field. */ + + ldr r4, [r1, #MDREFR_OFFSET] + ldr r2, =0xFFF + bic r4, r4, r2 + + ldr r3, =CONFIG_SYS_MDREFR_VAL
Quoted 8 lines
board/vpac270/lowlevel_init.S line 251
Quoted 4 lines
board/vpac270/lowlevel_init.S new file +4
-0+ and r3, r3, r2 + + orr r4, r4, r3 + str r4, [r1, #MDREFR_OFFSET] /* write back MDREFR */Hm... I think most of this does not belong into
lowlevel_init.Swhich really should be kept minimal. Most of this should be rewritten in C.
the similar or exactly the same peace of code can be found in lowlevel initialization of almost all arm/pxa boards, so i think it is reasonable to keep this code in place.
Quoted 6 lines
Quoted 5 lines
board/vpac270/vpac270.c new file +0
-0...
Quoted 8 lines
board/vpac270/vpac270.c line 68
Quoted 6 lines
board/vpac270/vpac270.c new file +6
-0+int board_late_init (void ) +{ +#if defined(CONFIG_SERIAL_MULTI ) +char *console=getenv ("boot_console" ); + +if (console ==NULL ) console =BOOT_CONSOLE ;Incorrect indentation. Please check and fix globally.
fixed,
The same as early, i try to keep this file similar to board/trizeptiv/conxs.c file from the upstream.
Quoted 10 lines
Quoted 6 lines
include/configs/vpac270.h new file +0
-0...
Quoted 1 line
+//#define DEBUG 15
No C++ comments please. And don't add dead code.
fixed
Quoted 6 lines
...
include/configs/vpac270.h line 107
Quoted 3 lines
include/configs/vpac270.h new file +3
-0+#define CONFIG_BOOTDELAY 3 +#define CONFIG_BOOTCOMMAND "FIXME" +#define CONFIG_BOOTARGS "root=/dev/mtdblock2 rootfstype=jffs2 console=ttyS0,115200"Line too long. Please fix globally.
fixed
Quoted 7 lines
include/configs/vpac270.h line 142
Quoted 5 lines
include/configs/vpac270.h new file +5
-0+#define CONFIG_STACKSIZE (64*1024)/* regular stack */ +#ifdef CONFIG_USE_IRQ +#define CONFIG_STACKSIZE_IRQ (4*1024)/* IRQ stack */ +#define CONFIG_STACKSIZE_FIQ (4*1024)/* FIQ stack */ +#endif Indentation by TAB only!
fixed
Quoted 9 lines
Quoted 4 lines
include/configs/vpac270.h new file +4
-0+/* +* GPIO settings +*/ +#if 1 /* minimal vpac270 settings, includes FFUART and Ethernet */ ...
Quoted 1 line
+#else /* maximal vpac270 settings */
...
Do not add dead code. Remove the "#if 1" and the whole "else" block.
fixed
PATCH 2/2 add support of arm/pxa270 board made by voipac
Dear Mikhail Kshevetskiy,
Quoted 3 lines · In message <[email protected]> you wrote:
Here is my comments to your notices,
the updated patch is in the following letter.
Thanks.
Quoted 3 lines
I try to keep
lowlevel_init.Sas much close to the same file from board/trizeptiv as it was possible, so initially i keep formatting and comments style from the upstream version ofboard/trizeptiv/lowlevel_init.S.
I see. But a bad example is no reason to keep this style. Please fix.
Quoted 3 lines
the similar or exactly the same peace of code can be found in lowlevel initialization of almost all arm/pxa boards, so i think it is reasonable to keep this code in place.
The fact that we accepted poor code in the past ist no reason not to try to improve over time.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Intelligence without character is a dangerous thing." - G. Steinem
PATCH 2/2 add support of arm/pxa270 board made by voipac [rev 2]
In reply to Wolfgang DenkThis patch is based on custom u-boot-1.1.2 version produced by voipac
(http://www.voipac.com) and board/trizepsiv files from current u-boot.
Up to now only PXA270 DIMM module with NOR flash is tested.
v2: code style was improved
--- MAINTAINERS | 4 + MAKEALL | 1 + Makefile | 3 + board/vpac270/Makefile | 51 +++ board/vpac270/config.mk | 1 + board/vpac270/lowlevel_init.S | 735 +++++++++++++++++++++++++++++++++++++++++ board/vpac270/vpac270.c | 103 ++++++ include/configs/vpac270.h | 408 +++++++++++++++++++++++ 8 files changed, 1306 insertions(+), 0 deletions(-) create mode 100644 board/vpac270/Makefile create mode 100644 board/vpac270/config.mk create mode 100644 board/vpac270/lowlevel_init.S create mode 100644 board/vpac270/vpac270.c create mode 100644 include/configs/vpac270.h
MAINTAINERS +4 -0
@@ -525,6 +525,10 @@ Stefano Babic <[email protected]> polaris xscale trizepsiv xscale +Mikhail Kshevetskiy <[email protected]> + + vpac270 xscale + Dirk Behme <[email protected]> omap3_beagle ARM CORTEX-A8 (OMAP3530 SoC)
MAKEALL +1 -0
@@ -692,6 +692,7 @@ LIST_pxa=" \ polaris \ pxa255_idp \ trizepsiv \ + vpac270 \ wepep250 \ xaeniax \ xm250 \
Makefile +3 -0
@@ -3250,6 +3250,9 @@ trizepsiv_config : unconfig fi; @$(MKCONFIG) -a trizepsiv arm pxa trizepsiv +vpac270_config: unconfig + @$(MKCONFIG) $(@:_config=) arm pxa vpac270 + wepep250_config : unconfig @$(MKCONFIG) $(@:_config=) arm pxa wepep250
board/vpac270/Makefile new file +51 -0
51 lines not on this page · raw message
board/vpac270/config.mk new file +1 -0
@@ -0,0 +1 @@ +TEXT_BASE =0xa1f00000
board/vpac270/lowlevel_init.S new file +735 -0
735 lines not on this page · raw message
board/vpac270/vpac270.c new file +103 -0
103 lines not on this page · raw message
include/configs/vpac270.h new file +408 -0
408 lines not on this page · raw message
Signature · 1 line
1.7.0
PATCH 2/2 add support of arm/pxa270 board made by voipac [rev 2]
Dear Mikhail Kshevetskiy,
Quoted 8 lines · In message <[email protected]> you wrote:
This patch is based on custom u-boot-1.1.2 version produced by voipac
(http://www.voipac.com) and board/trizepsiv files from current u-boot.Up to now only PXA270 DIMM module with NOR flash is tested.
v2: code style was improved
Signed-off-by Mikhail Kshevetskiy <[email protected]>
NAK. Please see review comments to previous version.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "No one talks peace unless he's ready to back it up with war." "He talks of peace if it is the only way to live." -- Colonel Green and Surak of Vulcan, "The Savage Curtain", stardate 5906.5.
PATCH 2/2 add support of arm/pxa270 board made by voipac [rev 2]
Dne So 10. dubna 2010 00:39:41 Wolfgang Denk napsal(a):
Quoted 10 lines
Dear Mikhail Kshevetskiy,
Quoted 7 lines · In message <[email protected]> you wrote:
This patch is based on custom u-boot-1.1.2 version produced by voipac
(http://www.voipac.com) and board/trizepsiv files from current u-boot.Up to now only PXA270 DIMM module with NOR flash is tested.
v2: code style was improved
Quoted 7 lines
Quoted 1 line
Signed-off-by Mikhail Kshevetskiy <[email protected]>NAK. Please see review comments to previous version.
Best regards,
Wolfgang Denk
I sent you my not-really-a-patch for vpac270. Hope you can get some ideas. But please, that patch I sent you doesn't have the review issues addressed, be sure to fix those.
Thanks!
PATCH 2/2 add support of arm/pxa270 board made by voipac [rev 2]
In reply to Wolfgang DenkDne So 10. dubna 2010 00:39:41 Wolfgang Denk napsal(a):
Quoted 10 lines
Dear Mikhail Kshevetskiy,
Quoted 7 lines · In message <[email protected]> you wrote:
This patch is based on custom u-boot-1.1.2 version produced by voipac
(http://www.voipac.com) and board/trizepsiv files from current u-boot.Up to now only PXA270 DIMM module with NOR flash is tested.
v2: code style was improved
Quoted 7 lines
Quoted 1 line
Signed-off-by Mikhail Kshevetskiy <[email protected]>NAK. Please see review comments to previous version.
Best regards,
Wolfgang Denk
Hi,
Mikhail, any updates on this ?
PATCH 2/2 add support of arm/pxa270 board made by voipac
In reply to Mikhail KshevetskiyDear Mikhail Kshevetskiy,
Quoted 6 lines · In message <[email protected]> you wrote:
This patch is based on custom u-boot-1.1.2 version produced by voipac
(http://www.voipac.com) and board/trizepsiv files from current u-boot.Up to now only PXA270 DIMM module with NOR flash is tested.
Signed-off-by Mikhail Kshevetskiy <[email protected]>
Quoted 13 lines
--- Makefile | 3 + board/vpac270/Makefile | 51 +++ board/vpac270/config.mk | 3 + board/vpac270/lowlevel_init.S | 740 +++++++++++++++++++++++++++++++++++++++++ board/vpac270/vpac270.c | 101 ++++++ include/configs/vpac270.h | 329 ++++++++++++++++++ 6 files changed, 1227 insertions(+), 0 deletions(-) create mode 100644 board/vpac270/Makefile create mode 100644 board/vpac270/config.mk create mode 100644 board/vpac270/lowlevel_init.S create mode 100644 board/vpac270/vpac270.c create mode 100644 include/configs/vpac270.h
Entries to MAKEALL and MAINTAINERS missing.
board/vpac270/config.mk line 3
Quoted 6 lines
board/vpac270/config.mk new file +3
-0@@ -0,0 +1,3 @@ +TEXT_BASE xa1f00000 +# 0xa1700000 +#TEXT_BASE 0
Please do not adde dead code. Please fix globally.
Quoted 35 lines
board/vpac270/lowlevel_init.S new file +29
-0@@ -0,0 +1,740 @@ +/* + * This was originally from the Lubbock u-boot port. + * + * Most of this taken from Redboot hal_platform_setup.h with cleanup + * + * NOTE: I haven't clean this up considerably, just enough to get it + * running. See hal_platform_setup.h for the source. See + * board/cradle/lowlevel_init.S for another PXA250 setup that is + * much cleaner. + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ +
board/vpac270/lowlevel_init.S line 39
Quoted 10 lines
board/vpac270/lowlevel_init.S new file +10
-0+#include <config.h> +#include <version.h> +#include <asm/arch/pxa-regs.h> + +/* wait for coprocessor write complete */ + .macro CPWAIT reg + mrc p15,0,\reg,c2,c0,0 + mov \reg,\reg + sub pc,pc,#4 + .endm
Indentation by TAB only. Please fix globally.
board/vpac270/lowlevel_init.S line 53
Quoted 5 lines
board/vpac270/lowlevel_init.S new file +5
-0+ /* Set up GPIO pins first ----------------------------------------- */ + + ldr r0, GPSR0 + ldr r1, ONFIG_SYS_GPSR0_VAL + str r1, [r0]
One TAB should be enough to separate insn and args.
board/vpac270/lowlevel_init.S line 627
Quoted 1 line
board/vpac270/lowlevel_init.S new file +1
-0+#ifdef NODEBUG
Please don't add dead code, not even like this.
Quoted 7 lines
board/vpac270/lowlevel_init.S new file +7
-0+ /*Disable software and data breakpoints */ + mov r0,#0 + mcr p15,0,r0,c14,c8,0 /* ibcr0 */ + mcr p15,0,r0,c14,c9,0 /* ibcr1 */ + mcr p15,0,r0,c14,c4,0 /* dbcon */ + + /*Enable all debug functionality */
board/vpac270/lowlevel_init.S
Quoted 10 lines
board/vpac270/lowlevel_init.S new file +8
-0+ mov r0,#0x80000000 + mcr p14,0,r0,c10,c0,0 /* dcsr */ +#endif +/* ------------------------------------------------------------------------- */ + +/* + * Miscelaneous platform dependent initialisations + */
Typos. s/l/ll/, s/sat/zat/
board/vpac270/lowlevel_init.S
Quoted 4 lines
board/vpac270/lowlevel_init.S new file +4
-0+int board_init (void) +{ + /* memory and cpu-speed are setup before relocation */ + /* so we do _nothing_ here */
incorrect multiline comment style.
board/vpac270/lowlevel_init.S
Quoted 6 lines
board/vpac270/lowlevel_init.S new file +6
-0+int board_late_init(void) +{ +#if defined(CONFIG_SERIAL_MULTI) + char *consolegetenv("boot_console"); + + if (console NULL) console BOOT_CONSOLE;
Incorrect indentation. What the heck is "console BOOT_CONSOLE" ???
Quoted 5 lines
+++
b/include/configs/vpac270.hboard/vpac270/lowlevel_init.S new file +3
-0@@ -0,0 +1,329 @@ +/* + * (C) Copyright 2005 + * Detlef Vollmann, Toradex AG, <[email protected]>
board/vpac270/lowlevel_init.S line 13
Quoted 10 lines
board/vpac270/lowlevel_init.S new file +10
-0+ * + * (C) Copyright 2004 + * Robert Whaley, Applied Data Systems, Inc. rwhaley at applieddata.net + * + * (C) Copyright 2002 + * Kyle Harris, Nexus Technologies, Inc. kharris at nexus-tech.net + * + * (C) Copyright 2002 + * Sysgo Real-Time Solutions, GmbH <www.elinos.com> + * Marius Groeger <[email protected]>
Is it really true that all these people have contributed significant parts to that file, and at the given dates?
board/vpac270/lowlevel_init.S line 17
Quoted 4 lines
board/vpac270/lowlevel_init.S new file +4
-0+#ifndef __CONFIG_H +#define __CONFIG_H + +//#define DEBUG 15
No C++ comments. Please fix globally.
board/vpac270/lowlevel_init.S line 22
Quoted 5 lines
board/vpac270/lowlevel_init.S new file +5
-0+/* + * Size of malloc() pool + */ +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE + 128*1024) +#define CONFIG_SYS_GBL_DATA_SIZE 128 /* size in bytes reserved for initial data */
Line too long. Please fix globally.
board/vpac270/lowlevel_init.S line 27
Quoted 5 lines
board/vpac270/lowlevel_init.S new file +5
-0+#define CONFIG_PXA_SERIAL +#define CONFIG_SERIAL_MULTI +#define CONFIG_FFUART 1 /* we use FFUART on Colibri */ +#define CONFIG_BTUART 1 /* we use BTUART on Colibri */ +#define CONFIG_STUART 1 /* we use STUART on Colibri */
On colibri? Is the comment really correct?
board/vpac270/lowlevel_init.S line 34
Quoted 7 lines
board/vpac270/lowlevel_init.S new file +7
-0+/* allow to overwrite serial and ethaddr */ +#define CONFIG_ENV_OVERWRITE + +#define CONFIG_SERVERIP 192.168.1.1 +#define CONFIG_IPADDR 192.168.1.48 +#define CONFIG_NETMASK 255.255.255.0 +#define CONFIG_ETHADDR 00:01:02:03:04:05
NAK. Remove this stuff, it makes no sense. Especially not with a stolen MAC address (00:01:02 belongs to the 3COM CORPORATION).
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de An armed society is a polite society.