Skip to contentSkip to conversation

be2net: clarify promiscuous cmd with a comment

PATCH Applied Sathya Perla 2 participants 2 messages Apr 12, 2010 – Apr 13, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Sathya Perla

author
#0 lore raw

PATCH 1/1 be2net: clarify promiscuous cmd with a comment

The promiscous cmd config code gives an impression that setting a port to promisc mode will unset the other port. This is not the case and is clarified with a comment.

Signed-off-by Sathya Perla <[email protected]>
---
 drivers/net/benet/be_cmds.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/net/benet/be_cmds.c +4 -0
index da87930..e79bf8b 100644
@@ -1113,6 +1113,10 @@ int be_cmd_promiscuous_config(struct be_adapter *adapter, u8 port_num, bool en)
 	be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_ETH,
 		OPCODE_ETH_PROMISCUOUS, sizeof(*req));
 
+	/* In FW versions X.102.149/X.101.487 and later,
+	 * the port setting associated only with the
+	 * issuing pci function will take effect
+	 */
 	if (port_num)
 		req->port1_promiscuous = en;
 	else
Signature · 1 line
1.6.3.3
maintainer Applied
#1 lore raw

From: Sathya Perla <[email protected]>
Date: Mon, 12 Apr 2010 14:05:27 +0530

Quoted 5 lines

The promiscous cmd config code gives an impression that setting a port to promisc mode will unset the other port. This is not the case and is clarified with a comment.

Signed-off-by Sathya Perla <[email protected]>

Applied.