arm: ARCH_REQUIRE_GPIOLIB selects GENERIC_GPIO

Quoted 7 lines · H Hartley Sweeten

The ARCH_REQUIRE_GPIOLIB config option will select GPIOLIB which in turn will select GENERIC_GPIO. ?Because of this, there is no reason to do the select GENERIC_GPIO in arch/arm/Kconfig for the architectures that have ARCH_REQUIRE_GPIOLIB.

Signed-off-by H Hartley Sweeten <[email protected]>

A clean removal, Acked-by: Eric Miao <[email protected]>

The ARCH_REQUIRE_GPIOLIB config option will select GPIOLIB which in turn will select GENERIC_GPIO. Because of this, there is no reason to do the select GENERIC_GPIO in arch/arm/Kconfig for the architectures that have ARCH_REQUIRE_GPIOLIB.

Quoted 4 lines · H Hartley Sweeten

The ARCH_REQUIRE_GPIOLIB config option will select GPIOLIB which in turn will select GENERIC_GPIO. Because of this, there is no reason to do the select GENERIC_GPIO in arch/arm/Kconfig for the architectures that have ARCH_REQUIRE_GPIOLIB.

This kind of patch normally causes regular merge conflicts, which historically have caused a repeated number of headaches - there's a similar patch for GENERIC_TIME which is pending.

I suggest waiting until we're closer to the merge window than we are at present; I'll bring my devel stuff to a freeze state before hand so we can get these two patches merged - maybe around the -rc7 release.

Please ping me closer to that.

Quoted 10 lines · Russell King

Quoted 4 lines · H Hartley Sweeten

The ARCH_REQUIRE_GPIOLIB config option will select GPIOLIB which in turn will select GENERIC_GPIO. Because of this, there is no reason to do the select GENERIC_GPIO in arch/arm/Kconfig for the architectures that have ARCH_REQUIRE_GPIOLIB.

This kind of patch normally causes regular merge conflicts, which historically have caused a repeated number of headaches - there's a similar patch for GENERIC_TIME which is pending.

Quoted 6 lines

I suggest waiting until we're closer to the merge window than we are at present; I'll bring my devel stuff to a freeze state before hand so we can get these two patches merged - maybe around the -rc7 release.

Please ping me closer to that.

Will do.

I just wanted to get this out there to make sure nobody saw any issues.

I will hold this until around -rc7 as you requested and just collect any Ack's, etc., that show up. Eric Miao has already sent an Acked-by that I will add then.

On Mon, Apr 12, 2010 at 02:01:17PM -0500, H Hartley Sweeten wrote:

Quoted 21 lines · Russell King

Quoted 10 lines · H Hartley Sweeten

Quoted 4 lines

The ARCH_REQUIRE_GPIOLIB config option will select GPIOLIB which in turn will select GENERIC_GPIO. Because of this, there is no reason to do the select GENERIC_GPIO in arch/arm/Kconfig for the architectures that have ARCH_REQUIRE_GPIOLIB.

This kind of patch normally causes regular merge conflicts, which historically have caused a repeated number of headaches - there's a similar patch for GENERIC_TIME which is pending.

Quoted 6 lines

I suggest waiting until we're closer to the merge window than we are at present; I'll bring my devel stuff to a freeze state before hand so we can get these two patches merged - maybe around the -rc7 release.

Please ping me closer to that.

Will do.

I just wanted to get this out there to make sure nobody saw any issues.

Quoted 3 lines

I will hold this until around -rc7 as you requested and just collect any Ack's, etc., that show up. Eric Miao has already sent an Acked-by that I will add then.

Also please keep an eye for any new places in -next where GENERIC_GPIO is selected as well as ARCH_REQUIRE_GPIOLIB - we're likely to see new platforms being added which may continue the old mistake.

-rc7 should be coming soon. Would you like this patch rebased now or after Linus releases -rc7? Also, I assume it should be rebased to linux-next or would you prefer it rebased to one of your branches?

Quoted 3 lines · H Hartley Sweeten

-rc7 should be coming soon. Would you like this patch rebased now or after Linus releases -rc7? Also, I assume it should be rebased to linux-next or would you prefer it rebased to one of your branches?

Thanks for reminding me.

This time around, there's a number of patches which can only sensibly be applied once I've frozen most of the individual branches of my tree, and this is one of them. Essentually, these are:
- your 'select GPIOLIB' patch
- killing the 'select GENERIC_TIME' from the ARM Kconfig menus
- pmu/oprofile patch set

Freezing it before -rc7 is released would be too early, so I think doing so shortly after -rc7 (which is due this evening/tonight) would be the right time.

Quoted 14 lines · Russell King

Quoted 3 lines · H Hartley Sweeten

-rc7 should be coming soon. Would you like this patch rebased now or after Linus releases -rc7? Also, I assume it should be rebased to linux-next or would you prefer it rebased to one of your branches?

Thanks for reminding me.

This time around, there's a number of patches which can only sensibly be applied once I've frozen most of the individual branches of my tree, and this is one of them. Essentually, these are:
- your 'select GPIOLIB' patch
- killing the 'select GENERIC_TIME' from the ARM Kconfig menus
- pmu/oprofile patch set

Quoted 3 lines

Freezing it before -rc7 is released would be too early, so I think doing so shortly after -rc7 (which is due this evening/tonight) would be the right time.

Hello Russell,

I see Linus released -rc7 over the weekend. When will you be freezing your -devel tree? I will rebase the 'select GPIOLIB' patch after that.

Russell,

Ping... ;-)

Are you ready for this patch to be rebased, and to what tree?

Are you ready for this patch to be rebased, and to what tree?

Quoted 1 line · H Hartley Sweeten

Are you ready for this patch to be rebased, and to what tree?

Can you rebase onto what's currently in the devel tree, and send the resulting patch to the patch system please?

(for others, I've temporarily dropped some merges on the devel tree.)

Are you ready for this patch to be rebased, and to what tree?

Added to patch system as Patch #6136.