Skip to contentSkip to conversation

skbuff: remove unused dev_consume_skb macro definition

PATCH Applied Jeff Kirsher 2 participants 2 messages Apr 9, 2010 – Apr 13, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 skbuff: remove unused dev_consume_skb macro definition

From: Alexander Duyck <[email protected]>

dev_consume_skb and kfree_skb_clean have no users and in the case of kfree_skb_clean could cause potential build issues since I cannot find where it is defined. Based on the patch in which it was introduced it appears to have been a bit of leftover code from an earlier version of the patch in which kfree_skb_clean was dropped in favor of consume_skb.

---

 include/linux/skbuff.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/skbuff.h +0 -1
index cf42f19..38501d2 100644
@@ -470,7 +470,6 @@ extern int	       skb_cow_data(struct sk_buff *skb, int tailbits,
 				    struct sk_buff **trailer);
 extern int	       skb_pad(struct sk_buff *skb, int pad);
 #define dev_kfree_skb(a)	consume_skb(a)
-#define dev_consume_skb(a)	kfree_skb_clean(a)
 extern void	      skb_over_panic(struct sk_buff *skb, int len,
 				     void *here);
 extern void	      skb_under_panic(struct sk_buff *skb, int len,
maintainer Applied
#1 lore raw

From: Jeff Kirsher <[email protected]>
Date: Fri, 09 Apr 2010 13:01:37 -0700

Quoted 10 lines

From: Alexander Duyck <[email protected]>

dev_consume_skb and kfree_skb_clean have no users and in the case of kfree_skb_clean could cause potential build issues since I cannot find where it is defined. Based on the patch in which it was introduced it appears to have been a bit of leftover code from an earlier version of the patch in which kfree_skb_clean was dropped in favor of consume_skb.

Applied.