Skip to contentSkip to conversation

CLD: cleanup: add cld_msg_rpc.x

PATCH Applied Pete Zaitcev 2 participants 4 messages Apr 14, 2010 – Apr 17, 2010 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/8 CLD: cleanup: add cld_msg_rpc.x

You know what's weird... Without this, I cannot build an RPM at all, the rpmbuild complains about unpackaged files and aborts. But everyone else seems to have no problem? Strange. BTW, I am on Fedora 14.

---
 lib/Makefile.am |    1 +
 1 file changed, 1 insertion(+)
lib/Makefile.am +1 -0
index ea72426..012d558 100644
@@ -27,6 +27,7 @@ libcldc_la_SOURCES	=	\
 	common.c		\
 	libtimer.c		\
 	pkt.c			\
+	cld_msg_rpc.x		\
 	cld_msg_rpc_xdr.c
 
 libcldc_la_LDFLAGS = \
#1 lore raw
Quoted 16 lines · Pete Zaitcev

You know what's weird... Without this, I cannot build an RPM at all, the rpmbuild complains about unpackaged files and aborts. But everyone else seems to have no problem? Strange. BTW, I am on Fedora 14.

---
  lib/Makefile.am |    1 +
  1 file changed, 1 insertion(+)
lib/Makefile.am +0 -0
index ea72426..012d558 100644

lib/Makefile.am libcldc_la_SOURCES = \ · line 31

Quoted 5 lines
lib/Makefile.am +1 -0
@@ -27,6 +27,7 @@ libcldc_la_SOURCES	=	\
  	common.c		\
  	libtimer.c		\
  	pkt.c			\
+	cld_msg_rpc.x		\
  	cld_msg_rpc_xdr.c

that's quite strange, because I built an official rawhide copy just fine without this...

Maybe you can try the SRPM from the koji build?

	http://koji.fedoraproject.org/koji/taskinfo?taskID=2114193

May I presume you are using "make distcheck" to generate the tarball for your custom RPMs?

Jeff

#2 lore raw
Quoted 10 lines · On Wed, 14 Apr 2010 15:55:01 -0400 Jeff Garzik <[email protected]> wrote:

lib/Makefile.am libcldc_la_SOURCES = \ · line 31

Quoted 7 lines

+++ b/lib/Makefile.am

lib/Makefile.am +1 -0
@@ -27,6 +27,7 @@ libcldc_la_SOURCES	=	\
  	common.c		\
  	libtimer.c		\
  	pkt.c			\
+	cld_msg_rpc.x		\
  	cld_msg_rpc_xdr.c

that's quite strange, because I built an official rawhide copy just fine without this...

Strange indeed, I re-checked and it went away now. Oh well.

Quoted 2 lines

May I presume you are using "make distcheck" to generate the tarball for your custom RPMs?

Of course.

-- Pete

#3 lore raw
Quoted 14 lines · Pete Zaitcev
Quoted 10 lines · On Wed, 14 Apr 2010 15:55:01 -0400 Jeff Garzik<[email protected]> wrote:

lib/Makefile.am libcldc_la_SOURCES = \ · line 31

Quoted 7 lines

+++ b/lib/Makefile.am

lib/Makefile.am +1 -0
@@ -27,6 +27,7 @@ libcldc_la_SOURCES	=	\
   	common.c		\
   	libtimer.c		\
   	pkt.c			\
+	cld_msg_rpc.x		\
   	cld_msg_rpc_xdr.c

that's quite strange, because I built an official rawhide copy just fine without this...

Quoted 1 line

Strange indeed, I re-checked and it went away now. Oh well.

I wonder if it's a problem with the 'clean' functionality. The EXTRA_DIST line contains a list of things forced to be included in the tarball, typically used for things not contained in *_SOURCES. AFAICT from the autoconf/automake docs, that is where sources for generated sources[1] should reside. So I still wonder how it disappeared for you...

Jeff

[1] Brought to you by the Department of Redundant Redundancies