Skip to contentSkip to conversation

set max63xx driver as ARM only

WATCHDOG Geert Uytterhoeven 3 participants 3 messages Apr 7, 2010 – Apr 15, 2010 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 41 lines · Linux Kernel Mailing List

Gitweb:     http://git.kernel.org/linus/5e8037166497f8a1aa46325ed7febf0408d45caa
Commit:     5e8037166497f8a1aa46325ed7febf0408d45caa
Parent:     35c79780064976cf9d7537a00e59f97c2061fa7d
Author:     Marc Zyngier <[email protected]>
AuthorDate: Mon Mar 29 20:09:14 2010 +0100
Committer:  Wim Van Sebroeck <[email protected]>
CommitDate: Sat Apr 3 22:39:30 2010 +0000

   [WATCHDOG] set max63xx driver as ARM only

   Use of ioremap() causes build failure on S390. Restrict the driver to ARM until another architecture comes along and enables the driver for its own use.

---
 drivers/watchdog/Kconfig |   11 ++++++-----

 1 files changed, 6 insertions(+), 5 deletions(-)
drivers/watchdog/Kconfig +0 -0
index bdcdbd5..0e8468f 100644
@@ -55,11 +55,6 @@ config SOFT_WATCHDOG

         To compile this driver as a module, choose M here: the module will be called softdog.

drivers/watchdog/Kconfig +0 -5
-config MAX63XX_WATCHDOG
-       tristate "Max63xx watchdog"
-       help
-         Support for memory mapped max63{69,70,71,72,73,74} watchdog timer.
-

 config WM831X_WATCHDOG
       tristate "WM831x watchdog"
       depends on MFD_WM831X

drivers/watchdog/Kconfig +0 -0
@@ -305,6 +300,12 @@ config TS72XX_WATCHDOG

         To compile this driver as a module, choose M here: the module will be called ts72xx_wdt.

Quoted 3 lines

+config MAX63XX_WATCHDOG
+       tristate "Max63xx watchdog"
+       depends on ARM

Shouldn't that have been `depends on HAS_IOMEM' instead?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
Quoted 5 lines · On Wed, 7 Apr 2010 19:56:18 +0200 Geert Uytterhoeven <[email protected]>…
Quoted 3 lines

+config MAX63XX_WATCHDOG
+       tristate "Max63xx watchdog"
+       depends on ARM

Shouldn't that have been `depends on HAS_IOMEM' instead?

Using HAS_IOMEM will prevent the build of the driver on s390 and is imho the correct dependency.

Signature · 4 lines
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.
#3 lore raw
In reply to Geert Uytterhoeven

Hi Geert, Martin,

Quoted 5 lines
Quoted 3 lines

+config MAX63XX_WATCHDOG
+       tristate "Max63xx watchdog"
+       depends on ARM

Shouldn't that have been `depends on HAS_IOMEM' instead?

Correct. Will add this today or tomorrow.

Kind regards,
Wim.