Skip to contentSkip to conversation

fix \"ar\" test

PATCH Mitani 3 participants 3 messages Apr 15, 2010

lore
Share & tools
lore

Mitani

author
#0 lore raw

Sorry.
My patch was destroyed by e-mail.
I attach patch for "ar01" file.

Regards--

-Tomonori Mitani

testcases/commands/ade/ar/ar01 +6 -6
@@ -519,19 +519,19 @@
 rm -rf $TCtmp/lib.a;cd $TCdat
 ar -cr $TCtmp/lib.a file0.in file2.in 
 crtest
-File1time=`ar -tv $TCtmp/lib.a | grep file0.in | cut -f2 -d: | cut -f1 -d" "`
-File2time=`ar -tv $TCtmp/lib.a | grep file2.in | cut -f2 -d: | cut -f1 -d" "`
+File1time=`ar -tv $TCtmp/lib.a | grep file0.in`
+File2time=`ar -tv $TCtmp/lib.a | grep file2.in`
 
 #sleep 5
 touch -c -t 201503030303.55 file0.in
 
 ar -ru $TCtmp/lib.a file0.in file2.in 2>&1 1>/dev/null
-File1time1=`ar -tv $TCtmp/lib.a | grep file0.in | cut -f2 -d: | cut -f1 -d" "`
-File2time2=`ar -tv $TCtmp/lib.a | grep file2.in | cut -f2 -d: | cut -f1 -d" "`
+File1time1=`ar -tv $TCtmp/lib.a | grep file0.in`
+File2time2=`ar -tv $TCtmp/lib.a | grep file2.in`
 
-if [ $File2time = $File2time2 ]
+if [ "$File2time" = "$File2time2" ]
 then
-	if [ $File1time = $File1time1 ]
+	if [ "$File1time" = "$File1time1" ]
 	then
     		TCRESULT=20
     		echo "FAIL - ar with -u flag failed"

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 3 lines · Mitani

Sorry.
My patch was destroyed by e-mail.
I attach patch for "ar01" file.

Applied to next branch. Will wait for someone to Acked/test it before merging to master.

Thanks
-Rishi

Quoted 21 lines

Regards--

-Tomonori Mitani

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Signature · 16 lines
Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#2 lore raw
Quoted 7 lines · Rishikesh K Rajak
Quoted 3 lines · Mitani

Sorry.
My patch was destroyed by e-mail.
I attach patch for "ar01" file.

Applied to next branch. Will wait for someone to Acked/test it before merging to master.

I would look through the commit history for this item (if not in git, definitely in cvs). Memory serves me correctly 2~3 months ago this script was last touched because of an output format change in ar (which means that the test needs to be modified to detect this change, or needs to be made semi-agnostic of the output from ar(1), preferably the latter but that's more difficult to achieve).
HTH,
-Garrett

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list