Skip to contentSkip to conversation

colibri.h: #include corrections

PATCH In review Jakob Viketoft 2 participants 3 messages Apr 16, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures PXA2xx/PXA3xx support
lore
Share & tools
lore

Jakob Viketoft

author
#0 lore raw

PATCH 1/1 colibri.h: #include corrections

The use of mfp_cfg_t causes build errors without including <mach/mfp.h>. The include for the ax88796 is kicked as well since it's inclusion is obsoleted as adviced by Daniel Mack.

CC: [email protected]
CC: Daniel Mack <[email protected]>
CC: Eric Miao <[email protected]> Signed-off-by Jakob Viketoft <[email protected]>

arch/arm/mach-pxa/include/mach/colibri.h +1 -1
@@ -1,7 +1,7 @@
 #ifndef _COLIBRI_H_
 #define _COLIBRI_H_
 
-#include <net/ax88796.h>
+#include <mach/mfp.h>
 
 /*
  * common settings for all modules
#1 lore raw
Quoted 3 lines · Jakob Viketoft

The use of mfp_cfg_t causes build errors without including <mach/mfp.h>. The include for the ax88796 is kicked as well since it's inclusion is obsoleted as adviced by Daniel Mack.

Argh, I'm sorry. This time, I was too fast. The ax88796 must stay, I overlooked the use of ax_plat_data.

Daniel

Quoted 19 lines

CC: [email protected]
CC: Daniel Mack <[email protected]>
CC: Eric Miao <[email protected]> Signed-off-by Jakob Viketoft <[email protected]>

--- a/arch/arm/mach-pxa/include/mach/colibri.h 2010-03-15
17:09:39.000000000 +0100
+++ b/arch/arm/mach-pxa/include/mach/colibri.h 2010-04-16
13:30:43.000000000 +0200

arch/arm/mach-pxa/include/mach/colibri.h +1 -1
@@ -1,7 +1,7 @@
 #ifndef _COLIBRI_H_
 #define _COLIBRI_H_
 
-#include <net/ax88796.h>
+#include <mach/mfp.h>
 
 /*
  * common settings for all modules
author
#2 lore raw
Quoted 9 lines · Daniel Mack
Quoted 3 lines · Jakob Viketoft

The use of mfp_cfg_t causes build errors without including <mach/mfp.h>. The include for the ax88796 is kicked as well since it's inclusion is obsoleted as adviced by Daniel Mack.

Argh, I'm sorry. This time, I was too fast. The ax88796 must stay, I overlooked the use of ax_plat_data.

Daniel

There's gremlins in here somewhere, I'm sure. ;) I'll try one more time...

/Jakob

Quoted 21 lines
Quoted 20 lines

CC: [email protected]
CC: Daniel Mack <[email protected]>
CC: Eric Miao <[email protected]> Signed-off-by Jakob Viketoft <[email protected]>

--- a/arch/arm/mach-pxa/include/mach/colibri.h 2010-03-15
17:09:39.000000000 +0100
+++ b/arch/arm/mach-pxa/include/mach/colibri.h 2010-04-16
13:30:43.000000000 +0200

arch/arm/mach-pxa/include/mach/colibri.h +1 -1
@@ -1,7 +1,7 @@
 #ifndef _COLIBRI_H_
 #define _COLIBRI_H_
 
-#include <net/ax88796.h>
+#include <mach/mfp.h>
 
 /*
  * common settings for all modules