Make WMI be selected automatically when needed

Many different modules depend on WMI. In Kconfig, some used to "depend" on it, while others "selected" it. As WMI by itself is useless and more like a library, it's easier for the user to have it automatically selected whenever needed. It's especially true for options in completely different places (like LEDS_DELL_NETBOOKS). So we consistently "select" it.

Signed-off-by Éric Piel <[email protected]>

---
 drivers/leds/Kconfig         |    3 ++-
 drivers/platform/x86/Kconfig |    8 ++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

drivers/leds/Kconfig +2 -1

index 505eb64..71e8a51 100644
@@ -280,7 +280,8 @@ config LEDS_ADP5520
 
 config LEDS_DELL_NETBOOKS
 	tristate "External LED on Dell Business Netbooks"
-	depends on X86 && ACPI_WMI
+	depends on X86
+	select ACPI_WMI
 	help
 	  This adds support for the Latitude 2100 and similar
 	  notebooks that have an external LED.

drivers/platform/x86/Kconfig +3 -3

index 7bec458..9808ef3 100644
@@ -89,8 +89,8 @@ config DELL_LAPTOP
 
 config DELL_WMI
 	tristate "Dell WMI extras"
-	depends on ACPI_WMI
 	depends on INPUT
+	select ACPI_WMI
 	---help---
 	  Say Y here if you want to support WMI-based hotkeys on Dell laptops.
 

@@ -136,9 +136,9 @@ config TC1100_WMI
 
 config HP_WMI
 	tristate "HP WMI extras"
-	depends on ACPI_WMI
 	depends on INPUT
 	depends on RFKILL || RFKILL = n
+	select ACPI_WMI
 	help
 	 Say Y here if you want to support WMI-based hotkeys on HP laptops and
 	 to read data from WMI such as docking or ambient light sensor state.

@@ -387,9 +387,9 @@ config EEEPC_LAPTOP
 
 config EEEPC_WMI
 	tristate "Eee PC WMI Hotkey Driver (EXPERIMENTAL)"
-	depends on ACPI_WMI
 	depends on INPUT
 	depends on EXPERIMENTAL
+	select ACPI_WMI
 	---help---
 	  Say Y here if you want to support WMI-based hotkeys on Eee PC laptops.
 

Quoted 9 lines

Many different modules depend on WMI. In Kconfig, some used to "depend" on it, while others "selected" it. As WMI by itself is useless and more like a library, it's easier for the user to have it automatically selected whenever needed. It's especially true for options in completely different places (like LEDS_DELL_NETBOOKS). So we consistently "select" it.

Signed-off-by Éric Piel <[email protected]>

config ACPI_WMI
tristate "WMI"
depends on ACPI

so what happens when one of these configs selects ACPI_WMI but ACPI is not enabled? Hint: that will not enable ACPI.

Did you test that kconfig combination?

drivers/leds/Kconfig config LEDS_ADP5520 · line 285

Quoted 7 lines

config LEDS_DELL_NETBOOKS

drivers/leds/Kconfig +3 -1

 	tristate "External LED on Dell Business Netbooks"
-	depends on X86 && ACPI_WMI
+	depends on X86
+	depends on ACPI
+	select ACPI_WMI

I dislike this. The originally stated dependencies are correct and more accurately represent what the code requires, and changing that for the sake of making it easier for people to find the driver sounds like it's trying to cover up shortcomings in our configuration system more than anything else.

Currently there are 2 modules which select ACPI_WMI and 4 which depend on it. There are 7 modules which select BACKLIGHT_CLASS_DEVICE and as many which depend on it. Making usage of the select functionality all the time would avoid these inconsistencies.