Skip to contentSkip to conversation

mx5: Add MX53 EVK board support

RFC PATCH New Rob Herring 6 participants 8 messages Apr 16, 2010 – Apr 19, 2010

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

RFC PATCH 10/10 mx5: Add MX53 EVK board support

Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/mach-mx5/Kconfig          |    7 +++
 arch/arm/mach-mx5/Makefile         |    1 +
 arch/arm/mach-mx5/board-mx53_evk.c |   88 ++++++++++++++++++++++++++++++++++++
 3 files changed, 96 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-mx5/board-mx53_evk.c
arch/arm/mach-mx5/Kconfig +7 -0
index 12e9ce7..cc08120 100644
@@ -20,4 +20,11 @@ config MACH_MX51_BABBAGE
 	  u-boot. This includes specific configurations for the board and its
 	  peripherals.
 
+config MACH_MX53_EVK
+	bool "Support MX53 EVK platform"
+	select ARCH_MX53
+	help
+	  Include support for MX53 EVK platform. This includes specific
+	  configurations for the board and its peripherals.
+
 endif
arch/arm/mach-mx5/Makefile +1 -0
index e4cf91f..201f01b 100644
@@ -6,4 +6,5 @@
 obj-y   := cpu.o mm.o clock.o devices.o
 
 obj-$(CONFIG_MACH_MX51_BABBAGE) += board-mx51_babbage.o
+obj-$(CONFIG_MACH_MX53_EVK) += board-mx53_evk.o
arch/arm/mach-mx5/board-mx53_evk.c new file +88 -0

88 lines not on this page · raw message

Signature · 1 line
1.6.0.4
#1 lore raw

RFC PATCH 10/10 mx5: Add MX53 EVK board support

Rob,

Quoted 13 lines · Rob Herring

From: Rob Herring <[email protected]>
Subject: [RFC PATCH 10/10] mx5: Add MX53 EVK board support
To: linux-arm-kernel at lists.infradead.org, s.hauer at pengutronix.de, amit.kucheria at canonical.com
Cc: "Rob Herring" <[email protected]>
Date: Friday, April 16, 2010, 4:35 PM

Signed-off-by Rob Herring <[email protected]>

---
arch/arm/mach-mx5/Kconfig? ? ? ?
? |? ? 7 +++
arch/arm/mach-mx5/Makefile? ? ?
???|? ? 1 +
arch/arm/mach-mx5/board-mx53_evk.c |???88
++++++++++++++++++++++++++++++++++++

Quoted 2 lines
 3 files changed, 96 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-mx5/board-mx53_evk.c

Shouldn't the name of this file be mach-mx53_evk.c to match the naming convention patches that Uwe sent?

Regards,

Fabio Estevam

#2 lore raw

RFC PATCH 10/10 mx5: Add MX53 EVK board support

Fabio,

Quoted 30 lines

-----Original Message-----
From: Fabio Estevam [mailto:fabioestevam at yahoo.com]
Sent: Friday, April 16, 2010 5:15 PM
To: linux-arm-kernel at lists.infradead.org;
s.hauer at pengutronix.de; amit.kucheria at canonical.com; Herring Robert-RA7055
Cc: Herring Robert-RA7055; u.kleine-koenig at pengutronix.de
Subject: Re: [RFC PATCH 10/10] mx5: Add MX53 EVK board support

Rob,

Quoted 3 lines · Rob Herring

From: Rob Herring <[email protected]>
Subject: [RFC PATCH 10/10] mx5: Add MX53 EVK board support
To: linux-arm-kernel at lists.infradead.org,

s.hauer at pengutronix.de, amit.kucheria at canonical.com

Quoted 10 lines

Cc: "Rob Herring" <[email protected]>
Date: Friday, April 16, 2010, 4:35 PM

Signed-off-by Rob Herring <[email protected]>

---
arch/arm/mach-mx5/Kconfig? ? ? ?
? |? ? 7 +++
arch/arm/mach-mx5/Makefile? ? ?
???|? ? 1 +
arch/arm/mach-mx5/board-mx53_evk.c |???88
++++++++++++++++++++++++++++++++++++

Quoted 2 lines
 3 files changed, 96 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-mx5/board-mx53_evk.c
Quoted 2 lines

Shouldn't the name of this file be mach-mx53_evk.c to match the naming convention patches that Uwe sent?

Not when Babbage board is named board-mx51_babbage.c.

Rob

#3 lore raw

RFC PATCH 10/10 mx5: Add MX53 EVK board support

Quoted 32 lines · On 10 Apr 19, Herring Robert-RA7055 wrote:

Fabio,

Quoted 30 lines

-----Original Message-----
From: Fabio Estevam [mailto:fabioestevam at yahoo.com]
Sent: Friday, April 16, 2010 5:15 PM
To: linux-arm-kernel at lists.infradead.org;
s.hauer at pengutronix.de; amit.kucheria at canonical.com; Herring Robert-RA7055
Cc: Herring Robert-RA7055; u.kleine-koenig at pengutronix.de
Subject: Re: [RFC PATCH 10/10] mx5: Add MX53 EVK board support

Rob,

Quoted 3 lines · Rob Herring

From: Rob Herring <[email protected]>
Subject: [RFC PATCH 10/10] mx5: Add MX53 EVK board support
To: linux-arm-kernel at lists.infradead.org,

s.hauer at pengutronix.de, amit.kucheria at canonical.com

Quoted 12 lines

Cc: "Rob Herring" <[email protected]>
Date: Friday, April 16, 2010, 4:35 PM

Signed-off-by Rob Herring <[email protected]>

---
arch/arm/mach-mx5/Kconfig? ? ? ?
? |? ? 7 +++
arch/arm/mach-mx5/Makefile? ? ?
???|? ? 1 +
arch/arm/mach-mx5/board-mx53_evk.c |???88
++++++++++++++++++++++++++++++++++++

 3 files changed, 96 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-mx5/board-mx53_evk.c
Quoted 5 lines
Quoted 2 lines

Shouldn't the name of this file be mach-mx53_evk.c to match the naming convention patches that Uwe sent?

Not when Babbage board is named board-mx51_babbage.c.

IMO, the current naming scheme of mach-* for SoC platforms and board-* for specific boards is a lot more intuitive than converting everything to mach-*.

Currently inside arch/arm/mach-*/ some platforms use the board-* scheme and some use the mach-* scheme.

Regards,
Amit

Signature · 3 lines
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || amit.kucheria at canonical.com
----------------------------------------------------------------------
#4 lore raw

RFC PATCH 10/10 mx5: Add MX53 EVK board support

In reply to Rob Herring

a dumb question here, I know Freescale has evk for i.mx51, what's this mx53 evk here? I did not find anything related at freescale.com either.
thanks,

Quoted 137 lines · Rob Herring
Signed-off-by Rob Herring <[email protected]>

---

?arch/arm/mach-mx5/Kconfig ? ? ? ? ?| ? ?7 +++
?arch/arm/mach-mx5/Makefile ? ? ? ? | ? ?1 +
?arch/arm/mach-mx5/board-mx53_evk.c | ? 88 ++++++++++++++++++++++++++++++++++++

?3 files changed, 96 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-mx5/board-mx53_evk.c

arch/arm/mach-mx5/Kconfig +0 -0
index 12e9ce7..cc08120 100644
@@ -20,4 +20,11 @@ config MACH_MX51_BABBAGE

? ? ? ? ?u-boot. This includes specific configurations for the board and its ? ? ? ? ?peripherals.

arch/arm/mach-mx5/Kconfig +7 -0
+config MACH_MX53_EVK
+ ? ? ? bool "Support MX53 EVK platform"
+ ? ? ? select ARCH_MX53
+ ? ? ? help
+ ? ? ? ? Include support for MX53 EVK platform. This includes specific
+ ? ? ? ? configurations for the board and its peripherals.
+

?endif

arch/arm/mach-mx5/Makefile +0 -0
index e4cf91f..201f01b 100644
@@ -6,4 +6,5 @@

?obj-y ? := cpu.o mm.o clock.o devices.o

?obj-$(CONFIG_MACH_MX51_BABBAGE) += board-mx51_babbage.o

arch/arm/mach-mx5/Makefile +1 -0
+obj-$(CONFIG_MACH_MX53_EVK) += board-mx53_evk.o
arch/arm/mach-mx5/board-mx53_evk.c new file +88 -1
new file mode 100644
index 0000000..b9d3b55
@@ -0,0 +1,88 @@
+/*
+ * Copyright (C) 2010 Freescale Semiconductor, Inc. All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ?See the
+ * GNU General Public License for more details.
+
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+#include <linux/init.h>
+#include <linux/io.h>
+#include <linux/platform_device.h>
+
+#include <mach/common.h>
+#include <mach/hardware.h>
+#include <mach/imx-uart.h>
+#include <mach/iomux-mx53.h>
+
+#include <asm/irq.h>
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+#include <asm/mach/arch.h>
+#include <asm/mach/time.h>
+
+#include "devices.h"
+
+static struct pad_desc mx51evk_pads[] = {
+ ? ? ? /* UART1 */
+ ? ? ? MX53_PAD_CSI0_D11__UART1_RXD,
+ ? ? ? MX53_PAD_CSI0_D10__UART1_TXD,
+};
+
+/* Serial ports */
+#if defined(CONFIG_SERIAL_IMX) || defined(CONFIG_SERIAL_IMX_MODULE)
+static struct imxuart_platform_data uart_pdata = {
+// ? ? .flags = IMXUART_HAVE_RTSCTS,
+};
+
+static inline void mxc_init_imx_uart(void)
+{
+ ? ? ? mxc_register_device(&mxc_uart_device0, &uart_pdata);
+ ? ? ? mxc_register_device(&mxc_uart_device1, &uart_pdata);
+ ? ? ? mxc_register_device(&mxc_uart_device2, &uart_pdata);
+}
+#else /* !SERIAL_IMX */
+static inline void mxc_init_imx_uart(void)
+{
+}
+#endif /* SERIAL_IMX */
+
+/*
+ * Board specific initialization.
+ */
+static void __init mxc_board_init(void)
+{
+// ? ? mxc_iomux_v3_setup_multiple_pads(mx51evk_pads,
+// ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(mx51evk_pads));
+ ? ? ? mxc_init_imx_uart();
+ ? ? ? mxc_register_device(&mxc_fec_device, NULL);
+}
+
+static void __init mx53_evk_timer_init(void)
+{
+ ? ? ? mx53_clocks_init(32768, 24000000, 22579200, 0);
+}
+
+static struct sys_timer mxc_timer = {
+ ? ? ? .init ? = mx53_evk_timer_init,
+};
+
+MACHINE_START(MX53_EVK, "Freescale MX53 EVK Board")
+ ? ? ? /* Maintainer: Rob Herring <[email protected]> */
+ ? ? ? .phys_io = MX51_AIPS1_BASE_ADDR - 0x20000000,
+ ? ? ? .io_pg_offst = ((MX51_AIPS1_BASE_ADDR_VIRT) >> 18) & 0xfffc,
+ ? ? ? .map_io = mx5_map_io,
+ ? ? ? .init_irq = mx5x_init_irq,
+ ? ? ? .init_machine = mxc_board_init,
+ ? ? ? .timer = &mxc_timer,
+MACHINE_END
--

1.6.0.4

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw

RFC PATCH 10/10 mx5: Add MX53 EVK board support

In reply to Rob Herring

arch/arm/mach-mx5/board-mx53_evk.c

Quoted 4 lines · Rob Herring
arch/arm/mach-mx5/board-mx53_evk.c new file +4 -0
+/* Serial ports */
+#if defined(CONFIG_SERIAL_IMX) || defined(CONFIG_SERIAL_IMX_MODULE)
+static struct imxuart_platform_data uart_pdata = {
+// ? ? .flags = IMXUART_HAVE_RTSCTS,

You forgot to run checkpatch.pl. C++ comments are not allowed.

arch/arm/mach-mx5/board-mx53_evk.c line 58

Quoted 5 lines
arch/arm/mach-mx5/board-mx53_evk.c new file +5 -0
+#else /* !SERIAL_IMX */
+static inline void mxc_init_imx_uart(void)
+{
+}
+#endif /* SERIAL_IMX */

How about:

#define mxc_init_imx_uart() do { } while (0)

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#6 lore raw

RFC PATCH 10/10 mx5: Add MX53 EVK board support

Timur,

Quoted 11 lines

-----Original Message-----
From: Timur Tabi [mailto:timur.tabi at gmail.com]
Sent: Monday, April 19, 2010 3:40 PM
To: Herring Robert-RA7055
Cc: linux-arm-kernel at lists.infradead.org;
s.hauer at pengutronix.de; amit.kucheria at canonical.com
Subject: Re: [RFC PATCH 10/10] mx5: Add MX53 EVK board support

On Fri, Apr 16, 2010 at 2:35 PM, Rob Herring
<[email protected]> wrote:

Quoted 6 lines

arch/arm/mach-mx5/board-mx53_evk.c

Quoted 4 lines
arch/arm/mach-mx5/board-mx53_evk.c new file +4 -0
+/* Serial ports */
+#if defined(CONFIG_SERIAL_IMX) || defined(CONFIG_SERIAL_IMX_MODULE)
+static struct imxuart_platform_data uart_pdata = {
+// ? ? .flags = IMXUART_HAVE_RTSCTS,

You forgot to run checkpatch.pl. C++ comments are not allowed.

Yes I know. I'm only soliciting comments on the way I have structured adding MX53 to MX51 codebase.

Quoted 10 lines

arch/arm/mach-mx5/board-mx53_evk.c line 58

Quoted 6 lines
arch/arm/mach-mx5/board-mx53_evk.c new file +5 -0
+#else /* !SERIAL_IMX */
+static inline void mxc_init_imx_uart(void)
+{
+}
+#endif /* SERIAL_IMX */

How about:

#define mxc_init_imx_uart() do { } while (0)

Just following existing code style in board-mx51_babbage.c.

Rob

#7 lore raw

RFC PATCH 10/10 mx5: Add MX53 EVK board support

Quoted 3 lines · On Mon, Apr 19, 2010 at 3:47 PM, Herring Robert-RA7055 <[email protected]>…
Quoted 1 line

You forgot to run checkpatch.pl. ?C++ comments are not allowed.

Yes I know. I'm only soliciting comments on the way I have structured adding MX53 to MX51 codebase.

Ok.

Quoted 5 lines
Quoted 3 lines

How about:

#define mxc_init_imx_uart() do { } while (0)

Just following existing code style in board-mx51_babbage.c.

I understand, but I believe the consensus for general kernel development is to use "#define .. do while(0)" to represent a no-op function.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale