mpc83xx: turn on icache in core initialization to improve u-boot boot time

PATCH Superseded Kim Phillips 6 participants 15 messages Apr 15, 2010 – Oct 27, 2010

lore

Share & tools

lore

Kim Phillips

author

2010-04-15 22:36 UTC #0 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

before, MPC8349ITX boots u-boot in 4.3sec:

column1 is elapsed time since first message
column2 is elapsed time since previous message
column3 is the message
0.000 0.000: U-Boot 2010.03-00126-gfd4e49c (Apr 11 2010 - 17:25:29) MPC83XX 0.000 0.000:
0.000 0.000: Reset Status:
0.000 0.000:
0.032 0.032: CPU: e300c1, MPC8349E, Rev: 1.1 at 533.333 MHz, CSB: 266.667 MHz
0.032 0.000: Board: Freescale MPC8349E-mITX

0.032 0.000: UPMA:  Configured for compact flash
0.032 0.000: I2C:   ready
0.061 0.028: DRAM:  256 MB (DDR1, 64-bit, ECC off, 266.667 MHz)
1.516 1.456: FLASH: 16 MB
2.641 1.125: PCI:   Bus Dev VenId DevId Class Int
2.652 0.011:         00  10  1095  3114  0180  00
2.652 0.000: PCI:   Bus Dev VenId DevId Class Int
2.652 0.000: In:    serial
2.652 0.000: Out:   serial
2.652 0.000: Err:   serial

2.682 0.030: Board revision: 1.0 (PCF8475A)
3.080 0.398: Net: TSEC1: No support for PHY id ffffffff; assuming generic
3.080 0.000: TSEC0, TSEC1
4.300 1.219: IDE: Bus 0: .** Timeout **

after, MPC8349ITX boots u-boot in 3.0sec:

0.010 0.010: U-Boot 2010.03-00127-g4b468cc-dirty (Apr 11 2010 - 17:47:29) MPC83XX 0.010 0.000:
0.010 0.000: Reset Status:
0.010 0.000:
0.017 0.007: CPU: e300c1, MPC8349E, Rev: 1.1 at 533.333 MHz, CSB: 266.667 MHz
0.017 0.000: Board: Freescale MPC8349E-mITX

0.038 0.020: UPMA:  Configured for compact flash
0.038 0.000: I2C:   ready
0.038 0.000: DRAM:  256 MB (DDR1, 64-bit, ECC off, 266.667 MHz)
0.260 0.222: FLASH: 16 MB
1.390 1.130: PCI:   Bus Dev VenId DevId Class Int
1.390 0.000:         00  10  1095  3114  0180  00
1.390 0.000: PCI:   Bus Dev VenId DevId Class Int
1.400 0.010: In:    serial
1.400 0.000: Out:   serial
1.400 0.000: Err:   serial

1.400 0.000: Board revision: 1.0 (PCF8475A)
1.832 0.432: Net: TSEC1: No support for PHY id ffffffff; assuming generic
1.832 0.000: TSEC0, TSEC1
3.038 1.205: IDE: Bus 0: .** Timeout **

also tested on these boards (albeit with a less accurate boottime measurement method):

seconds: before  after
8349MDS  ~2.6    ~2.2
8360MDS  ~2.8    ~2.6
8313RDB  ~2.5    ~2.3 #nand boot
837xRDB  ~3.1    ~2.3

also tested on an 8323ERDB.

Signed-off-by Kim Phillips <[email protected]>

---
please test!

 include/configs/MPC8313ERDB.h   |    3 ++-
 include/configs/MPC8315ERDB.h   |    5 +++--
 include/configs/MPC8323ERDB.h   |    5 +++--
 include/configs/MPC832XEMDS.h   |    5 +++--
 include/configs/MPC8349EMDS.h   |    3 ++-
 include/configs/MPC8360EMDS.h   |    5 +++--
 include/configs/MPC8360ERDK.h   |    5 +++--
 include/configs/MPC837XEMDS.h   |    5 +++--
 include/configs/MPC837XERDB.h   |    5 +++--
 include/configs/MVBLM7.h        |    3 ++-
 include/configs/SIMPC8313.h     |    5 +++--
 include/configs/TQM834x.h       |    3 ++-
 include/configs/km83xx-common.h |    3 ++-
 include/configs/sbc8349.h       |    3 ++-
 include/configs/vme8349.h       |    3 ++-
 15 files changed, 38 insertions(+), 23 deletions(-)

include/configs/MPC8313ERDB.h +2 -1

index a2e4cd4..94695fc 100644
@@ -517,7 +517,8 @@
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
 #define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
-			 HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
+				 HID0_ENABLE_INSTRUCTION_CACHE | \
+				 HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
 
 #define CONFIG_SYS_HID2 HID2_HBE

include/configs/MPC8315ERDB.h +3 -2

index b106aa9..6972fe8 100644
@@ -536,8 +536,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		(HID0_ENABLE_MACHINE_CHECK | \
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE | \
 				 HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
 #define CONFIG_SYS_HID2		HID2_HBE

include/configs/MPC8323ERDB.h +3 -2

index 50aea79..7c84393 100644
@@ -438,8 +438,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC832XEMDS.h +3 -2

index f7632e0..7bd2793 100644
@@ -455,8 +455,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC8349EMDS.h +2 -1

index 5c410c9..73dbea4 100644
@@ -598,7 +598,8 @@
 #define CONFIG_SYS_SICRL SICRL_LDP_A
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 
 /* #define CONFIG_SYS_HID0_FINAL		(\
 	HID0_ENABLE_INSTRUCTION_CACHE |\

include/configs/MPC8360EMDS.h +3 -2

index 620e32c..87a137b 100644
@@ -495,8 +495,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC8360ERDK.h +3 -2

index a43e465..e78cf60 100644
@@ -412,8 +412,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC837XEMDS.h +3 -2

index 1565ff9..b30d0e3 100644
@@ -544,8 +544,9 @@ extern int board_pci_host_broken(void);
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC837XERDB.h +3 -2

index 97a05a2..1654f46 100644
@@ -552,8 +552,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MVBLM7.h +2 -1

index 6cc8d58..26897c6 100644
@@ -321,7 +321,8 @@
 #define CONFIG_SYS_SICRL	(SICRL_LDP_A | SICRL_USB1 | SICRL_USB0)
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	CONFIG_SYS_HID0_INIT
+#define CONFIG_SYS_HID0_FINAL	(CONFIG_SYS_HID0_INIT | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 
 #define CONFIG_SYS_HID2	HID2_HBE
 #define CONFIG_HIGH_BATS	1

include/configs/SIMPC8313.h +3 -2

index 40e89d9..84af8df 100644
@@ -411,8 +411,9 @@
 				| SICRL_ETSEC2_A )
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK	\
-				| HID0_ENABLE_DYNAMIC_POWER_MANAGMENT )
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE | \
+				 HID0_ENABLE_DYNAMIC_POWER_MANAGMENT )
 
 #define CONFIG_SYS_HID2		HID2_HBE

include/configs/TQM834x.h +2 -1

index f08c0a9..c1e0e64 100644
@@ -405,7 +405,8 @@ extern int tqm834x_num_flash_banks;
 
 /* i-cache and d-cache disabled */
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	CONFIG_SYS_HID0_INIT
+#define CONFIG_SYS_HID0_FINAL	(CONFIG_SYS_HID0_INIT | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2	HID2_HBE
 
 #define CONFIG_HIGH_BATS	1	/* High BATs supported */

include/configs/km83xx-common.h +2 -1

index 71dfd25..a551b4d 100644
@@ -255,7 +255,8 @@
  * Core HID Setup
  */
 #define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_FINAL		(HID0_ENABLE_MACHINE_CHECK | \
+					 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2			HID2_HBE
 
 /*

include/configs/sbc8349.h +2 -1

index 80f83ac..deaddde 100644
@@ -542,7 +542,8 @@
 #define CONFIG_SYS_SICRL SICRL_LDP_A
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 
 /* #define CONFIG_SYS_HID0_FINAL		(\
 	HID0_ENABLE_INSTRUCTION_CACHE |\

include/configs/vme8349.h +2 -1

index cb987a1..f493e75 100644
@@ -449,7 +449,8 @@
 #define CONFIG_SYS_SICRL SICRL_LDP_A
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 
 #define CONFIG_SYS_HID2		HID2_HBE

Signature · 1 line

1.7.0.5

Michael Zaidman

2010-04-16 17:06 UTC #1 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

Quoted 1 line · Kim Phillips

before, MPC8349ITX boots u-boot in 4.3sec:

[snip]

Quoted 1 line

after, MPC8349ITX boots u-boot in 3.0sec:

Thanks for the good news! Memory POST test on my board with icach disabled was lasting for hours until I enabled icach locally before and disabled it after time consuming tests.

BTW is there any reason that you enable icach in board specific rather than in common code?

-michael

Kim Phillips

author

2010-04-19 20:23 UTC #2 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

Quoted 4 lines · On Fri, 16 Apr 2010 20:06:02 +0300 Michael Zaidman <[email protected]>…

Quoted 1 line · Kim Phillips
before, MPC8349ITX boots u-boot in 4.3sec:
[snip]

Quoted 8 lines

Quoted 1 line
after, MPC8349ITX boots u-boot in 3.0sec:
Thanks for the good news! Memory POST test on my board with icach disabled was lasting for hours until I enabled icach locally before and disabled it after time consuming tests.
BTW is there any reason that you enable icach in board specific rather than in common code?

not really, was just following the existing HID0-setting paradigm - I presume the paradigm came about to allow different cpu/board combinations to enable/disable different HID bits. Does that not sound valid to you?

Kim

Scott Wood

2010-04-19 20:19 UTC #3 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

Quoted 12 lines · Kim Phillips

Quoted 9 lines · On Fri, 16 Apr 2010 20:06:02 +0300 Michael Zaidman <[email protected]>…
Quoted 1 line · Kim Phillips
before, MPC8349ITX boots u-boot in 4.3sec:
[snip]
Quoted 1 line
after, MPC8349ITX boots u-boot in 3.0sec:
Thanks for the good news! Memory POST test on my board with icach disabled was lasting for hours until I enabled icach locally before and disabled it after time consuming tests.

Quoted 7 lines

Quoted 2 lines
BTW is there any reason that you enable icach in board specific rather than in common code?
not really, was just following the existing HID0-setting paradigm - I presume the paradigm came about to allow different cpu/board combinations to enable/disable different HID bits. Does that not sound valid to you?

Shouldn't you be using icache_enable(), or at least using HID0_INIT to do invalidation and lock clearing?

-Scott

Kim Phillips

author

2010-04-19 22:34 UTC #4 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

Quoted 16 lines · On Mon, 19 Apr 2010 15:19:24 -0500 Scott Wood <[email protected]> wrote:

Quoted 15 lines · Kim Phillips
Quoted 11 lines · On Fri, 16 Apr 2010 20:06:02 +0300 Michael Zaidman <[email protected]>…
Quoted 1 line · Kim Phillips
before, MPC8349ITX boots u-boot in 4.3sec:
[snip]
Quoted 1 line
after, MPC8349ITX boots u-boot in 3.0sec:
Thanks for the good news! Memory POST test on my board with icach disabled was lasting for hours until I enabled icach locally before and disabled it after time consuming tests.
BTW is there any reason that you enable icach in board specific rather than in common code?

Quoted 7 lines

Quoted 4 lines
not really, was just following the existing HID0-setting paradigm - I presume the paradigm came about to allow different cpu/board combinations to enable/disable different HID bits. Does that not sound valid to you?
Shouldn't you be using icache_enable(), or at least using HID0_INIT to do invalidation and lock clearing?

the invalidation should occur whether or not the cache enable bit is set in HID0_INIT, and there is no locking being done prior to this point in the code. But I see your point; we should be using a more formal approach. I'll see what I can do - it's just that this patch preserved the existing code size, which could be important for e.g., future nand bootstrap development.

Kim

Scott Wood

2010-04-19 22:35 UTC #5 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

Quoted 7 lines · Kim Phillips

Quoted 2 lines · On Mon, 19 Apr 2010 15:19:24 -0500 Scott Wood <[email protected]> wrote:
Shouldn't you be using icache_enable(), or at least using HID0_INIT to do invalidation and lock clearing?
the invalidation should occur whether or not the cache enable bit is set in HID0_INIT,

OK, was thinking of some other caches that don't automatically clear out the random junk on power-on -- but e300 manual says it does.

Quoted 4 lines

But I see your point; we should be using a more
formal approach. I'll see what I can do - it's just that this patch preserved the existing code size, which could be important for e.g., future nand bootstrap development.

Right. It looks like we could shrink the NAND SPL some more by #ifndefing the cache functions in start.S.

-Scott

Timur Tabi

2010-04-19 20:30 UTC #6 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

In reply to Kim Phillips

Quoted 4 lines · Kim Phillips

?#define CONFIG_SYS_HID0_FINAL ?(HID0_ENABLE_MACHINE_CHECK | \
- ? ? ? ? ? ? ? ? ? ? ? ?HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?HID0_ENABLE_INSTRUCTION_CACHE | \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)

What was so special about the 8349ITX that icache() didn't work? You're changing the HDI0 values for all of the 83xx boards, but AFAIK, only the ITX had this problem.

Signature · 2 lines

Timur Tabi
Linux kernel developer at Freescale

Scott Wood

2010-04-19 20:41 UTC #7 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

Quoted 11 lines · Timur Tabi

include/configs/MPC8313ERDB.h line 521
Quoted 4 lines · Kim Phillips
#define CONFIG_SYS_HID0_FINAL (HID0_ENABLE_MACHINE_CHECK | \
include/configs/MPC8313ERDB.h +2 -1
-                        HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
+                                HID0_ENABLE_INSTRUCTION_CACHE | \
+                                HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
What was so special about the 8349ITX that icache() didn't work? You're changing the HDI0 values for all of the 83xx boards, but AFAIK, only the ITX had this problem.

All 83xx boards had the performance problem of not enabling icache until after relocation.

-Scott

Timur Tabi

2010-04-19 21:05 UTC #8 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

Quoted 6 lines · Scott Wood

Quoted 3 lines
What was so special about the 8349ITX that icache() didn't work? You're changing the HDI0 values for all of the 83xx boards, but AFAIK, only the ITX had this problem.
All 83xx boards had the performance problem of not enabling icache until after relocation.

That's not what I was asking. The ITX was different from other 83xx boards. It doesn't define CONFIG_MPC83xx (and with this patch, it still won't define it), so a lot of things weren't happening, including this:

#if defined(CONFIG_SYS_DELAYED_ICACHE) || defined(CONFIG_MPC83xx)
	icache_enable ();	/* it's time to enable the instruction cache */

#endif

Kim references the ITX in this patch, but I don't see how the problem I just described is fixed.

Signature · 2 lines

Timur Tabi
Linux kernel developer at Freescale

Kim Phillips

author

2010-04-19 21:37 UTC #9 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

Quoted 11 lines · On Mon, 19 Apr 2010 16:05:11 -0500 Timur Tabi <[email protected]> wrote:

Quoted 6 lines · Scott Wood
Quoted 3 lines
What was so special about the 8349ITX that icache() didn't work? You're changing the HDI0 values for all of the 83xx boards, but AFAIK, only the ITX had this problem.
All 83xx boards had the performance problem of not enabling icache until after relocation.
That's not what I was asking. The ITX was different from other 83xx boards. It doesn't define CONFIG_MPC83xx (and with this patch, it

why doesn't it, btw?

Quoted 8 lines

still won't define it), so a lot of things weren't happening, including this:
#if defined(CONFIG_SYS_DELAYED_ICACHE) || defined(CONFIG_MPC83xx)
	icache_enable ();	/* it's time to enable the instruction cache */
#endif
Kim references the ITX in this patch, but I don't see how the problem I just described is fixed.

patch submission snafu; I'll send another version that includes the ITX.

Kim

Timur Tabi

2010-04-20 01:39 UTC #10 lore raw

PATCH 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

Quoted 4 lines · Kim Phillips

Quoted 2 lines
That's not what I was asking. ?The ITX was different from other 83xx boards. ?It doesn't define CONFIG_MPC83xx (and with this patch, it
why doesn't it, btw?

It's been a while, but I believe the reason the ITX does not defined CONFIG_MPC83xx is specifically so that this code:

#if defined(CONFIG_SYS_DELAYED_ICACHE) || defined(CONFIG_MPC83xx)
       icache_enable ();       /* it's time to enable the instruction cache */

#endif

is *not* executed. That is, on the ITX, calling icache_enable() at that point causes U-Boot to hang or crash.

Therefore, I don't think any 83xx cache-related patch is complete until MPC8349ITX.h includes CONFIG_MPC83xx.

Signature · 2 lines

Timur Tabi
Linux kernel developer at Freescale

Kim Phillips

author

2010-04-21 00:37 UTC #11 lore raw

PATCH v2 3/3 mpc83xx: turn on icache in core initialization to improve u-boot boot time

before, MPC8349ITX boots u-boot in 4.3sec:

0.032 0.000: UPMA:  Configured for compact flash
0.032 0.000: I2C:   ready
0.061 0.028: DRAM:  256 MB (DDR1, 64-bit, ECC off, 266.667 MHz)
1.516 1.456: FLASH: 16 MB
2.641 1.125: PCI:   Bus Dev VenId DevId Class Int
2.652 0.011:         00  10  1095  3114  0180  00
2.652 0.000: PCI:   Bus Dev VenId DevId Class Int
2.652 0.000: In:    serial
2.652 0.000: Out:   serial
2.652 0.000: Err:   serial

2.682 0.030: Board revision: 1.0 (PCF8475A)
3.080 0.398: Net: TSEC1: No support for PHY id ffffffff; assuming generic
3.080 0.000: TSEC0, TSEC1
4.300 1.219: IDE: Bus 0: .** Timeout **

after, MPC8349ITX boots u-boot in 3.0sec:

0.038 0.020: UPMA:  Configured for compact flash
0.038 0.000: I2C:   ready
0.038 0.000: DRAM:  256 MB (DDR1, 64-bit, ECC off, 266.667 MHz)
0.260 0.222: FLASH: 16 MB
1.390 1.130: PCI:   Bus Dev VenId DevId Class Int
1.390 0.000:         00  10  1095  3114  0180  00
1.390 0.000: PCI:   Bus Dev VenId DevId Class Int
1.400 0.010: In:    serial
1.400 0.000: Out:   serial
1.400 0.000: Err:   serial

1.400 0.000: Board revision: 1.0 (PCF8475A)
1.832 0.432: Net: TSEC1: No support for PHY id ffffffff; assuming generic
1.832 0.000: TSEC0, TSEC1
3.038 1.205: IDE: Bus 0: .** Timeout **

also tested on these boards (albeit with a less accurate boottime measurement method):

seconds: before  after
8349MDS  ~2.6    ~2.2
8360MDS  ~2.8    ~2.6
8313RDB  ~2.5    ~2.3 #nand boot
837xRDB  ~3.1    ~2.3

also tested on an 8323ERDB.

v2: also remove the delayed icache enablement assumption in arch ppc's board.c, and add a CONFIG_MPC83xx define in the ITX config file for consistency (even though it was already being defined in 83xx' config.mk).

Signed-off-by Kim Phillips <[email protected]>

---
 arch/ppc/lib/board.c            |    2 +-
 include/configs/MPC8313ERDB.h   |    3 ++-
 include/configs/MPC8315ERDB.h   |    5 +++--
 include/configs/MPC8323ERDB.h   |    5 +++--
 include/configs/MPC832XEMDS.h   |    5 +++--
 include/configs/MPC8349EMDS.h   |    3 ++-
 include/configs/MPC8349ITX.h    |    5 +++--
 include/configs/MPC8360EMDS.h   |    5 +++--
 include/configs/MPC8360ERDK.h   |    5 +++--
 include/configs/MPC837XEMDS.h   |    5 +++--
 include/configs/MPC837XERDB.h   |    5 +++--
 include/configs/MVBLM7.h        |    3 ++-
 include/configs/SIMPC8313.h     |    5 +++--
 include/configs/TQM834x.h       |    3 ++-
 include/configs/km83xx-common.h |    3 ++-
 include/configs/sbc8349.h       |    3 ++-
 include/configs/vme8349.h       |    3 ++-
 17 files changed, 42 insertions(+), 26 deletions(-)

arch/ppc/lib/board.c +1 -1

index a30acee..7b09fb5 100644
@@ -686,7 +686,7 @@ void board_init_r (gd_t *id, ulong dest_addr)
 
 	WATCHDOG_RESET();
 
-#if defined(CONFIG_SYS_DELAYED_ICACHE) || defined(CONFIG_MPC83xx)
+#if defined(CONFIG_SYS_DELAYED_ICACHE)
 	icache_enable ();	/* it's time to enable the instruction cache */
 #endif

include/configs/MPC8313ERDB.h +2 -1

index a2e4cd4..94695fc 100644
@@ -517,7 +517,8 @@
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
 #define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
-			 HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
+				 HID0_ENABLE_INSTRUCTION_CACHE | \
+				 HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
 
 #define CONFIG_SYS_HID2 HID2_HBE

include/configs/MPC8315ERDB.h +3 -2

index b106aa9..6972fe8 100644
@@ -536,8 +536,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		(HID0_ENABLE_MACHINE_CHECK | \
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE | \
 				 HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
 #define CONFIG_SYS_HID2		HID2_HBE

include/configs/MPC8323ERDB.h +3 -2

index 50aea79..7c84393 100644
@@ -438,8 +438,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC832XEMDS.h +3 -2

index f7632e0..7bd2793 100644
@@ -455,8 +455,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC8349EMDS.h +2 -1

index 5c410c9..73dbea4 100644
@@ -598,7 +598,8 @@
 #define CONFIG_SYS_SICRL SICRL_LDP_A
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 
 /* #define CONFIG_SYS_HID0_FINAL		(\
 	HID0_ENABLE_INSTRUCTION_CACHE |\

include/configs/MPC8349ITX.h +3 -2

index 09f9e38..9be571f 100644
@@ -63,6 +63,7 @@
 /*
  * High Level Configuration Options
  */
+#define CONFIG_MPC83xx		1
 #define CONFIG_MPC834x		/* MPC834x family (8343, 8347, 8349) */
 #define CONFIG_MPC8349		/* MPC8349 specific */

@@ -596,8 +597,8 @@ boards, we say we have two, but don't display a message if we find only one. */
 #define CONFIG_SYS_SICRH SICRH_TSOBI1	/* Needed for gigabit to work on TSEC 1 */
 #define CONFIG_SYS_SICRL (SICRL_LDP_A | SICRL_USB1)	/* USB DR as device + USB MPH as host */
 
-#define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	CONFIG_SYS_HID0_INIT
+#define CONFIG_SYS_HID0_INIT	0x00000000
+#define CONFIG_SYS_HID0_FINAL	HID0_ENABLE_INSTRUCTION_CACHE
 
 #define CONFIG_SYS_HID2	HID2_HBE
 #define CONFIG_HIGH_BATS	1	/* High BATs supported */

include/configs/MPC8360EMDS.h +3 -2

index 620e32c..87a137b 100644
@@ -495,8 +495,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC8360ERDK.h +3 -2

index a43e465..e78cf60 100644
@@ -412,8 +412,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC837XEMDS.h +3 -2

index 1565ff9..b30d0e3 100644
@@ -544,8 +544,9 @@ extern int board_pci_host_broken(void);
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MPC837XERDB.h +3 -2

index 97a05a2..1654f46 100644
@@ -552,8 +552,9 @@
 /*
  * Core HID Setup
  */
-#define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_INIT	0x000000000
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2		HID2_HBE
 
 /*

include/configs/MVBLM7.h +2 -1

index 6cc8d58..26897c6 100644
@@ -321,7 +321,8 @@
 #define CONFIG_SYS_SICRL	(SICRL_LDP_A | SICRL_USB1 | SICRL_USB0)
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	CONFIG_SYS_HID0_INIT
+#define CONFIG_SYS_HID0_FINAL	(CONFIG_SYS_HID0_INIT | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 
 #define CONFIG_SYS_HID2	HID2_HBE
 #define CONFIG_HIGH_BATS	1

include/configs/SIMPC8313.h +3 -2

index 40e89d9..84af8df 100644
@@ -411,8 +411,9 @@
 				| SICRL_ETSEC2_A )
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK	\
-				| HID0_ENABLE_DYNAMIC_POWER_MANAGMENT )
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE | \
+				 HID0_ENABLE_DYNAMIC_POWER_MANAGMENT )
 
 #define CONFIG_SYS_HID2		HID2_HBE

include/configs/TQM834x.h +2 -1

index f08c0a9..c1e0e64 100644
@@ -405,7 +405,8 @@ extern int tqm834x_num_flash_banks;
 
 /* i-cache and d-cache disabled */
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	CONFIG_SYS_HID0_INIT
+#define CONFIG_SYS_HID0_FINAL	(CONFIG_SYS_HID0_INIT | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2	HID2_HBE
 
 #define CONFIG_HIGH_BATS	1	/* High BATs supported */

include/configs/km83xx-common.h +2 -1

index 71dfd25..a551b4d 100644
@@ -255,7 +255,8 @@
  * Core HID Setup
  */
 #define CONFIG_SYS_HID0_INIT		0x000000000
-#define CONFIG_SYS_HID0_FINAL		HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_FINAL		(HID0_ENABLE_MACHINE_CHECK | \
+					 HID0_ENABLE_INSTRUCTION_CACHE)
 #define CONFIG_SYS_HID2			HID2_HBE
 
 /*

include/configs/sbc8349.h +2 -1

index 80f83ac..deaddde 100644
@@ -542,7 +542,8 @@
 #define CONFIG_SYS_SICRL SICRL_LDP_A
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 
 /* #define CONFIG_SYS_HID0_FINAL		(\
 	HID0_ENABLE_INSTRUCTION_CACHE |\

include/configs/vme8349.h +2 -1

index cb987a1..f493e75 100644
@@ -449,7 +449,8 @@
 #define CONFIG_SYS_SICRL SICRL_LDP_A
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-#define CONFIG_SYS_HID0_FINAL	HID0_ENABLE_MACHINE_CHECK
+#define CONFIG_SYS_HID0_FINAL	(HID0_ENABLE_MACHINE_CHECK | \
+				 HID0_ENABLE_INSTRUCTION_CACHE)
 
 #define CONFIG_SYS_HID2		HID2_HBE

Signature · 1 line

1.7.0.5

Richard Retanubun

2010-10-19 16:03 UTC #12 lore raw

[U-Boot] ICACHE in core initialization to improve u-boot boot time: Breaks booting with i2c code while executing in flash.

Hi Kim,

I recently rebased our platform from uboot 2009.11 to 2010.09 and tried out the ICACHE improvements you made in commit 1a2e203b31d33fb720f2cf1033b241ad36ab405a

It does not work on our platform (similar to MPC8360EMDS). I think this is specific to our platform because we need to initialize i2c and use i2c while still executing from flash in checkboard()) to read and parse a board-id i2c-eeprom to support a unified uboot binary for multiple board flavors.

I pasted checkboard code below; none of the underlying code uses malloc, just static buffer allocations.

Just an FYI mostly, I am okay with not having ICACHE for our board while in uboot. Just curious if you know of a reason from the limited explanation I've provided.

Also, as a general rule, does uboot accept hosting custom non-eval-platform boards? I'm tempted to mainline our code (mostly contained under /board/$company_name/...)

Thanks for your time

- Richard

/* ------------------- gd->board_type is identified here -------------------- */ int checkboard(void)

{
	int rc = -EINVAL;
	int i  = -1;
	int nbytes = 0;
	char pnbuf[512] = {0};


	rc = -EINVAL; /* Initialize return code */

	/*
	 * Based on code from cm5200, called while u-boot is executing in flash,
	 * thus things like malloc are not allowed.
	*/

	/*
	 * We need I2C to access HW ID data from EEPROM, so we call i2c_init()
	 * here despite the fact that it will be called again later on. We
	 * also use a little trick to silence I2C-related output.
	 */
	gd->flags |= GD_FLG_SILENT;
	i2c_init (CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
	gd->flags &= ~GD_FLG_SILENT;

	/* Reset i2c controller(s) to clear any stuck-bus conditions */
	i2c_bus_reset(CONFIG_SYS_IMMR + CONFIG_SYS_I2C_OFFSET);
#if defined(CONFIG_SYS_I2C2_OFFSET)
	i2c_bus_reset(CONFIG_SYS_IMMR + CONFIG_SYS_I2C2_OFFSET);
#endif /* CONFIG_SYS_I2C2_OFFSET */
	/* Print a message to stay off the i2c bus for devices to settle */
	puts("I2C:   Reset\n");

	rc = rc_id_board_from_esig(); /* fills in gd->board_type */
	if (rc == 0) {
		printf("BOARD: %s [%08lX]\n",
			rc_get_string_from_board_type(gd->board_type),
			gd->board_type);
	} else {

		/* BAD PARTNUMBER OR BAD I2C ACCESS, REBOOT */
		printf("BOARD: FAILED IDENTIFICATION, error %d\n", rc);
	}

	/* Always return 0, otherwise u-boot will halt and ask for reset */
	return 0;
}

Wolfgang Denk

2010-10-20 19:50 UTC #13 lore raw

[U-Boot] ICACHE in core initialization to improve u-boot boot time: Breaks booting with i2c code while executing in flash.

Dear Richard Retanubun,

Quoted 4 lines · In message <[email protected]> you wrote:

It does not work on our platform (similar to MPC8360EMDS). I think this is specific to our platform because we need to initialize i2c and use i2c while still executing from flash in checkboard()) to read and parse a board-id i2c-eeprom to support a unified uboot binary for multiple board flavors.

Many boards do that. Some keep the environment in I2C EEPROM as well. This should not collide ith instruction caches on.

Quoted 2 lines

Just an FYI mostly, I am okay with not having ICACHE for our board while in uboot. Just curious if you know of a reason from the limited explanation I've provided.

Check how your boot device (NOR flash) is mapped - make sure it has the BI (burst inhibit) bit set (or whatever it may be called on that CPU).

Quoted 1 line

Also, as a general rule, does uboot accept hosting custom non-eval-platform boards?

Yes, of course. We have tons of them.

Quoted 1 line

I'm tempted to mainline our code (mostly contained under /board/$company_name/...)

That is highly recommended, as it will make it much easier for you to keep the code working during the product's lifetime.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Life is a garment we continuously alter, but which  never  seems  to
fit."                                                  - David McCord

Richard Retanubun

2010-10-27 17:42 UTC #14 lore raw

[U-Boot] ICACHE in core initialization to improve u-boot boot time: Breaks booting with i2c code while executing in flash.

Quoted 8 lines · Wolfgang Denk

Dear Richard Retanubun,
Quoted 4 lines · In message<[email protected]> you wrote:
It does not work on our platform (similar to MPC8360EMDS). I think this is specific to our platform because we need to initialize i2c and use i2c while still executing from flash in checkboard()) to read and parse a board-id i2c-eeprom to support a unified uboot binary for multiple board flavors.

Quoted 8 lines

Many boards do that. Some keep the environment in I2C EEPROM as well. This should not collide With instruction caches on.
Quoted 2 lines
Just an FYI mostly, I am okay with not having ICACHE for our board while in uboot. Just curious if you know of a reason from the limited explanation I've provided.
Check how your boot device (NOR flash) is mapped - make sure it has the BI (burst inhibit) bit set (or whatever it may be called on that CPU).

Thanks for taking the time Wolfgang, now you got me curious, so I did a little reading. For MPC8360MDS reference board access the NOR flash in GPCM (General Purpose Control Machine) mode which does not have a "burst inhibit" bit, only the UPM mode of the local bus controller have this.

The only other place 'inhibit' is mentioned that would make sense is the Block Address Translation (BAT) my settings are identical to MPC8360MDS with one exception, MDS maps flash to BAT3 (considered low-BAT) mine is on BAT6 (considered high-BAT), and yes my HID1 register setting enables the high-BATs.

Not sure how any of these matters, though.

Another observation I've made is by turning on CONFIG_DISPLAY_AER_FULL or CONFIG_DISPLAY_AER_BRIEF and printing it from cpu_init.c:prt_83xx_rsr() causes the same checkboard() function to fail accessing the i2c-eeprom, even though the contents are correct. However, if I move the printf of:

printf("AEATR=0x%08lX, AEADR=0x%08lX\n", gd->arbiter_event_attributes, gd->arbiter_event_address); Into checkboard() (before i2c early init, all works okay)

So there seems to be a sensitivity in fsl-i2c drive while running from flash during early init although I am too ignorant to suspect anything right now.

Thanks for everyone's time...

- Richard