nfs: testing for null instead of ERR_PTR()

PATCH New Dan Carpenter 1 participant 1 message Apr 21, 2010

Subsystems (3)

Kernel janitors NFS client NFS server

lore

Share & tools

lore

Dan Carpenter

author

2010-04-21 10:35 UTC #0 lore raw

PATCH 1/1 nfs: testing for null instead of ERR_PTR()

nfs_path() returns an ERR_PTR(), it doesn't return null.

Signed-off-by Dan Carpenter <[email protected]>

fs/nfs/super.c +1 -1

index e016372..f9327bb 100644
@@ -2657,7 +2657,7 @@ static void nfs_fix_devname(const struct path *path, struct vfsmount *mnt)
 	devname = nfs_path(path->mnt->mnt_devname,
 			path->mnt->mnt_root, path->dentry,
 			page, PAGE_SIZE);
-	if (devname = NULL)
+	if (IS_ERR(devname))
 		goto out_freepage;
 	tmp = kstrdup(devname, GFP_KERNEL);
 	if (tmp = NULL)