Skip to contentSkip to conversation

rtnetlink: potential ERR_PTR dereference

PATCH Applied Dan Carpenter 3 participants 3 messages Apr 22, 2010

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 rtnetlink: potential ERR_PTR dereference

In the original code, if rtnl_create_link() returned an ERR_PTR then that would get passed to rtnl_configure_link() which dereferences it.

Signed-off-by Dan Carpenter <[email protected]>

---
Found by a static checker, and compile tested only. :/

net/core/rtnetlink.c +3 -2
index 4568120..fe776c9 100644
@@ -1270,10 +1270,11 @@ replay:
 			err = ops->newlink(net, dev, tb, data);
 		else
 			err = register_netdevice(dev);
-		if (err < 0 && !IS_ERR(dev)) {
+
+		if (err < 0 && !IS_ERR(dev))
 			free_netdev(dev);
+		if (err < 0)
 			goto out;
-		}
 
 		err = rtnl_configure_link(dev, ifm);
 		if (err < 0)